From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E57DC433DF for ; Tue, 19 May 2020 22:15:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CFBC7207E8 for ; Tue, 19 May 2020 22:15:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="R1QBH9j9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFBC7207E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4B3C08001E; Tue, 19 May 2020 18:15:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43B5C900003; Tue, 19 May 2020 18:15:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DC6F8001E; Tue, 19 May 2020 18:15:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id 11CD1900003 for ; Tue, 19 May 2020 18:15:55 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CA8B78248076 for ; Tue, 19 May 2020 22:15:54 +0000 (UTC) X-FDA: 76834877028.26.mass94_50b1d63a58e08 X-HE-Tag: mass94_50b1d63a58e08 X-Filterd-Recvd-Size: 3937 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 May 2020 22:15:54 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id u6so1430266ljl.6 for ; Tue, 19 May 2020 15:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rxz1rZqNlsCeuSR9curwxPKa4W3jWsGY4pCm9jvZnw4=; b=R1QBH9j9Pfl17Bi+U8Qt2VYdio0ibXZeuPzMFPRICYI09H3qud7ZA4YhliJOOAHMyI XnH/PDsy9mOHrzltFj/g3AaYFFgEuvacpT69/ZdVP0CmwhSkE9FOGeflb/LncvcAMaQQ +4lUtF5q19jT0bHX4DRT+eOQ5YTpWKhQZ8bm+b+shDMlZqKFhNTIOeEy79zvtgcc2CzO KfRdFtFBkugMp4EWpLIDt3RTCpPwBGqumGzd2kdRK1EPcqv2mp4hIONURpKdHrAgaL5n H8TnZuYXMvUbkTnG7vvm4ZHQWUxN7FYYU28AaK4RP+IGyHFAfrwQwpwbQJeWzkiP9dAa JN8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rxz1rZqNlsCeuSR9curwxPKa4W3jWsGY4pCm9jvZnw4=; b=Lkorrm/Mad8wg4xTiAMcR/9XnFH3Vz48Tv9CF7Hqhiyx6Rcxbjz+u8wbs++I8V5vSR WOWI0sAN2bjD9T0HuqvH2DzDkn1gPQxiglG0pOS4E7s9OkQiNVnqIm7is7KLO3rRB3Cd +PN51bAZYFrk1c+SOQkMg+hYGANTF8pppOSJDoGbQx4hHslray+Yt3bYMrL6R1oiRAU+ 5ryRNLGtEDSYQdCkeY9ieTUIlUIfAX7r+8IJhfMvuh0UVMjFpJHErLpzldRLFUTDvtO/ 1asVCgmTE2oc9YiWxKRcGt1VbWFoukVqDCo3gTQyiQ9fyoKK7hm/vHWIxG2HDzmNv7V0 JQ+g== X-Gm-Message-State: AOAM531XtjkXsiTi8LRVOhpsB8JUqh07nqKLUwS6rzf9SQFl7R7zG+d/ DWfOt2BtxtOPAq0tHrCIs198/L8D9fWQ7if/w6hmyw== X-Google-Smtp-Source: ABdhPJxJ6wnamohB2dBwxbIP6tQQaQyWD038Gx0AMF71yPx9BJ3T2gX/JTmuPhp10wrySm8J0xsqo/1mcDGQS8Ujk/I= X-Received: by 2002:a2e:3e15:: with SMTP id l21mr844680lja.250.1589926552449; Tue, 19 May 2020 15:15:52 -0700 (PDT) MIME-Version: 1.0 References: <20200519171938.3569605-1-kuba@kernel.org> <20200519171938.3569605-4-kuba@kernel.org> In-Reply-To: <20200519171938.3569605-4-kuba@kernel.org> From: Shakeel Butt Date: Tue, 19 May 2020 15:15:41 -0700 Message-ID: Subject: Re: [PATCH mm v4 3/4] mm: move cgroup high memory limit setting into struct page_counter To: Jakub Kicinski Cc: Andrew Morton , Linux MM , Kernel Team , Tejun Heo , Johannes Weiner , Chris Down , Cgroups , Michal Hocko Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 19, 2020 at 10:19 AM Jakub Kicinski wrote: > > High memory limit is currently recorded directly in > struct mem_cgroup. We are about to add a high limit > for swap, move the field to struct page_counter and > add some helpers. > > Signed-off-by: Jakub Kicinski Reviewed-by: Shakeel Butt > --- a/include/linux/page_counter.h > +++ b/include/linux/page_counter.h ... [snip] ... > > +static inline bool page_counter_is_above_high(struct page_counter *counter) > +{ > + return page_counter_read(counter) > READ_ONCE(counter->high); > +} > + ... [snip] ... > --- a/mm/page_counter.c > +++ b/mm/page_counter.c > @@ -198,6 +198,11 @@ int page_counter_set_max(struct page_counter *counter, unsigned long nr_pages) > } > } > > +void page_counter_set_high(struct page_counter *counter, unsigned long nr_pages) > +{ > + WRITE_ONCE(counter->high, nr_pages); > +} > + Any reason not to make this static inline like page_counter_is_above_high() and in page_counter.h?