From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88314C433DF for ; Wed, 20 May 2020 00:22:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 19007206D4 for ; Wed, 20 May 2020 00:22:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NiUCaCoh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19007206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7917C80035; Tue, 19 May 2020 20:22:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71B068002C; Tue, 19 May 2020 20:22:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E1EB80035; Tue, 19 May 2020 20:22:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id 43D218002C for ; Tue, 19 May 2020 20:22:06 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0C3E4180AD815 for ; Wed, 20 May 2020 00:22:06 +0000 (UTC) X-FDA: 76835195052.03.color52_124bc136e7f0c X-HE-Tag: color52_124bc136e7f0c X-Filterd-Recvd-Size: 3808 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Wed, 20 May 2020 00:22:05 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id x22so1067705lfd.4 for ; Tue, 19 May 2020 17:22:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yTql++3gFASshPrg+T0nmbJwBgbfv14jSHy1pTffRhU=; b=NiUCaCohQuLliM+U2l50qqLl57m8zQFJsQk3xhIisLLSkrO4qnnyY4emxRxJ5aAruF PjefQUYiKxx5vRTksxhTvVAiq5LGu6NPL/tKYyIAzl1NQj+qX2YWvoWRbQ3XtE66OCMs dnJqRiiOUfnMr7z+qZXG3oJ2wGUgaki2nxodtQIEGJMybq8cxprMZ4brtnXlhmtqh/kQ TS682Hpjz6G/JybgJ3AhDnMwqldcFpPE1CAzWXuY1tz4QyxI6pn4i6MZE976sZ9W0wFa 3kGFcrvISClJst13OMTGf4Qj9hfJhMx4G1Y/XGxZcGxQw1Fj6N3BJJXOtO4sMqM6MHJX xw1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yTql++3gFASshPrg+T0nmbJwBgbfv14jSHy1pTffRhU=; b=aqG3ADxqh4TtEmgu2dzUufJkSaZd0gkbGmFl6hS7dfiA42YyQZhfKk4UEgeinEsXW1 mSVWVCTQoC1SwcnNt0IgkmqP1To22u0n9XTFmgvveysu03QSQSiM/GU8GANK7Y2oX/S0 4gkX9gNu694ecFSvDxiaxSqVacsaZya/vrrv49UuwlUQqm/hRi1BhIYEwALbANfcRfPE Z52cAka13u2BwpaJNkRCNKIsLQZg/oJwgm6CTR4nfcUZVwjvJjTQe7d+fkPpTUav4+y0 h89Nk+B6/9IZMqS2oLPbttzyhddcLWLfDItTLoseWkps9QZfqtUqA81c0HOSlWm4lxww tMaA== X-Gm-Message-State: AOAM532qluM9z0ID38OHK0Ml1N/IsAPOpsHJ+BVTZ7IKsHmC4XIQuu4H IntXjG4frY+tNvJZaIFXaJbMuuAjaPNZk07D6ZYuyA== X-Google-Smtp-Source: ABdhPJy9ROJxomItmrADQjVlnzCuJBnkg4tO6Kxdpsc6GXhgYC4Viz6PRyUGb0WclS0G5ZKq+fkXbxoW3J1j7BkB81U= X-Received: by 2002:ac2:5ccf:: with SMTP id f15mr884299lfq.216.1589934123686; Tue, 19 May 2020 17:22:03 -0700 (PDT) MIME-Version: 1.0 References: <20200519171938.3569605-1-kuba@kernel.org> <20200519171938.3569605-4-kuba@kernel.org> <20200519161438.4f11ddec@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200519161438.4f11ddec@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Shakeel Butt Date: Tue, 19 May 2020 17:21:52 -0700 Message-ID: Subject: Re: [PATCH mm v4 3/4] mm: move cgroup high memory limit setting into struct page_counter To: Jakub Kicinski Cc: Andrew Morton , Linux MM , Kernel Team , Tejun Heo , Johannes Weiner , Chris Down , Cgroups , Michal Hocko Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 19, 2020 at 4:14 PM Jakub Kicinski wrote: > > On Tue, 19 May 2020 15:15:41 -0700 Shakeel Butt wrote: > > > --- a/mm/page_counter.c > > > +++ b/mm/page_counter.c > > > @@ -198,6 +198,11 @@ int page_counter_set_max(struct page_counter *counter, unsigned long nr_pages) > > > } > > > } > > > > > > +void page_counter_set_high(struct page_counter *counter, unsigned long nr_pages) > > > +{ > > > + WRITE_ONCE(counter->high, nr_pages); > > > +} > > > + > > > > Any reason not to make this static inline like > > page_counter_is_above_high() and in page_counter.h? > > My reason was consistency with other page_counter_set_xyz() helpers, > but obviously happy to change if needed... I think it should be in the header and inlined.