From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BABCAC28D13 for ; Mon, 22 Aug 2022 15:17:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FD598D001A; Mon, 22 Aug 2022 11:17:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58FB08D0003; Mon, 22 Aug 2022 11:17:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 459798D001A; Mon, 22 Aug 2022 11:17:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 365E08D0003 for ; Mon, 22 Aug 2022 11:17:14 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 14A031C61A6 for ; Mon, 22 Aug 2022 15:17:14 +0000 (UTC) X-FDA: 79827581988.19.1B8D216 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf31.hostedemail.com (Postfix) with ESMTP id D6E532015D for ; Mon, 22 Aug 2022 15:09:13 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id o5-20020a17090a3d4500b001ef76490983so11592580pjf.2 for ; Mon, 22 Aug 2022 08:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=DL+gliCYJUBpfOq1j0gfe9XybjmiohhXfC5HxYReYKQ=; b=Wy9VrLR+iXIOs02vfJHYtL6p0NbydFm1yZdXSv/BbjuFOkMtSTPP5CovxJ8349YqKj G3MVhdA4OpFY8unEsaSt6zl96K01EATVtDmzrpuZf7ttwrRaJShdhZDkiI3ve+qZNaMO LaMlsEqTM0HnQfbQJ+Ybp1cnhMyLAgbc8INMpkq7KkujbvLbZ3V3a+NkCsxtQtac3dFk vdsSPaw69M8DRRGlUlj8oR/cctPuyyB4P3GQXi7AhcJrZf2VSCnqZnoHSJmlaPfCsIHj Joq2WkpjnyjHGnaNIuUdQt4Q0lg3lljWYfXsxd0kZCxPo/shZ5oEicOIck6uwGYGrqs4 U2ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=DL+gliCYJUBpfOq1j0gfe9XybjmiohhXfC5HxYReYKQ=; b=PAeHAyJd8GlclZELnSVPi2/oNm18EZHN2okIG+53PvX5BG9bWSmnPZ212YOx+wvgCY HVIFC0pKVAu8wsdbluTX9i+Px68U1ac+Qu/2vayKUIsIMxaHvhRkpDJLMx2ihduyxhtn NkcgcEZEMDeXBSOakBfDd9Z9H2LDo+cw3kWq4Y1uSXD9QiB0nP7rD07Qg2K4BHmK+zsr AgPVCDLFPDCN4C+uHS2TGyXKCgrI6szYNRilzudtSdtKm9naz4KaPFq52oVqDHraveSm vcZesOsmT6PKeHSIlU8NJdCYFTzMAnmeWi2Ybb+DJiTmxRDu2oBPOgV5Lkjdqw4E9OO3 MRvA== X-Gm-Message-State: ACgBeo3M96UtoRRTPgR0CkZ0pNbdjIULAo4sv+5IhbbaJsfJ5Bag+TUE ZgukspEiFGgh2XBcIGm8HW5oDf5ocrDomoNdAYMtqw== X-Google-Smtp-Source: AA6agR7w4i5ZWIz9KjwU7gDt0d0aOILixwzjhdCoo+s9f8xFDqJTQ54c28l9lpA7rWoP1mDiZfxWuiTVUH8q+viQk0c= X-Received: by 2002:a17:90b:3881:b0:1f5:81e:8ceb with SMTP id mu1-20020a17090b388100b001f5081e8cebmr28140119pjb.207.1661180952809; Mon, 22 Aug 2022 08:09:12 -0700 (PDT) MIME-Version: 1.0 References: <20220822001737.4120417-1-shakeelb@google.com> <20220822001737.4120417-4-shakeelb@google.com> In-Reply-To: From: Shakeel Butt Date: Mon, 22 Aug 2022 08:09:01 -0700 Message-ID: Subject: Re: [PATCH 3/3] memcg: increase MEMCG_CHARGE_BATCH to 64 To: Michal Hocko Cc: Johannes Weiner , Roman Gushchin , Muchun Song , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Eric Dumazet , Soheil Hassas Yeganeh , Feng Tang , Oliver Sang , Andrew Morton , lkp@lists.01.org, Cgroups , Linux MM , netdev , LKML Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661180953; a=rsa-sha256; cv=none; b=wnMsZZ3nswYiIik93vY0VjiYAKboOjvaGSgWh3eCWKq/ZVAF7pkVty/2+d0zzcKN5385Nf 4536x/h9MxC3AWdK3viyuGTfxdeMWbuoRVvCUPB6FIS0uMDrKLKQ3iucCjPvnth72uci6h FRuXN5El7zOW1QZJD8TkX2VKf1e6Uzw= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Wy9VrLR+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf31.hostedemail.com: domain of shakeelb@google.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661180953; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DL+gliCYJUBpfOq1j0gfe9XybjmiohhXfC5HxYReYKQ=; b=RtKpPjaBhgyib2XDoNUPrTY5UtLAYeA6yjLIAA4zEQFRMrnDgbSecn4WBA4f1gT2/SKuh9 2C0mVkti1aB9pVrK7qFynciTJ6jdnph0Ywr6pd5LsIrqJ6zrQ0d8S1V3A5bq8RX3W6jRST QG4L3+pUY+FYuhN3ZGUd8dpfrVdbhns= X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Wy9VrLR+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf31.hostedemail.com: domain of shakeelb@google.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D6E532015D X-Stat-Signature: jm91hxy7i4crx8oq6wh1hyozshes7pbh X-HE-Tag: 1661180953-26689 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 22, 2022 at 3:47 AM Michal Hocko wrote: > [...] > > > To evaluate the impact of this optimization, on a 72 CPUs machine, we > > ran the following workload in a three level of cgroup hierarchy with top > > level having min and low setup appropriately. More specifically > > memory.min equal to size of netperf binary and memory.low double of > > that. > > a similar feedback to the test case description as with other patches. What more info should I add to the description? Why did I set up min and low or something else? > > > > $ netserver -6 > > # 36 instances of netperf with following params > > $ netperf -6 -H ::1 -l 60 -t TCP_SENDFILE -- -m 10K > > > > Results (average throughput of netperf): > > Without (6.0-rc1) 10482.7 Mbps > > With patch 17064.7 Mbps (62.7% improvement) > > > > With the patch, the throughput improved by 62.7%. > > > > Signed-off-by: Shakeel Butt > > Reported-by: kernel test robot > > Anyway > Acked-by: Michal Hocko Thanks