From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18EFAC433EF for ; Sat, 5 Feb 2022 06:33:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A6826B0074; Sat, 5 Feb 2022 01:33:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 12FAD6B0075; Sat, 5 Feb 2022 01:33:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F12466B0078; Sat, 5 Feb 2022 01:33:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id DC2796B0074 for ; Sat, 5 Feb 2022 01:33:01 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 941AF9A7EF for ; Sat, 5 Feb 2022 06:33:01 +0000 (UTC) X-FDA: 79107758562.08.B6F73EA Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf03.hostedemail.com (Postfix) with ESMTP id 3532A20004 for ; Sat, 5 Feb 2022 06:33:01 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id z4so16745583lft.3 for ; Fri, 04 Feb 2022 22:33:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/I4uenCSy6lKFDX+vozXBZPrlb1lnpOy6352DMFUA8c=; b=rq24Q2AFZ5EoKbcKKkftdHvOqnaftuHw87PzEuO4Mjmi1KqZOJK69ovDu1K371qjBa DDXJPDZ5iX4ThIye9JZjA2NYYesaKh5lmhtCUGiaiPvTBSGYOHsfEDC7tWjBLd5UMeH6 aXnz2Zsy56u1y56TWSMCmsF7fdOuvjRD7VnTOQ/3O7r9FkAo/Wgn2dO/rw7JyRF+qMVi Y16QISg8FsYxTHzUdTSgWMBIIeCFS1VUMWekJa2tm+xEjI2i5VVGl1QFlgpqm/WWipFc dXw/5OF4N74vt8K7liy4FV/Ft+nh9VV0VjvUzwmEIkzWBGVdm/CYbNPjpL9xlOI8KcgU 4e8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/I4uenCSy6lKFDX+vozXBZPrlb1lnpOy6352DMFUA8c=; b=gkbwwl/TZhKEyaFFXRw8uI5O0JNPRdpYAr+tcok8G5wzYKAAJ3HQSJ51TaTkMMhLT9 5zjd+Wn7Whc4S/xcOlVIuXqNc5J7lsdZkteWpDwUl/rhvbWb042dVGaxfkfquU8LRR9G soDBKUb4u6FAaM2ZMqFrnKrnt7wjLGWYk4Aln1qnZHNIzK37bapU9U6l4O0iNXRH6TPV P1LVLqIORzyqaAuC9pvYYUNGr6I72zGEQLhczsfk/R/GrxWlguaVZ5xQmfV9jZ0KguY+ nPsXRKi5KhEJUzTWIvyNKJntkPU6thjcxAUxc3VVdzXLMA50r4bVvZcewWQFgyqrudsU E9HQ== X-Gm-Message-State: AOAM530vhNy4h/zV/SBUeKWT8dwBoo1UHdmEfehAS93LwJz7/hbllqRF Luav7Tbo7cHi2O8Idx+5kkik67YboxPTLRUFghBz9g== X-Google-Smtp-Source: ABdhPJzBS0ATlNIJS0wbnbUmcCt1uFbSET2zzNCr5rG+3DvrfqXNdkPOzH/OnKXNo0LNwTjK2rMAXmYqafs8B4rB57A= X-Received: by 2002:a05:6512:10ce:: with SMTP id k14mr1651918lfg.210.1644042778863; Fri, 04 Feb 2022 22:32:58 -0800 (PST) MIME-Version: 1.0 References: <20220125051736.2981459-1-shakeelb@google.com> In-Reply-To: <20220125051736.2981459-1-shakeelb@google.com> From: Shakeel Butt Date: Fri, 4 Feb 2022 22:32:47 -0800 Message-ID: Subject: Re: [PATCH] mm: io_uring: allow oom-killer from io_uring_setup To: Jens Axboe , Pavel Begunkov Cc: Andrew Morton , Linux MM , LKML , io-uring@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3532A20004 X-Stat-Signature: rhgxxewyiwyrpywpxd4333y91ato5d3o X-Rspam-User: nil Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=rq24Q2AF; spf=pass (imf03.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1644042781-962627 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 24, 2022 at 9:17 PM Shakeel Butt wrote: > > On an overcommitted system which is running multiple workloads of > varying priorities, it is preferred to trigger an oom-killer to kill a > low priority workload than to let the high priority workload receiving > ENOMEMs. On our memory overcommitted systems, we are seeing a lot of > ENOMEMs instead of oom-kills because io_uring_setup callchain is using > __GFP_NORETRY gfp flag which avoids the oom-killer. Let's remove it and > allow the oom-killer to kill a lower priority job. > > Signed-off-by: Shakeel Butt Jens, any comments or concerns on this patch? > --- > fs/io_uring.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/fs/io_uring.c b/fs/io_uring.c > index e54c4127422e..d9eeb202363c 100644 > --- a/fs/io_uring.c > +++ b/fs/io_uring.c > @@ -8928,10 +8928,9 @@ static void io_mem_free(void *ptr) > > static void *io_mem_alloc(size_t size) > { > - gfp_t gfp_flags = GFP_KERNEL | __GFP_ZERO | __GFP_NOWARN | __GFP_COMP | > - __GFP_NORETRY | __GFP_ACCOUNT; > + gfp_t gfp = GFP_KERNEL_ACCOUNT | __GFP_ZERO | __GFP_NOWARN | __GFP_COMP; > > - return (void *) __get_free_pages(gfp_flags, get_order(size)); > + return (void *) __get_free_pages(gfp, get_order(size)); > } > > static unsigned long rings_size(unsigned sq_entries, unsigned cq_entries, > -- > 2.35.0.rc0.227.g00780c9af4-goog >