From: Shakeel Butt <shakeelb@google.com>
To: Huilong Deng <denghuilong@cdjrlc.com>,
Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, Roman Gushchin <guro@fb.com>
Subject: Re: [PATCH] mm: memcontrol: Remove trailing semicolon in macros
Date: Mon, 14 Jun 2021 17:15:36 -0700 [thread overview]
Message-ID: <CALvZod76wUmZ=EyaCeWKKAOaynpdWNMbcT_uz13LJJ4AunOV2Q@mail.gmail.com> (raw)
In-Reply-To: <20210614091530.22117-1-denghuilong@cdjrlc.com>
+lkml and linux-mm
On Mon, Jun 14, 2021 at 2:15 AM Huilong Deng <denghuilong@cdjrlc.com> wrote:
>
> Macros should not use a trailing semicolon.
>
> Signed-off-by: Huilong Deng <denghuilong@cdjrlc.com>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
> ---
> include/linux/memcontrol.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index 3cc18c2176e7..1c1b11530ab6 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -192,7 +192,7 @@ enum memcg_kmem_state {
> struct memcg_padding {
> char x[0];
> } ____cacheline_internodealigned_in_smp;
> -#define MEMCG_PADDING(name) struct memcg_padding name;
> +#define MEMCG_PADDING(name) struct memcg_padding name
> #else
> #define MEMCG_PADDING(name)
> #endif
> --
> 2.31.1
>
>
>
parent reply other threads:[~2021-06-15 0:15 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210614091530.22117-1-denghuilong@cdjrlc.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALvZod76wUmZ=EyaCeWKKAOaynpdWNMbcT_uz13LJJ4AunOV2Q@mail.gmail.com' \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=denghuilong@cdjrlc.com \
--cc=guro@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).