From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7872DC433DB for ; Fri, 19 Mar 2021 16:20:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0D80B6194A for ; Fri, 19 Mar 2021 16:20:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D80B6194A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 707C96B0083; Fri, 19 Mar 2021 12:20:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DCBC6B0085; Fri, 19 Mar 2021 12:20:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5570F8D0001; Fri, 19 Mar 2021 12:20:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0018.hostedemail.com [216.40.44.18]) by kanga.kvack.org (Postfix) with ESMTP id 3958A6B0083 for ; Fri, 19 Mar 2021 12:20:37 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0026118074C55 for ; Fri, 19 Mar 2021 16:20:36 +0000 (UTC) X-FDA: 77937136914.19.46D8D27 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf16.hostedemail.com (Postfix) with ESMTP id A272980192FE for ; Fri, 19 Mar 2021 16:20:30 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id f3so2519542lfu.5 for ; Fri, 19 Mar 2021 09:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ABhrPzAtdhWSaCHAY3A5zu5xcg0uIN31nsx8czLOuLA=; b=nZc8gOjoMUSSwfSmGreBrhMExobRUEiMyrB+ufxf6snC18UHUFIZvEG3vZvpJL45Ee yDEC5aagO1+xQ9Vrb39wZwxtpTAy3P6N1sXos3/Q8j7YqkLCHBRd9VlCIxUoAGtTJldM cnHthANh/a/pPnmzkAjYYElBk6+bTmLG3wAxiJZTy2SyYeW8eKOgfRTX8T5liDKNkO7M 9t/GEE5Eb6kcO70YmYHhS91PnvKTVyfB5vOVgv/Qw5DjJiR/9TS1cBgQXtwp3gU9HAld DC2gXySVATLhIF+L0dtZAKGQ6P9hM3qkjRSDwl52Zbze20y3u3f3ki8R/6CYQED9rX/d bamA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ABhrPzAtdhWSaCHAY3A5zu5xcg0uIN31nsx8czLOuLA=; b=F/1+EbGncnsZQzGr5fcT+w57E8h3gaUb8K6ztk5Udli2RbdDH5QZh/DC5e9kSW5Tm6 TmEDFiRS5QCRizNjLVEIEqXOC1VpuJMt3zwzz6gBO/VA7ptsjwAl5bJQWskIRAYZiL5Z fLflJoT9E2i+UThJsr3IeO2V81duK+fhOFUsO0hxRcbZ6BKfKryCIZOKm02sqaOsiLw2 77QT2zSeeVyXS5F2FlXduIKJahZS8z0GIvds37x4ZPAP67HGLeaN0K/MG3t7n0M+KCLD YnnDahSr1r4higw9oxhOTJuZuvRZGkkn+3Z91g8iCLQLp3mHli3C2O3Dae5YzUBEvVJp sx/g== X-Gm-Message-State: AOAM533vwiSK1D4/lNTpRX7cO0vvzDby77qMgpZz0PgSQf6PyykOP0Xp vmS03KFEM0vu4VkU3+uDEsAS/mCH7mHCojMibJoowA== X-Google-Smtp-Source: ABdhPJxXpE+vp95qCI4rudYe5Bb8jNBHnrf2SQ1HmBFBpzNwDuFrFqe5vWyJN8iSECKBxa1EHhXynFCcniLz74oF9L4= X-Received: by 2002:a19:f50e:: with SMTP id j14mr1266068lfb.299.1616170828550; Fri, 19 Mar 2021 09:20:28 -0700 (PDT) MIME-Version: 1.0 References: <20210316153655.500806-1-schatzberg.dan@gmail.com> <7ca79335-026f-2511-2b58-0e9f32caa063@kernel.dk> <8c32421c-4bd8-ec46-f1d0-25996956f4da@kernel.dk> <20210318164625.1018062b042e540bd83bb08e@linux-foundation.org> In-Reply-To: From: Shakeel Butt Date: Fri, 19 Mar 2021 09:20:16 -0700 Message-ID: Subject: Re: [PATCH v10 0/3] Charge loop device i/o to issuing cgroup To: Dan Schatzberg Cc: Andrew Morton , Jens Axboe , Tejun Heo , Zefan Li , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Roman Gushchin , Muchun Song , Alex Shi , Alexander Duyck , Chris Down , Yafang Shao , Wei Yang , "open list:BLOCK LAYER" , open list , "open list:CONTROL GROUP (CGROUP)" , "open list:MEMORY MANAGEMENT" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A272980192FE X-Stat-Signature: ep98xjo54x95k3uxoikiytdjtg4z3tbe Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=mail-lf1-f53.google.com; client-ip=209.85.167.53 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616170830-915873 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 19, 2021 at 8:51 AM Dan Schatzberg wrote: > > On Thu, Mar 18, 2021 at 05:56:28PM -0700, Shakeel Butt wrote: > > > > We need something similar for mem_cgroup_swapin_charge_page() as well. > > > > It is better to take this series in mm tree and Jens is ok with that [1]. > > > > [1] https://lore.kernel.org/linux-next/4fea89a5-0e18-0791-18a8-4c5907b0d2c4@kernel.dk/ > > It sounds like there are no concerns about the loop-related work in > the patch series. I'll rebase on the mm tree and resubmit. One suggestion would be to make get_mem_cgroup_from_mm() more generic (i.e. handle !mm && active_memcg() case) and avoid get_mem_cgroup_from_current() as it might go away.