From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D463C4332F for ; Mon, 5 Dec 2022 16:32:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 215B68E0002; Mon, 5 Dec 2022 11:32:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C64D8E0001; Mon, 5 Dec 2022 11:32:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B5808E0002; Mon, 5 Dec 2022 11:32:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F2EF98E0001 for ; Mon, 5 Dec 2022 11:32:54 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BADBDC03BC for ; Mon, 5 Dec 2022 16:32:54 +0000 (UTC) X-FDA: 80208796668.27.9AC4A7F Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf13.hostedemail.com (Postfix) with ESMTP id 5CBD52000E for ; Mon, 5 Dec 2022 16:32:53 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hzi9C2Se; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670257973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0PmNCTsJvxvDZkgjesfJCZeYmU+d2L5HAvI1G9E1wU0=; b=Sv3Lt//rSDxzhh09esuUH9N8Ucp8WukavYocApeOe6DlzguJ36GqoMV+RB3be4uReZJyNT nc9qmor9t3yGNc489BDAy6ZTrJgeuQvTRRV1uNIQKzXNZQLjpz/48dgsOXoM+i4fGe7iZq 0MeFeoiYd9ty9ka4gt0xXsSB6WC+PME= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hzi9C2Se; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670257973; a=rsa-sha256; cv=none; b=pjkfYgl6fkBkj2zQ9TxZ045JX55NSlOnrCRKAWOK/HT9tYrwcTuzhP79EimyH8v3gb7VCy hHCn0MvZYMe5ap7aUBhvYiJ8O3EsgkxMdvGHA2viyREF43FGBgd7ptCHpyKeHVgJKrskrr FdTWWCiZkwNGqic3+Ri57Dzp0VdiVAM= Received: by mail-yb1-f175.google.com with SMTP id s11so625155ybe.2 for ; Mon, 05 Dec 2022 08:32:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0PmNCTsJvxvDZkgjesfJCZeYmU+d2L5HAvI1G9E1wU0=; b=hzi9C2SeIoAe+8utJLZkRl5OJn8tSGX5qRPD5dh4gB67VBShqwIDTtup25L/ShHWq4 qE99izmvwdghDESkJxAEZVDQqVAUXiGaOg+BVzXwAkOozxt05+d6ov0t8NR89LqGpHJs sT/jcL0n+bxPA6MtVxnvQqAmqaCYBGCRxm7RP9wQ2vRvrjVQw5bWZ2kfj9zp4ynkX0hF Z2rwttKysXQ9yS6wDqKBrbxtBtNhQQnKRpt9wCxXC46S8KCE0rTYBJ7+2tiadJK9I2lL wMkz3XnzixqIWhd+TYYxxy3EimRctwyVS5KqOwqMx7COrCbXii8SmsLtiTdmAtSebfDH uZDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0PmNCTsJvxvDZkgjesfJCZeYmU+d2L5HAvI1G9E1wU0=; b=hkqMCS9XMlEYcQ+lZ27QujnOb8UTgzLksWAIGOhP8hjJEtdqnuNkTCtfShN74MJ387 bO6wpg/OkAZZoY2Xtz0Y8F3tOu1K2KuL0zwuSVpu2bOtaQnkOLyMtlA/2ZZvnJX9ItFp I71yc3K7SSbvUoSwXIUGP+ACrsLaH/YiXuwVjfzdBz9doIEleQdAUvIZ1I2p37YLoQo5 r9iYK/ALbckyJYXJsW3WPBw2jvBe+rOK9Snnmqjjs87UBLHYH7euuHqJWZ9TxVX9RN3g g2d/lJlLAmK5Ppghcwgtn33Ln/u3t3gd5BaekVh/dN+32r/kgsMlqX0S0asnyZFKkhnD zRQQ== X-Gm-Message-State: ANoB5pkmDYK8u4pRs2YZJjXkKzkDfxrKk9DUze/+9zql+0T2DUyeRDd9 kPKVCnWbAP/DjanrK7fM7L9b70tSCJFxD6wOlJjxgJM/hjTeN67c X-Google-Smtp-Source: AA0mqf5QrOt5v9YAkGO2WKSJbivWEkXF2C2N7cBf4Sgn8LSjlWrETqQGJ4eC1TtopP/0rIqAvDxH+tVCYmRtCJgdNfM= X-Received: by 2002:a25:ae92:0:b0:6f9:d605:9f6a with SMTP id b18-20020a25ae92000000b006f9d6059f6amr27394119ybj.294.1670257972458; Mon, 05 Dec 2022 08:32:52 -0800 (PST) MIME-Version: 1.0 References: <1670240992-28563-1-git-send-email-lirongqing@baidu.com> In-Reply-To: <1670240992-28563-1-git-send-email-lirongqing@baidu.com> From: Shakeel Butt Date: Mon, 5 Dec 2022 08:32:41 -0800 Message-ID: Subject: Re: [PATCH] mm: memcontrol: speedup memory cgroup resize To: lirongqing@baidu.com Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, songmuchun@bytedance.com, akpm@linux-foundation.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5CBD52000E X-Stat-Signature: xwrgq9unoaautpxkkc795moyab9ay1fg X-Spamd-Result: default: False [2.73 / 9.00]; SORBS_IRL_BL(3.00)[209.85.219.175:from]; BAYES_HAM(-0.37)[70.48%]; BAD_REP_POLICIES(0.10)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DMARC_POLICY_ALLOW(0.00)[google.com,reject]; RCPT_COUNT_SEVEN(0.00)[8]; DKIM_TRACE(0.00)[google.com:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_NONE(0.00)[]; R_DKIM_ALLOW(0.00)[google.com:s=20210112]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; ARC_NA(0.00)[] X-HE-Tag: 1670257973-919957 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000047, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 5, 2022 at 3:49 AM wrote: > > From: Li RongQing > > when resize memory cgroup, avoid to free memory cgroup page > one by one, and try to free needed number pages once > It's not really one by one but SWAP_CLUSTER_MAX. Also can you share some experiment results on how much this patch is improving setting limits?