From: Shakeel Butt <shakeelb@google.com>
To: SeongJae Park <sj38.park@gmail.com>
Cc: SeongJae Park <sjpark@amazon.de>,
Jonathan.Cameron@huawei.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, amit@kernel.org,
benh@kernel.crashing.org,
Brendan Higgins <brendanhiggins@google.com>,
Jonathan Corbet <corbet@lwn.net>,
David Hildenbrand <david@redhat.com>,
dwmw@amazon.com, Marco Elver <elver@google.com>,
"Du, Fan" <fan.du@intel.com>,
foersleo@amazon.de, greg@kroah.com,
Greg Thelen <gthelen@google.com>,
guoju.fgj@alibaba-inc.com, jgowans@amazon.com,
Mel Gorman <mgorman@suse.de>,
mheyne@amazon.de, Minchan Kim <minchan@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
namhyung@kernel.org,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Rik van Riel <riel@surriel.com>,
David Rientjes <rientjes@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mike Rapoport <rppt@kernel.org>, Shuah Khan <shuah@kernel.org>,
sieberf@amazon.com, snu@zelle79.org,
Vlastimil Babka <vbabka@suse.cz>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
zgf574564920@gmail.com, linux-damon@amazon.com,
Linux MM <linux-mm@kvack.org>,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v31 07/13] mm/damon: Implement a debugfs-based user space interface
Date: Thu, 24 Jun 2021 07:52:59 -0700 [thread overview]
Message-ID: <CALvZod7gLSCqqYVR50F9-8DxG=gRL4seiHAqvSsr3A6U6cvjig@mail.gmail.com> (raw)
In-Reply-To: <20210624102623.24563-4-sjpark@amazon.de>
On Thu, Jun 24, 2021 at 3:26 AM SeongJae Park <sj38.park@gmail.com> wrote:
>
[...]
> >
> > The high level comment I have for this patch is the layering of pid
> > reference counting. The dbgfs should treat the targets as abstract
> > objects and vaddr should handle the reference counting of pids. More
> > specifically move find_get_pid from dbgfs to vaddr and to add an
> > interface to the primitive for set_targets.
> >
> > At the moment, the pid reference is taken in dbgfs and put in vaddr.
> > This will be the source of bugs in future.
>
> Good point, and agreed on the problem. But, I'd like to move 'put_pid()' to
> dbgfs, because I think that would let extending the dbgfs user interface to
> pidfd a little bit simpler. Also, I think that would be easier to use for
> in-kernel programming interface usages. If you disagree, please feel free to
> let me know.
>
I was thinking of removing targetid_is_pid() checks. Anyways this is
not something we can not change later, so I will let you decide which
direction you want to take.
next prev parent reply other threads:[~2021-06-24 14:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 8:30 [PATCH v31 00/13] Introduce Data Access MONitor (DAMON) SeongJae Park
2021-06-21 8:30 ` [PATCH v31 01/13] mm: " SeongJae Park
2021-06-22 14:59 ` Shakeel Butt
2021-06-24 10:26 ` SeongJae Park
2021-06-24 14:34 ` Shakeel Butt
2021-06-21 8:30 ` [PATCH v31 02/13] mm/damon/core: Implement region-based sampling SeongJae Park
2021-06-22 14:59 ` Shakeel Butt
2021-06-21 8:30 ` [PATCH v31 03/13] mm/damon: Adaptively adjust regions SeongJae Park
2021-06-22 14:59 ` Shakeel Butt
2021-06-24 10:26 ` SeongJae Park
2021-06-21 8:30 ` [PATCH v31 04/13] mm/idle_page_tracking: Make PG_idle reusable SeongJae Park
2021-06-21 8:31 ` [PATCH v31 05/13] mm/damon: Implement primitives for the virtual memory address spaces SeongJae Park
2021-06-22 15:00 ` Shakeel Butt
2021-06-24 10:26 ` SeongJae Park
2021-06-24 14:42 ` Shakeel Butt
2021-06-24 15:21 ` SeongJae Park
2021-06-24 16:33 ` Shakeel Butt
2021-06-24 17:38 ` SeongJae Park
2021-07-01 0:18 ` Shakeel Butt
2021-07-01 0:19 ` Shakeel Butt
2021-06-21 8:31 ` [PATCH v31 06/13] mm/damon: Add a tracepoint SeongJae Park
2021-06-22 15:01 ` Shakeel Butt
2021-06-21 8:31 ` [PATCH v31 07/13] mm/damon: Implement a debugfs-based user space interface SeongJae Park
2021-06-22 18:12 ` Shakeel Butt
2021-06-24 10:26 ` SeongJae Park
2021-06-24 14:52 ` Shakeel Butt [this message]
2021-06-21 8:31 ` [PATCH v31 08/13] mm/damon/dbgfs: Export kdamond pid to the user space SeongJae Park
2021-06-22 18:23 ` Shakeel Butt
2021-06-24 10:26 ` SeongJae Park
2021-06-21 8:31 ` [PATCH v31 09/13] mm/damon/dbgfs: Support multiple contexts SeongJae Park
2021-06-21 8:31 ` [PATCH v31 10/13] Documentation: Add documents for DAMON SeongJae Park
2021-06-21 8:31 ` [PATCH v31 11/13] mm/damon: Add kunit tests SeongJae Park
2021-06-21 8:31 ` [PATCH v31 12/13] mm/damon: Add user space selftests SeongJae Park
2021-06-21 8:31 ` [PATCH v31 13/13] MAINTAINERS: Update for DAMON SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALvZod7gLSCqqYVR50F9-8DxG=gRL4seiHAqvSsr3A6U6cvjig@mail.gmail.com' \
--to=shakeelb@google.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=amit@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=dwmw@amazon.com \
--cc=elver@google.com \
--cc=fan.du@intel.com \
--cc=foersleo@amazon.de \
--cc=greg@kroah.com \
--cc=gthelen@google.com \
--cc=guoju.fgj@alibaba-inc.com \
--cc=jgowans@amazon.com \
--cc=linux-damon@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mheyne@amazon.de \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=sieberf@amazon.com \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
--cc=snu@zelle79.org \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=zgf574564920@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).