From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1422C3815B for ; Mon, 20 Apr 2020 16:41:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A1AAD20857 for ; Mon, 20 Apr 2020 16:41:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rnfUu4qQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1AAD20857 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 415DF8E0005; Mon, 20 Apr 2020 12:41:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3ED778E0003; Mon, 20 Apr 2020 12:41:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 303B98E0005; Mon, 20 Apr 2020 12:41:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id 1580C8E0003 for ; Mon, 20 Apr 2020 12:41:47 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C6B36485F for ; Mon, 20 Apr 2020 16:41:46 +0000 (UTC) X-FDA: 76728799812.13.wound81_83e8a38e44c11 X-HE-Tag: wound81_83e8a38e44c11 X-Filterd-Recvd-Size: 5060 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Apr 2020 16:41:46 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id j14so8523397lfg.9 for ; Mon, 20 Apr 2020 09:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O2dJT1myWg1ncHvlqyPJON6jpe6isaS6pkV1M9K7nWc=; b=rnfUu4qQJhOUMBHqmbxBSXsOcLT0KaNN8RmC5piOJNJsHiQrqDCvCupALvqpPPSn51 7oM0dhUNEahycH2GHBPHBOwywTpciNriMmGZXbPk1K46tjpQ9tRwfAB0a9QNnVks7HVs /CJU5rwuZ6i10hHICfkfb6Oa2MV2la7wJArsPU1BOz3Gq6ZmEoNoyr2iFded2n4Ikh2u ibL7uSF7pa9lIA7KlnvN9RgdpZy19EXQgIzne9/O/w9zurZMgQGXYC8m/MAvM/mscOjN WSVHTFo259SwvyGZbigyB5C4iVQ4SQv4Yo+s2u/vMyA/SnU3KevS3AK99KtxtU4W6mhG Haow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O2dJT1myWg1ncHvlqyPJON6jpe6isaS6pkV1M9K7nWc=; b=Uk7VSlu6NZ/sbL7Bnl6RhhKhZxHraaa98iDkyzOc5/4fVXbjGCbpo9ecr32xwz9C9x hYIrNFYF2Km78jMv1xpt+lYN8hp9dx5zS42u21YKPdWP9hZnVd7/rnCRLW84mhXxJ76V SwnavyWPTinSRURuILNYnjTPXIcb0dSOv3Y8rxbGL1gUTdmKq/zNOWv3tKGO9lyH5kWV Akdehye9q70t6VkEXy0oh2raA46r3+7XAevohWabspVOuac6ao1kng+wUxSUi82gGeB8 nc/DNopuIwv5rRTVhaIBXJn+MBWuV9mXsqFX1omEZE6XaSJbyZcduNrx34QaQTVX730n h8+Q== X-Gm-Message-State: AGi0PuYK+FqAVBd4TOPOoEsO8C2Ojg3eC8MwmEb1twNsOO2tn2ZdCsis bjHD9/aqTMZ/KRhIxf0r4dZwxkamZoz+OAzPSrqfLQ== X-Google-Smtp-Source: APiQypLCwvg6KrzM1Il2KDlm/ltQoTlY2jMRkWCPaEj9PecuS7ggT5c58oNe9GbhQY790kZXh+ILY9/WW1JmGBaBCQE= X-Received: by 2002:ac2:5e65:: with SMTP id a5mr10977861lfr.189.1587400904630; Mon, 20 Apr 2020 09:41:44 -0700 (PDT) MIME-Version: 1.0 References: <0a37bb7d-18a7-c43c-52a5-f13a34decf69@i-love.sakura.ne.jp> <20200303202623.GA68565@cmpxchg.org> <20200303210632.GC68565@cmpxchg.org> <20200303162948.a383cb88c4a1b0bfd3817798@linux-foundation.org> In-Reply-To: <20200303162948.a383cb88c4a1b0bfd3817798@linux-foundation.org> From: Shakeel Butt Date: Mon, 20 Apr 2020 09:41:33 -0700 Message-ID: Subject: Re: fs/buffer.c: WARNING: alloc_page_buffers while mke2fs To: Andrew Morton Cc: Johannes Weiner , Yang Shi , Tetsuo Handa , Naresh Kamboju , linux-mm , Mel Gorman , Michal Hocko , Dan Schatzberg Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 3, 2020 at 4:29 PM Andrew Morton wrote: > > On Tue, 3 Mar 2020 15:22:00 -0800 Shakeel Butt wrote: > > > > doesn't corrupt its state. > > > > > > I.e. this is safe: > > > > > > process: interrupt: > > > old = current->active_memcg > > > old = current->active_memcg > > > current->active_memcg = new > > > allocate > > > current->active_memcg = old > > > current->active_memcg = new > > > return old > > > > > > This is safe as well: > > > > > > process: interrupt: > > > old = current->active_memcg > > > current->active_memcg = new > > > old = current->active_memcg > > > current->active_memcg = new > > > allocate > > > current->active_memcg = old > > > return old > > > > Yes, you are right. Thanks for the explanation. > > Thanks, all. > > Dan, I dropped the three-patch series > > loop-use-worker-per-cgroup-instead-of-kworker.patch > mm-charge-active-memcg-when-no-mm-is-set.patch > loop-charge-i-o-to-mem-and-blk-cg.patch > > When convenient, could you please prepend Johannes' patch to the > series, retest and resend? While doing so, please figure out why you > didn't also see this warning in your testing and make the appropriate > changes! > Hi Dan, did you get the chance to follow up on Andrew's request? Shakeel