From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECAB0C47254 for ; Fri, 1 May 2020 02:38:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B196F2071C for ; Fri, 1 May 2020 02:38:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IxIFXsjo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B196F2071C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 304E88E0005; Thu, 30 Apr 2020 22:38:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B49E8E0001; Thu, 30 Apr 2020 22:38:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A3D78E0005; Thu, 30 Apr 2020 22:38:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F3C058E0001 for ; Thu, 30 Apr 2020 22:38:26 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B1858181AEF00 for ; Fri, 1 May 2020 02:38:26 +0000 (UTC) X-FDA: 76766591412.19.army49_66c9ed6c83215 X-HE-Tag: army49_66c9ed6c83215 X-Filterd-Recvd-Size: 4839 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Fri, 1 May 2020 02:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588300705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P8k2aTeCbIA0Pe5nqRNlnguJBbZob6iEKj+wNv40n6s=; b=IxIFXsjohq7cKf2OG8hXZSe6CgFuo5tdJNLeMn1Wiu35PsL7Qtndts4hPXyC4giSpwT4VK lAwcNwEjmS7Io1EwNbLixqASaFiOpTIrR9l5stUOQOJGjMsg+FoQF1HHHdFpreCwBWJZSO IIcAxM3GRo7V2AGGyShIxz+BPD1D/4Q= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-364-NSikBMmtOCyACrC8LiH4sA-1; Thu, 30 Apr 2020 22:38:22 -0400 X-MC-Unique: NSikBMmtOCyACrC8LiH4sA-1 Received: by mail-ua1-f72.google.com with SMTP id m26so3684835uao.2 for ; Thu, 30 Apr 2020 19:38:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P8k2aTeCbIA0Pe5nqRNlnguJBbZob6iEKj+wNv40n6s=; b=M1UwkJQ3kjFNeGhZaiuXm71F5C/zdYRyDk1sEFWO67L9pO+Z76MeI55FCG8R5JV8cQ l75caoxUiAu82VtJmPMIMBHihwfr3oZxcVxMj7OgI6Q20chcWOVcuxXGuP2omoED2su0 ZctAwxsTVJTb8aj1Dre3XSxnFgIzYP2K9zgIlzOlIAn6CckU1lk304MOINCgA8Nh+RLu PxjKeXbpon3DX683btHIWPmCJIU/4SpokR3K/GclsaV2tlqXiSwtvJJwADKs5jV5ficT 5MD7w3DQRM0vr5vSgOdrJ1yzr4eyhL89hqqnjYgHc/4B8Jqsx2lk/OZK6Tv1Am4ORiwE 7muQ== X-Gm-Message-State: AGi0PuY2j6Lek9SjPTSuhecQh21zrah7K6whr8T4fh9ahOot+b9FjA66 tOs8oeS3ESuhADO9/hbUP5G/qegjHAP3A0IOazMgDKlphSqscX/hMUQzEF9lCuFd3ijf5fyOkE/ FSb7luQMTSp7Ki5gttfmhfp7X9yk= X-Received: by 2002:a05:6102:4d:: with SMTP id k13mr1848898vsp.198.1588300701714; Thu, 30 Apr 2020 19:38:21 -0700 (PDT) X-Google-Smtp-Source: APiQypKu6ClZ61atP80MD4lQJkn2FtP3gZkiC+YuTXU2rwKV21SshkG1nW93zQxISm3Y7jRVOl6JpuyIYF8Yu55j3FA= X-Received: by 2002:a05:6102:4d:: with SMTP id k13mr1848869vsp.198.1588300701546; Thu, 30 Apr 2020 19:38:21 -0700 (PDT) MIME-Version: 1.0 References: <20200414131348.444715-1-hch@lst.de> <20200414131348.444715-22-hch@lst.de> <20200414151344.zgt2pnq7cjq2bgv6@debian> In-Reply-To: From: John Dorminy Date: Thu, 30 Apr 2020 22:38:10 -0400 Message-ID: Subject: Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc To: Wei Liu Cc: Christoph Hellwig , Andrew Morton , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , x86@kernel.org, David Airlie , Daniel Vetter , Laura Abbott , Sumit Semwal , Sakari Ailus , Minchan Kim , Nitin Gupta , Robin Murphy , Christophe Leroy , Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, bpf@vger.kernel.org, Linux Kernel Mailing List , Michael Kelley , Gao Xiang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote: >> > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove >> > it. Greetings; I recently noticed this change via the linux-next tree. It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks some confusion briefly until we decided it was supposed to be PAGE_KERNEL; if it's not too late, editing the description to clarify so would be nice. Many thanks. John Dorminy