From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 397D1C2D0CD for ; Thu, 15 May 2025 09:40:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA8DE6B0085; Thu, 15 May 2025 05:40:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A577A6B00B9; Thu, 15 May 2025 05:40:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F8386B00BA; Thu, 15 May 2025 05:40:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7209A6B0085 for ; Thu, 15 May 2025 05:40:09 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3B3C71616C0 for ; Thu, 15 May 2025 09:40:10 +0000 (UTC) X-FDA: 83444646180.14.A726B12 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by imf11.hostedemail.com (Postfix) with ESMTP id 333934000B for ; Thu, 15 May 2025 09:40:07 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MErxatVc; spf=pass (imf11.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747302008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1CrClsb6m6KfVqR6MgsSYcZDNxWG+Jal4kU8wCuMksk=; b=KN6IAbizKyVZ5iY7mEC8riw0PvrQ1Gxg3aOnkzgWzjD58Ra/EzV40pytjW5+o4HR6xT4ox pYBBh/fV+v8O4gBQBmnrXBFQ0bTNjlHRNs2q/34XSrjFjFd+G7ooCwbmyztimF4Y+zjC9q C7uMvlSF2+sPZb6pYePjScMqqUSLXvE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MErxatVc; spf=pass (imf11.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=ryncsn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747302008; a=rsa-sha256; cv=none; b=g+L9C9XPVo0xMpiMWuDGneJk1TeTSRHC+Dusrd+c6j+fl8utL56UoU4nhlBzR80BGB2Ake oPnwVS7O7SGdMU7Fh0dd1UNy0McryOz2GbC/frn4g0n6OWeJ8zBkI4Gl47+2J4lgTy0tD8 GjHiSP63iV6gcp3g46lz9Bxi6pcmXDs= Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-327fa3ceccdso5638821fa.1 for ; Thu, 15 May 2025 02:40:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747302006; x=1747906806; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1CrClsb6m6KfVqR6MgsSYcZDNxWG+Jal4kU8wCuMksk=; b=MErxatVcf74GNwb/XCrKaokjfq+I++jzKz+1nZ/rZsT/Zw6FwjVvTObHhIEqI5XsF1 esiQL9ZWQpuwtlT/mBWXBV/L9oQz3VHiYoE7L3eH5DaZjUJ28xvncbRwyfx3luZ7lwaI +suJY3kbf0Q/AUbLZu65+y/xwWyig1RPnLjnhVJ8LCXWSWQxYTs0D+QO1IHid8qqqWOh 889lvJq/y8uxzAP/5OtIfgDXqpLmN/TJHaJUUzAZYozuBvGsVSz0cUNSBGefVeDv/uli gk9j/tMk7BSvAh1rDolPHRWQboUJLbrQ9Mbb1/uD+6U7PZ0a00Q3HT9DU5s1ZgDoJum/ wZFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747302006; x=1747906806; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1CrClsb6m6KfVqR6MgsSYcZDNxWG+Jal4kU8wCuMksk=; b=V56S0BIy1+mYkjd2QMAjrvzM/ef6cYljcaGP+mun7cg7H5VjadaQ3JeNlQ6iJXn7fq 5DhdUpZ5UXADG2Fqcrt1slYtbVnNKiYJscEbrNXnYckCYvrKS35nj2UMIqLic+g0OSTO 0ajwAY4C2QkcougrJOBqPAtPpv1RBXfTBA88k+hPT6CgAd8OpUfBYkNEQMkUzUvu5FMX xI/3bMiJbwaQ8Eq2xEpX1vDVsy+Kc75sFHpvbomNLQA7YzCYZciCAvUnjScATWJGBuE8 67p6ZA4N+hmuEXz0NokV9fkay71tZfqlOjYrECNfi5avs7eWyeoGmjZ4ge6I1TcvNAr6 ALbw== X-Gm-Message-State: AOJu0YxorVPteDm4/tZMvMNckJlCR18vE4hOR2z1HGQW/hbg+6NKk04c uZ18EE8EDddR1XItedDdSXtsfPKSGJVbwLcF3Z/QODH4SUb2rQ0T+cKjUw7B0my/ksZNnOWNiLm 5qQjDoHOHO/Smm8p4JiMhHvQmuS8= X-Gm-Gg: ASbGncvk7zLjL29SlsPkyVjzLYT6nIWJDHFIiXNdTkNobbd91wombsR1F7/ZEq6dN2l 2sacAervIVNZwU0RQMp9/m7136s59wKtrkK4UZWw0Jut7Nk2Vmte8PGKHWD0mM4iCrQcnSAm2JQ wSl6HO8lo3q4zpAYCwNZEyDMeFJ8JKCgxB X-Google-Smtp-Source: AGHT+IF+92TDlD1jx6r/Kz+tLgIx4K+eyBpvWWHyz2ybulLqnfTzi1ZhRuPADWJY3IipWXvGSjpHtEkPLlAL+Cr3RyA= X-Received: by 2002:a2e:8a8d:0:b0:328:19:f6d0 with SMTP id 38308e7fff4ca-3280019f977mr1951621fa.6.1747302006096; Thu, 15 May 2025 02:40:06 -0700 (PDT) MIME-Version: 1.0 References: <20250514201729.48420-1-ryncsn@gmail.com> <20250514201729.48420-12-ryncsn@gmail.com> In-Reply-To: From: Kairui Song Date: Thu, 15 May 2025 17:39:48 +0800 X-Gm-Features: AX0GCFubmipqPTGXVkf0OAolayEXRfOSmtVjA5Chsvxfnh3knv8D6XTQVwK4SpI Message-ID: Subject: Re: [PATCH 11/28] mm, swap: clean up and consolidate helper for mTHP swapin check To: Klara Modin Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Hugh Dickins , Chris Li , David Hildenbrand , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , Baolin Wang , Baoquan He , Barry Song , Kalesh Singh , Kemeng Shi , Tim Chen , Ryan Roberts , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 333934000B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: y33cky9zanxw5e4o9gcis8cktg5umrwh X-HE-Tag: 1747302007-142901 X-HE-Meta: U2FsdGVkX1+En79ydMcID5zVx8+zRxIOb9+d4tauGhdbfkUd/WvxdHDvtiUhugSN7jEUcBCDgq6an9kh0JqSqs2PZD9eiQkAp0lTsY7pF21H5OVi1FxHTI8lNAS6puwJboQZ77yT8m0zrtpyUPuakiq+rhJH3TKpPAZg/WE8OHKaGadO5PIKim1BuIOx+ePdcGUJpOr6fvzQpZFEWjQhayrkrQtNF2GTgE0SgFjQyy6eL4sE1O1P232/t83rqifMJ8Cjnkrv7tbo0Mphk4TIUS5vP23xla8VRxGrwH3aDLxn1Z+ZK4kF+JtMdF2UVsq/n8Kq6rAOI/m9OANmkXqE4Xjykt/aZ4jtBcaVWx6amBxsjpx8UX7ZOKegRN5ZRPJ+T2394dRvm+NWVpYLAyPDA/ao21WQYHCh9aDJgwZECJnCHg8do7p9FObwVu4Tb/rCnw8QNpxg4WQ+eM4X2UGGD7DESPnGksIzQOQzNaGeGut+CrQTx6jk52Ko3eB94vw/EYuc/1gE+FZ/b4UZHrxGlrhD5GgSmggCCEZ3konfANfMhPsP/neCi1AXpTdnd2zRU4B6qlyo0tfIiQqH/hiV5urFgXdaHLU7SGorTy4ZSdjzQkd9lE3Uwfwk2Ke8khT3X8HV+PQz/cA57qbR6Y3sv8nvonoii7lWO9MuCvO3p4gB3t7nbXXXzaebxIgFDMpshFwgKkcxjdPmE1ANJuLVf6qyfGCCYCoXkdHTHk82t/rYGSX+q/iRW6pWu+jOCVCDWpR2idTz/oHXtI16Sn/O4iHwARqzf1RUN3h/6qM4ksrOOLDi2LDMllY7IGZTUmrLfWorti7mhS2vbpkBxDS5m2jGAH7YBN1+CHKd46BS4pxko9xagc2vHZnOZgG4jE6SjgAm0w4p9kkuCjiQRbeQMNaxk5HfEhlQuMEcjIAFIkqK9TxqgmwejJMhlGq+Q3pUDsdmb+j9wJFqYriq66t sdQuGHNU yYRgks4fSprXvIjRO9OIUU1h1eV7IFdIgJqt/dwiv8rGbt3ZdB3B7N2PkaN3FKgChDMo6EZD+TaqqlJDGJsNuJKYD10mKzPAjUo6AagPGIV3eOr/8ksR3aPLZORe2rP9na6SgW+yZhqIPuPvh+7IPHQ7ty89EyP1N5U6fBDFC4pkBCG6BZpbFAz9BIIZXrLAF+VXKTn3TumgWnYarRyDjLx6HdydNB1E3LyVAJ8CFtne9zok3hARBywnuZERjRJgmbig7kydDzDNamCsNYFzpUdE4s0CNCBcFON8Ocl8itk0DpBzXs4axdxthpOCh3XeWvYzw7kk01aZL2JXM0P9bc0soMo/GKgWxCkltLaVwfLggf50fLxgYTZ1raA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 15, 2025 at 5:31=E2=80=AFPM Klara Modin = wrote: > > Hi, > > On 2025-05-15 04:17:11 +0800, Kairui Song wrote: > > From: Kairui Song > > > > Move all mTHP swapin check into can_swapin_thp and use it for both pre > > IO check and post IO check. This way the code is more consolidated and > > make later commit easier to maintain. > > From what I can see, can_swapin_thp is gated behind > CONFIG_TRANSPARENT_HUGEPAGE and this fails to build when it's not > enabled. Thanks for the review. Right, I might have to add an empty one for !CONFIG_TRANSPARENT_HUGEPAGE to pass the build.