From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F59C4345F for ; Wed, 24 Apr 2024 01:57:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 522D86B01A8; Tue, 23 Apr 2024 21:57:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D13B6B01A9; Tue, 23 Apr 2024 21:57:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BFE66B01AA; Tue, 23 Apr 2024 21:57:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1E4746B01A8 for ; Tue, 23 Apr 2024 21:57:38 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C93021C1012 for ; Wed, 24 Apr 2024 01:57:37 +0000 (UTC) X-FDA: 82042763754.09.1C94913 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf19.hostedemail.com (Postfix) with ESMTP id F0FBF1A000A for ; Wed, 24 Apr 2024 01:57:35 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Xpc+hvVa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713923856; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ozl4eR2gI7UeFBtqjfRipXEMqkSU7RXdrGoXvouiIDU=; b=SZ50PKtDSbYYW3fxy51ePPNm8peIhWvxlQCgE02XWK/oso1EGctxPDmfdA2Rx1pObrwQgr /Vd/OLS5LtQknMp4yqvaC1e3Nbw7rGrzXamY4qhzU40n1chCNfnAUmgR2dgopc9rwFPzh7 pj6M2LLE3XzwmWu8AfWIHZvWJvBoX0c= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Xpc+hvVa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713923856; a=rsa-sha256; cv=none; b=hlBQgnC3NbC+td+C3sH72YNp4jA3uX+3nLH8OrmSEF6rzFbOSKM0AovdJsQ5HAnXnUU9rl /Q7FE3Msix17+VWItl7Cod/3xv2Fv9fo1J51dHD6xe2Z+LpmB01XNxXiVcgosxjy5qidIs wBSkpVVyAyVXpn78gV0AhVUsoejg8dE= Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2ddc2ea2091so24408981fa.1 for ; Tue, 23 Apr 2024 18:57:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713923854; x=1714528654; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ozl4eR2gI7UeFBtqjfRipXEMqkSU7RXdrGoXvouiIDU=; b=Xpc+hvVaTIKIV61YyxzP/MfgnQPseXi9d91NT2qedWOsSCrcc7qMQ3vD5ADWFzklDL ga3sb14RAwrkakl9GGW+NL6eDE4eUbywbDEON1RU7Q2G8TLixJFr62z1CPU13volPnjj uwEglmtbQ3xJChLWc8qSytpoAjKz+HTNZnblQOC8yhfcPY63ntcOveC3vAjtdCwflKKQ 489U8f1ohSEb96+J/BR+HqxN7a2ToIDrziNC2NBmO/LGxxWsZSkiluuV7/io84kA9BMQ H6SoQCRJ3smLeheHUiDd9ik4R2yzZo+lIZ9BUTSQu8tRQtZa/UlIzR1A/FM1iHu6IK3Q RM1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713923854; x=1714528654; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ozl4eR2gI7UeFBtqjfRipXEMqkSU7RXdrGoXvouiIDU=; b=SXvfTfwOrJvv2Nm3Wvf2Q3YoVn56Bv1qE5ON63hMY+rRc6Edj+212ccBK5mEDNUX0o eA/OjoNr+B82EhkK9idQVcihlvGZSBUDWjJw7HJWZn4CYd8YpV/fk+kJBlrvg8QRrnp7 XIJir3UVgAEOsL1oifkjTJSlwGap3iuBkYEec3ddO82TXs7b9UCNObCeMKX0/1Anb6rv f04mX/uPgXy03Oi14fYSz3/D6e26APTeI4fflMKw6/eay3wY8r/aiCVLhf7jQn+dg6FW zOzVnIlgDRvXtLY1EpxMgRZBJRuLZIAcBhX0QhL5FVdbCtGsusLFjLZ5oFvZe2mLn9Dr /EOg== X-Forwarded-Encrypted: i=1; AJvYcCXuF5Rcp2BS8N/Xgwj7PBEybUgRIcKcFlpR+ZLzlTiiHim1MWV5DKHX5sr6LTb0v0AlzWJMc0l02V4aV75UthDOJ2o= X-Gm-Message-State: AOJu0Yy2EJ0JlD21AXYxXkiDHB5XwO6BC/ihAtL3UuySrMzl2oZwhlmw jLj0b+dtTRrZ/0lcJW8bTx/kYlrHeE7Q28BDamaKLE5YE1vkrYQljWnh6ZSoHpY0nagjZOl/ErT paRni09WxrPVODlXvyd73lYbNkdU= X-Google-Smtp-Source: AGHT+IE2q9I+k7WPfudS5N9N5JzKqwEH0Sq10D35ySO0S7T9E8Xrg9ZkxX5/n2tHqivH2mSvu0rJufvbTUgleCsPYEA= X-Received: by 2002:a2e:b018:0:b0:2dc:de74:dfd6 with SMTP id y24-20020a2eb018000000b002dcde74dfd6mr501225ljk.10.1713923853805; Tue, 23 Apr 2024 18:57:33 -0700 (PDT) MIME-Version: 1.0 References: <20240423170339.54131-1-ryncsn@gmail.com> <20240423170339.54131-3-ryncsn@gmail.com> In-Reply-To: From: Kairui Song Date: Wed, 24 Apr 2024 09:57:15 +0800 Message-ID: Subject: Re: [PATCH v2 2/8] nilfs2: drop usage of page_index To: Ryusuke Konishi Cc: Matthew Wilcox , linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nilfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: F0FBF1A000A X-Stat-Signature: ysxn37b8fmewq56uoo7rhmqh78yjzbix X-HE-Tag: 1713923855-891647 X-HE-Meta: U2FsdGVkX1+LdKq9K220WLLCbMonYSwl94zfQJx6LLlCzADoxBqpOKyXNE24IZZEm6x84x5vic3ukVm2F8ToesMODiWtcYls3wJ2ULfDkz2WFhtkEU456X5VCpqFyh++ZPrnHdwdBshcqZGVc6CTJehb2KsEMQvfXvc7vrzed2rh6n/YzVK6NjH8opyVxo5xFaATV/oeN08RMspahK/ST5an8K+hWPPuinLTcxAiVapobeQVbKVoFRDOuOM+Txwki76RjzQyzNLEsZcEF1VXPriSU1W5GYFAgsVzqOfRhvnKzJt0QqpsXKow3rEvAHEWzx9hQfqUeTnn9yZOfUEhhTnge0w97kDNz9/ZajQkeUndt+Wm5qESJDMRqG2hBQz0/GBcBVBlTs/6L2FjuCji4/PJ5o0sTu9JIUFQQiGCiBoAbMg4loR9nPASy2YmqpA1N7Aka0Gxv7PBxuU6YXByOd8aqtyt2tC2exBHpBi6B96VOCevW2nq++T6XRoTN4BpM6XjnVgqgom5gd5YexoSh443hDVc0KxuGPtLfpvVVg+b83kJwKChnmGyuxLFsueiXrjTdQFb0+7TKn5QN1ODPCx2QBmwiq3oHtAbKYnqgC0z0BYxHFTUc09EfA867hZ9ZIwKtM7vrt7Qtbir4myi4zx6gL4hgQFJ957hC5FHBGuIPZuT+tPJ2qAO8HC7Gik13kJ515OZ1OKyXlF7DehNPGwlZ42wtDlQh2NWu/0Z6zTwSl29HYG/jlPAMz5Ey0nUycTT+7OTsXRlORlBbGEpKe623vRHuWysgMSFlwLLBV3pkroTyNp4E05vs90GwcEqXZTvTPgdjvhSopK0NajgvKufncGOJHhyuUzqOtDEmVkNfERQwJIDsSf0VXk1HEB15xXY4RIkD+rrjCZlXgaEhImYMoQY1uD5BkXO8n9Nd9Jo09sDugxhcb++q4JOqY4aLMIk5Uw7uINVLA7XZDD 8G7yaxZW OViYEzKkglNm7WGe0UYxLv2f6Qbt3HyIhhytgqi6F8ummO+tecHFTHUMbnPyNewwdDvPqWlisav0P0BZmm5s65yCetdHJYZMxE8A0RdrN6IlmDuWY2ASmyHc2fgFcGMe5BN5HhNmlaBb6411AbYh+P1ler+OMcUa7G4J0x/wFv7FcU/PeALngSBsMl0vPCF8CxQpTtCh0VY7iADF27X5FE7E3SYhEmIlPkSKrpdtrcf21K+hMbez0ib5Xn/vFmWfiVK+yEE50+YJD8z2TQJ9elC7oTwqqDgwbBjUBCB5LNZzqLjnsiUnCEzi6HCji3pMv8g9oJivCBEhOAWqtTh0tKZPw+UqUZmhIVg1c2ua0CZcwlT9hEDhQ+px9LDfgmoZXa86EegjXntDcT43nNKV/qA6JpMWGz6SHev1G9mbFFsETMxOvtSOQbHIa4+9mOBTAwP9eyag9iVIsXzo2xBqcTZei6lNA0U38s6bXTjCFs/74FiD9KH7KXywBWbODUDdHrsnPGSj5NKbXZ5pm87JMOm4e9sso6U4ClX56Bt2wv8y+Ic8auuadk9AYEWUvCz9bveiyKTM71CO9eqW8lPwQbutibgrKs7D5asP6CXQW4nl36hg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 24, 2024 at 2:51=E2=80=AFAM Ryusuke Konishi wrote: > > On Wed, Apr 24, 2024 at 2:04=E2=80=AFAM Kairui Song wrote: > > > > From: Kairui Song > > > > page_index is only for mixed usage of page cache and swap cache, for > > pure page cache usage, the caller can just use page->index instead. > > > > It can't be a swap cache page here (being part of buffer head), > > so just drop it, also convert it to use folio. > > > > Signed-off-by: Kairui Song > > Cc: Ryusuke Konishi > > Cc: linux-nilfs@vger.kernel.org > > --- > > fs/nilfs2/bmap.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/fs/nilfs2/bmap.c b/fs/nilfs2/bmap.c > > index 383f0afa2cea..9f561afe864f 100644 > > --- a/fs/nilfs2/bmap.c > > +++ b/fs/nilfs2/bmap.c > > @@ -453,8 +453,7 @@ __u64 nilfs_bmap_data_get_key(const struct nilfs_bm= ap *bmap, > > struct buffer_head *pbh; > > __u64 key; > > > > - key =3D page_index(bh->b_page) << (PAGE_SHIFT - > > - bmap->b_inode->i_blkbits); > > + key =3D bh->b_folio->index << (PAGE_SHIFT - bmap->b_inode->i_bl= kbits); > > for (pbh =3D page_buffers(bh->b_page); pbh !=3D bh; pbh =3D pbh= ->b_this_page) > > key++; > > This conversion mixes the use of page and folio within the function. > Would you like to take the opportunity to convert > "page_buffers(bh->b_page)" to "folio_buffers(bh->b_folio)" as well? OK, will update this part.