From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D123C61DA4 for ; Thu, 16 Feb 2023 07:55:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FF956B0073; Thu, 16 Feb 2023 02:55:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5880B6B0074; Thu, 16 Feb 2023 02:55:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 428046B0078; Thu, 16 Feb 2023 02:55:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2C1516B0073 for ; Thu, 16 Feb 2023 02:55:43 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0174180B04 for ; Thu, 16 Feb 2023 07:55:42 +0000 (UTC) X-FDA: 80472395766.27.B13D716 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf13.hostedemail.com (Postfix) with ESMTP id 09D3D20009 for ; Thu, 16 Feb 2023 07:55:40 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676534141; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VhDO2MK0kPOmCAUzaTEIi3IbK3jHyOtFPMZslsdD/VM=; b=as4PLDfy1i8nClvAE1NFAegAPn1jAGLM+igKiZLol/M+YFLbx4d8C4eXtxDb+YBB6fXPKa RNu7JQCLDRGqMxV+9Zia32Lf6qxj9eo+SNRZVjinayho7Dsfb3p8pbMef0dj5ArO2bktna +V49ENUtTUmdS4vkzctggwYWJIiIzVY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676534141; a=rsa-sha256; cv=none; b=i2aW1lFM6JK0bh11oQzx05DdooZUEB4ARFip6puEt8uyCXKpflQXcS0A4/chX6WK6S2DzZ Bws9bPK39gtfm3n+9BUmQVUKd8vKaA8wYiaZd32eJJH1NVXBX1dheIOO52PNSjlOJoNvC/ X95Uc6PkjiugjhBxgSwot+qi/byVdtQ= Received: by mail-qt1-f174.google.com with SMTP id q13so1329466qtx.2 for ; Wed, 15 Feb 2023 23:55:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VhDO2MK0kPOmCAUzaTEIi3IbK3jHyOtFPMZslsdD/VM=; b=MBQul532dkuXD6P0AZ6D6iD1/sZrCxbDpp4Bo+/CjKoKT+p2RhIxJK8q8accLDKgeM n6pXh3l9ySoQzvNjSL5YihFna7o5PU0kv316T/8T1rnLvsJh6zRAn+QdZuIekPYjBVfC /zrQsJCouJ7OWkZU54M+uFPY7wAjB5IfTUFwyojls2N5wcUL8Kh92LZjxurm4Joppmjr ZoenHxfN6VSSD7Yd1OIB1wDKVFzo525tw3Ga5ES7LoX16kq2sWdm2xwS69+7Q9TnJcV1 SY8O2KO3Fo1mp228vlvGaVIPV5VWYOphZ+dnVlPm3fR5bsI6pNc33EJgDuTqXIYRPzdL dteQ== X-Gm-Message-State: AO0yUKV2bp8l9PPGy1m7HuYbPK1K79Fu1sMLcWzxffJ+xkD/Azs0UOOq C4uIttOzvwFw6GpF+csju3nsCCLtBV3l1w== X-Google-Smtp-Source: AK7set8mx3OMiVdViVAifOyXPh01+Hvhm4TvWmyzqKakWLoH/okLTlrhIRXLUDTHN63SbLgZPWd5Lg== X-Received: by 2002:a05:622a:1116:b0:3b8:5bfc:57be with SMTP id e22-20020a05622a111600b003b85bfc57bemr8918833qty.65.1676534139742; Wed, 15 Feb 2023 23:55:39 -0800 (PST) Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com. [209.85.128.172]) by smtp.gmail.com with ESMTPSA id 7-20020a05620a040700b006fbb4b98a25sm679988qkp.109.2023.02.15.23.55.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Feb 2023 23:55:39 -0800 (PST) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-52eb7a5275aso14024677b3.2 for ; Wed, 15 Feb 2023 23:55:39 -0800 (PST) X-Received: by 2002:a81:73c4:0:b0:52e:ec16:6f19 with SMTP id o187-20020a8173c4000000b0052eec166f19mr791610ywc.33.1676534138884; Wed, 15 Feb 2023 23:55:38 -0800 (PST) MIME-Version: 1.0 References: <20230215000446.1655635-1-willy@infradead.org> <20230215200920.1849567-1-willy@infradead.org> <20230215200920.1849567-2-willy@infradead.org> <84c923f7-c60b-068d-bb06-48aea1412f53@gmail.com> In-Reply-To: From: Geert Uytterhoeven Date: Thu, 16 Feb 2023 08:55:27 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 15/17] m68k: Implement the new page table range API To: Matthew Wilcox Cc: Michael Schmitz , linux-mm@kvack.org, linux-m68k@lists.linux-m68k.org, linux-arch@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 09D3D20009 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: ydqe9gfkgh4mh6435ziaxtqfea9t6qjp X-HE-Tag: 1676534140-168373 X-HE-Meta: U2FsdGVkX1+IUHJOGXr5IH5wbTss8vl8XVBSjGZXQdwfg36c18TQVu+0t+Vq37zb9S2TDWuVMyI7JPvcWeB6wntnvpKtX6kF+LbVIwm2t1d6IeSw0o1mtq6Pc1DfPK9M9YqwMFj2rTDSn1lDCh4z3s8BMiSbv0DNeioUYHZtalsnT3Vas9VAdvhTOGb+ntjIWhjBqdh1JOi/QKH9XfucuIagMNe+HvqLWcmEgzvFEs2tjtGfgUpHmiGZoHHE2pUTIAGu7iprngjUrD4HmFG0h4KjWS9f2h3RAioCGvwkdmdrVZHln/z3eKL2dzEXQRq8/gchZdz/AMZoq6KwMMqNj+KskamTG1TGqnrW35TsrT4AQ7J08TnTMknvgR9JQYj4FKLXcYrWVWWVzZJoGoI9UdOGIk/So0wdzu9cy7R1MSZjw+4+C0BlPbJYjS4nBmU1geT3E9sZMewqnfOfQt/4frWKMlu0CjZNa/W7NCQQx8pxVmvdX9dqINH4R32dfUzaHuWL5mqItaeSEA6emepUaQeYwycYChZS1UYpSvfs1pZJ8HwPwk6dE/pU7MCKcna8V44R/uN8v7wSUUg6qkIflYRWtZ+flXic0JzUWin/4e2O8UAJHsAA9125NUPVqOACVMsFuReC/QHugAiZdvP5xVm2RP/xGwIeb9DPTwZprnYcpKXqVGAktLfoQT7WOz7kF9/nkipMkLC3PDK4GqUYkvKUymLLceaL0D4rAzF2n44Xm3+AuKAAArNuMDmbo4irZPZ5sPqItgCTqvCIxvrsjNlcsJdCDz9/deSstsIJ1xCWZkaC9pe+q/FAwUlO+JceI+sdRAlRYkrjMSdPvE/pj+7chR79a0p598vaySkUw2mdTA/zZRE0azi3vMH1ms3uH6Uzx+0YLBD87k9MSAV+UfYn96iNhJwKePRxLxWFHPMUuLWDYN7nFlqP/znNk8EczLXPCiFIi//nXx8WD25 0CQr3gP5 DwNdcWYttnULRGiybj6s1vYZoKvE+Shd6uuIDZuXUcdEGNnivXIqGU/3mPT7qH/3D1hAsRGBV5C0q3jEb7aeCVNluKai1MV70HcmCn3dTzfLiy727nygHPMeT096k0wLtxm8CNbRPPDvt0MI8uoTdad5Q/Z3SQECL+/IcRegmH0QJPKNVeVzLCH14X1KW6N5CQ99CLoO0UU88owqWi2XI8xtOPpKMMVY4R6CMQR1ZB+pk3c4Mvq3noZiVj5jBO8MNd2k0SjNXvUw0X0MQOoo1usmNv+dqEyF7ziMbo3DJ0L85S9Eh29P1ls/Q+3XrwowRfkElHVh4gd5jascaefysdMSFHVTSgZ++Wcnfdtq5ywKiIl31Uf971wMPh/Fr8LyclQ4rUlsIIVc56ev+SZNP8i3sQgtkHpPpXJIb5WPTZDBldnQHO4m+Nftvmzv4mdoOhuU5GqF1Q4sQSj4Klmpws3ujGwXSsV3ZzJWks6PCgCTBiN37QNwBgMnxzsg0965hxaGbm8YtM34Cq4l1nOyhNc8GoA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Matthew, On Thu, Feb 16, 2023 at 5:26 AM Matthew Wilcox wrote: > On Thu, Feb 16, 2023 at 01:59:44PM +1300, Michael Schmitz wrote: > > On 16/02/23 09:09, Matthew Wilcox (Oracle) wrote: > > > Add set_ptes(), update_mmu_cache_range(), flush_icache_pages() and > > > flush_dcache_folio(). I'm not entirely certain that the 040/060 case > > > in __flush_pages_to_ram() is correct. > > > > I'm pretty sure you need to iterate to hit each of the pages - the code as > > is will only push cache entries for the first page. > > > > Quoting the 040 UM: > > > > "Both instructions [cinv, cpush] allow operation on a single cache line, all > > cache lines in a specific page, or an entire cache, and can select one or > > both caches for the operation. For line and page operations, a physical > > address in an address register specifies the memory address." > > I actually found that! What I didn't find was how to tell if this > cpush insn is the one which is operating on a single cache line, > a single page, or the entire cache. cpushl (line), cpushp (page), cpusha (all). Same for cinv. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds