From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f71.google.com (mail-it0-f71.google.com [209.85.214.71]) by kanga.kvack.org (Postfix) with ESMTP id CA0A16B0038 for ; Tue, 14 Mar 2017 14:37:00 -0400 (EDT) Received: by mail-it0-f71.google.com with SMTP id g138so6063426itb.4 for ; Tue, 14 Mar 2017 11:37:00 -0700 (PDT) Received: from mail-io0-x241.google.com (mail-io0-x241.google.com. [2607:f8b0:4001:c06::241]) by mx.google.com with ESMTPS id j90si702677ioi.119.2017.03.14.11.36.59 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Mar 2017 11:36:59 -0700 (PDT) Received: by mail-io0-x241.google.com with SMTP id f84so815806ioj.0 for ; Tue, 14 Mar 2017 11:36:59 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20170313052213.11411-1-kirill.shutemov@linux.intel.com> References: <20170313052213.11411-1-kirill.shutemov@linux.intel.com> From: Geert Uytterhoeven Date: Tue, 14 Mar 2017 19:36:58 +0100 Message-ID: Subject: Re: [PATCH] mm, gup: fix typo in gup_p4d_range() Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Linus Torvalds , Andrew Morton , Michal Hocko , Linux-Arch , Linux MM , "linux-kernel@vger.kernel.org" , Linux-Renesas , Simon Horman Hi Kirill, On Mon, Mar 13, 2017 at 6:22 AM, Kirill A. Shutemov wrote: > gup_p4d_range() should call gup_pud_range(), not itself. > > Signed-off-by: Kirill A. Shutemov > Reported-by: Chris Packham > Fixes: c2febafc6773 ("mm: convert generic code to 5-level paging") FTR, this (now commit ce70df089143c493) fixes the strange crashes I saw with plain v4.11-rc2 and renesas-devel-20170313-v4.11-rc2 during shutdown on Renesas R-Car Gen2 (arm) and R-Car Gen3 (arm64) (but not on older SH/R-Mobile), and that I bisected to commit c2febafc6773. Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org