From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id D76239000C7 for ; Mon, 3 Oct 2011 07:15:09 -0400 (EDT) Received: by iaen33 with SMTP id n33so7429774iae.14 for ; Mon, 03 Oct 2011 04:15:07 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20111003192458.14d198a3.kamezawa.hiroyu@jp.fujitsu.com> References: <20111003192458.14d198a3.kamezawa.hiroyu@jp.fujitsu.com> Date: Mon, 3 Oct 2011 13:15:07 +0200 Message-ID: Subject: Re: One comment on the __release_region in kernel/resource.c From: Geert Uytterhoeven Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Wei Yang Cc: KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Mon, Oct 3, 2011 at 12:24, KAMEZAWA Hiroyuki wrote: > On Sun, 2 Oct 2011 21:57:07 +0800 > Wei Yang wrote: > >> Dear experts, >> >> I am viewing the source code of __release_region() in kernel/resource.c. >> And I have one comment for the performance issue. >> >> For example, we have a resource tree like this. >> 10-89 >> =C2=A0 =C2=A020-79 >> =C2=A0 =C2=A0 =C2=A0 =C2=A030-49 >> =C2=A0 =C2=A0 =C2=A0 =C2=A055-59 >> =C2=A0 =C2=A0 =C2=A0 =C2=A060-64 >> =C2=A0 =C2=A0 =C2=A0 =C2=A065-69 >> =C2=A0 =C2=A080-89 >> 100-279 >> >> If the caller wants to release a region of [50,59], the original code wi= ll ^^^^^^^ Do you really mean [50,59]? I don't think that's allowed, as the tree has [55,59], so you would release= a larger region that allocated. Gr{oetje,eeting}s, =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0=C2=A0 -- Linus Torvalds -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org