From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E8C0C43334 for ; Fri, 15 Jul 2022 08:18:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E46299401D8; Fri, 15 Jul 2022 04:17:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF5A99401A5; Fri, 15 Jul 2022 04:17:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE4EF9401D8; Fri, 15 Jul 2022 04:17:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BF8439401A5 for ; Fri, 15 Jul 2022 04:17:59 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 911A921541 for ; Fri, 15 Jul 2022 08:17:59 +0000 (UTC) X-FDA: 79688631078.06.C872F8B Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf13.hostedemail.com (Postfix) with ESMTP id E7CC520091 for ; Fri, 15 Jul 2022 08:17:57 +0000 (UTC) Received: by mail-qt1-f170.google.com with SMTP id ck6so3248288qtb.7 for ; Fri, 15 Jul 2022 01:17:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A8U10zfMg2MHnCiIBNObwk422GWQl02SfoTHfiQ0fc8=; b=KdQciDRiDUdGV0i9zjtMQs2grymWZhh7NIWdiWnKsJ5i1AWOrsINAAPSW9YR8MTYzS Za+NqzPcC/6r5YA3sBL5fEDUscNdcanxwuQGTPltRkt4STQ7BZjuTD4pFRu3BTRFr6D5 Z/OPz/ipmapNaIME7+0ox+OyxErHFLW1gdbks11sKNEZOzddfJbY1E1T5Wtsh4nSphLB 3OkszNdL157QGtPNqQa77LGDiKuwITjp/zI47jYM9RJyJ5fBrulLE17bR3CtUWe7mUQV 6Ff41BfqNVoG4QGZfRG43HrDI+Cyvpt0d0QldtCg7+JgoLhlgeFfLgJP5GOIR9uXha7s o5uQ== X-Gm-Message-State: AJIora+TY1gspl8DXcL+/JVmrKdSfLA6Tuy5XHZYKmfyDNCWznQQ4mSz 3jt6oefaaNYWkZbVuZvGGSp+cY7ZEzXOPw== X-Google-Smtp-Source: AGRyM1vzsDPQ/4/gSgvoUsBtfVJd2UrWyA/JY1U8utYPWiXg9flXb/M8SjhKsXperyLAvH3+NOpZXA== X-Received: by 2002:a05:622a:5d0:b0:31e:9a2a:2035 with SMTP id d16-20020a05622a05d000b0031e9a2a2035mr11544778qtb.310.1657873076842; Fri, 15 Jul 2022 01:17:56 -0700 (PDT) Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com. [209.85.128.173]) by smtp.gmail.com with ESMTPSA id r10-20020ac85e8a000000b0031eb51dd72csm3045197qtx.85.2022.07.15.01.17.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jul 2022 01:17:56 -0700 (PDT) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-31d85f82f0bso40214197b3.7 for ; Fri, 15 Jul 2022 01:17:56 -0700 (PDT) X-Received: by 2002:a81:af27:0:b0:31c:833f:eda5 with SMTP id n39-20020a81af27000000b0031c833feda5mr14511861ywh.358.1657873075845; Fri, 15 Jul 2022 01:17:55 -0700 (PDT) MIME-Version: 1.0 References: <20220628113714.7792-1-yee.lee@mediatek.com> <20220628113714.7792-2-yee.lee@mediatek.com> In-Reply-To: <20220628113714.7792-2-yee.lee@mediatek.com> From: Geert Uytterhoeven Date: Fri, 15 Jul 2022 10:17:43 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/1] mm: kfence: apply kmemleak_ignore_phys on early allocated pool To: yee.lee@mediatek.com Cc: Linux Kernel Mailing List , Catalin Marinas , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , Matthias Brugger , "open list:KFENCE" , "open list:MEMORY MANAGEMENT" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657873078; a=rsa-sha256; cv=none; b=Cl7uvSacLSoMh1ts5NzEj8WkngAYASbiXaB+396dlalTpX9JRBS9V8PLK5+i6ZkYsUzWY4 eSEItMpgo0JudVFlq+GepO+w8a/W9FPVfPsGTE3eRatP/+5Tx1Qjmt5DcUo/NEHJ3ExQbA Id+fJnln5Cq6cNzaop4xO2K9Nm6+0M8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657873078; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A8U10zfMg2MHnCiIBNObwk422GWQl02SfoTHfiQ0fc8=; b=TPrfO3C2ICh3Z1nSz2mh1EOQMAFycxR7ZEwJ9/Yrf7QxgL22M6dFNPZeIWWQBgx3+DdeYn yvwQEUv87saWRRSHdQ7CVt1z9c5TXNh0N3WAirtbxyUkQSdbnfUz7bQS7bHOkuZdjhIQXM nCqwGjVV90q9itJOfgPU4eiZPssHFcg= X-Rspam-User: X-Rspamd-Queue-Id: E7CC520091 Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none X-Rspamd-Server: rspam04 X-Stat-Signature: rqody3qt5wfmy1cqwgt7fmx884hjwj9w X-HE-Tag: 1657873077-129417 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yee, On Tue, Jun 28, 2022 at 1:42 PM wrote: > From: Yee Lee > > This patch solves two issues. > > (1) The pool allocated by memblock needs to unregister from > kmemleak scanning. Apply kmemleak_ignore_phys to replace the > original kmemleak_free as its address now is stored in the phys tree. > > (2) The pool late allocated by page-alloc doesn't need to unregister. > Move out the freeing operation from its call path. > > Suggested-by: Catalin Marinas > Suggested-by: Marco Elver > Signed-off-by: Yee Lee Thank you, this fixes the storm of BUG: KFENCE: invalid read in scan_block+0x78/0x130 BUG: KFENCE: use-after-free read in scan_block+0x78/0x130 BUG: KFENCE: out-of-bounds read in scan_block+0x78/0x130 messages I was seeing on arm64. Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds