From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CBBBC433F5 for ; Thu, 28 Apr 2022 07:20:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F03A16B0071; Thu, 28 Apr 2022 03:20:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB34A6B0072; Thu, 28 Apr 2022 03:20:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7A666B0073; Thu, 28 Apr 2022 03:20:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id C5A196B0071 for ; Thu, 28 Apr 2022 03:20:32 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 973CF1218E4 for ; Thu, 28 Apr 2022 07:20:32 +0000 (UTC) X-FDA: 79405439904.21.841BA83 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf12.hostedemail.com (Postfix) with ESMTP id 397464004D for ; Thu, 28 Apr 2022 07:20:22 +0000 (UTC) Received: by mail-qt1-f171.google.com with SMTP id fu47so2843370qtb.5 for ; Thu, 28 Apr 2022 00:20:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nFnxkytxiDV9tiNmv6YagpRIo9s4lkmQusqhamT+HGQ=; b=xjdLfkjUaHAIozV06b8tJJsDZtHXdEidJCVuumT8y2fQDVfbCWYP13TCE77AH4L++n 2Rq3bRlcRwFGiX9+41cIatpoNh/Ybtynl3QF8V/WLKgStZcS+mEIpSDQdmPZBBUC8bvE YFKiFfwyafFFDq066VvQxtaT3t6lpIEMxaM1W0vkmxnMgcgvxUH7T/WSMJo8b+a48ClP q4OKSo72XzwCOZpH15MtYZBpHsTH7gfIuNCp7wadvI9fLB6YsoXwJpMNrkcpaO3murkF Sz55f6uabVxtJq51BMWW3axQSQEpqA6lBiPUbA3DOmEGjkKNownCvhyhzapvqysR/X6L HVYQ== X-Gm-Message-State: AOAM530xpE6vdGyic3NmoWLca2kM0ACW89RCSwB5peMCPxiBbCWvWfdn 5hkDlczY9C+olLZosfOUMGqjKn61d8X5Xw== X-Google-Smtp-Source: ABdhPJyVuhyzh0cjBTsohI3LEhPQ4Kw1R9Z91X/JRKjRv0P8SMHyIJB6XBvvnr6ty0qN4BvvpD2aDQ== X-Received: by 2002:ac8:7f89:0:b0:2f3:875c:8c58 with SMTP id z9-20020ac87f89000000b002f3875c8c58mr2676027qtj.409.1651130431496; Thu, 28 Apr 2022 00:20:31 -0700 (PDT) Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com. [209.85.219.170]) by smtp.gmail.com with ESMTPSA id m190-20020a378ac7000000b0069f8d810f16sm2006395qkd.85.2022.04.28.00.20.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 00:20:31 -0700 (PDT) Received: by mail-yb1-f170.google.com with SMTP id f38so7469565ybi.3 for ; Thu, 28 Apr 2022 00:20:30 -0700 (PDT) X-Received: by 2002:a25:8087:0:b0:641:dd06:577d with SMTP id n7-20020a258087000000b00641dd06577dmr29182800ybk.207.1651130430756; Thu, 28 Apr 2022 00:20:30 -0700 (PDT) MIME-Version: 1.0 References: <20220428033319.239341-1-gerg@linux-m68k.org> <20220428033319.239341-5-gerg@linux-m68k.org> In-Reply-To: <20220428033319.239341-5-gerg@linux-m68k.org> From: Geert Uytterhoeven Date: Thu, 28 Apr 2022 09:20:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/4] m68knommu: allow elf_fdpic loader to be selected To: Greg Ungerer Cc: "Linux/m68k" , Linux MM , Linux Kernel Mailing List , Rich Felker Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 397464004D X-Stat-Signature: f689tniyjf6kmoc1bz961jmnmc4xyr4c X-HE-Tag: 1651130422-897357 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Greg, On Thu, Apr 28, 2022 at 7:05 AM Greg Ungerer wrote: > The m68k architecture code is capable of supporting the binfmt_elf_fdpic > loader, so allow it to be configured. It is restricted to nommu > configurations at this time due to the MMU context structures/code not > supporting everything elf_fdpic needs when MMU is enabled. > > Signed-off-by: Greg Ungerer Reviewed-by: Geert Uytterhoeven > --- a/fs/Kconfig.binfmt > +++ b/fs/Kconfig.binfmt > @@ -58,7 +58,7 @@ config ARCH_USE_GNU_PROPERTY > config BINFMT_ELF_FDPIC > bool "Kernel support for FDPIC ELF binaries" > default y if !BINFMT_ELF > - depends on (ARM || (SUPERH && !MMU)) > + depends on (ARM || ((M68K || SUPERH) && !MMU)) While at it, you may want to drop the unneeded outer parentheses, as they make the expression harder to round, IMHO. > select ELFCORE > help > ELF FDPIC binaries are based on ELF, but allow the individual load Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds