From: David Airlie <airlied@redhat.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: Dave Airlie <airlied@gmail.com>,
dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
Johannes Weiner <hannes@cmpxchg.org>,
Dave Chinner <david@fromorbit.com>,
Kairui Song <kasong@tencent.com>
Subject: Re: [PATCH 10/17] ttm: add a memcg accounting flag to the alloc/populate APIs
Date: Tue, 1 Jul 2025 11:46:49 +1000 [thread overview]
Message-ID: <CAMwc25o5H9YZiNdrE5N8coEvvM1KGtKCX4jW7oTWUXgi2PvTLA@mail.gmail.com> (raw)
In-Reply-To: <ef369d08-1913-47f2-818c-e4f6643f6600@amd.com>
On Mon, Jun 30, 2025 at 8:20 PM Christian König
<christian.koenig@amd.com> wrote:
>
> On 30.06.25 06:49, Dave Airlie wrote:
> > From: Dave Airlie <airlied@redhat.com>
> >
> > This flag does nothing yet, but this just changes the APIs to accept
> > it in the future across all users.
> >
> > This flag will eventually be filled out with when to account a tt
> > populate to a memcg.
>
> I would keep the pool completely out of memcg accounting and always account at a higher level.
>
> Accounting that low just gives a hughe surfurce for driver issues.
https://lore.kernel.org/dri-devel/20250512061913.3522902-6-airlied@gmail.com/
This is where I already tried it, and had to move it back:
"This version moves back from the resource to the tt layer,
when accounting at the resource layer, if an object is swapped
out there was no way to remove it from the accounting, whereas
the tt layer has more info for this."
Dave.
next prev parent reply other threads:[~2025-07-01 1:47 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 4:49 drm/ttm/memcg/lru: enable memcg tracking for ttm and amdgpu driver Dave Airlie
2025-06-30 4:49 ` [PATCH 01/17] mm: add gpu active/reclaim per-node stat counters (v2) Dave Airlie
2025-06-30 4:49 ` [PATCH 02/17] drm/ttm: use gpu mm stats to track gpu memory allocations. (v2) Dave Airlie
2025-06-30 10:04 ` Christian König
2025-07-01 1:41 ` David Airlie
2025-07-02 16:08 ` Shakeel Butt
2025-06-30 4:49 ` [PATCH 03/17] mm/list_lru: export list_lru_add Dave Airlie
2025-06-30 4:49 ` [PATCH 04/17] ttm/pool: port to list_lru. (v2) Dave Airlie
2025-06-30 10:37 ` kernel test robot
2025-06-30 4:49 ` [PATCH 05/17] ttm/pool: drop numa specific pools Dave Airlie
2025-06-30 10:12 ` Christian König
2025-06-30 4:49 ` [PATCH 06/17] ttm/pool: make pool shrinker NUMA aware Dave Airlie
2025-06-30 10:15 ` Christian König
2025-06-30 21:30 ` David Airlie
2025-06-30 4:49 ` [PATCH 07/17] ttm/pool: track allocated_pages per numa node Dave Airlie
2025-06-30 4:49 ` [PATCH 08/17] memcg: add support for GPU page counters Dave Airlie
2025-07-02 16:06 ` Shakeel Butt
2025-07-03 5:43 ` David Airlie
2025-06-30 4:49 ` [PATCH 09/17] memcg: export memcg_list_lru_alloc Dave Airlie
2025-06-30 4:49 ` [PATCH 10/17] ttm: add a memcg accounting flag to the alloc/populate APIs Dave Airlie
2025-06-30 9:56 ` kernel test robot
2025-06-30 10:20 ` Christian König
2025-07-01 1:46 ` David Airlie [this message]
2025-06-30 4:49 ` [PATCH 11/17] ttm/pool: initialise the shrinker earlier Dave Airlie
2025-06-30 4:49 ` [PATCH 12/17] ttm: add objcg pointer to bo and tt Dave Airlie
2025-06-30 10:24 ` Christian König
2025-06-30 21:33 ` David Airlie
2025-07-01 7:22 ` Christian König
2025-07-01 8:06 ` David Airlie
2025-07-01 8:15 ` Christian König
2025-07-01 22:11 ` David Airlie
2025-07-02 7:27 ` Christian König
2025-07-02 7:57 ` David Airlie
2025-07-02 8:24 ` Christian König
2025-07-03 5:53 ` David Airlie
2025-06-30 4:49 ` [PATCH 13/17] ttm/pool: enable memcg tracking and shrinker Dave Airlie
2025-06-30 10:23 ` Christian König
2025-06-30 21:23 ` David Airlie
2025-06-30 11:59 ` kernel test robot
2025-07-02 16:41 ` Shakeel Butt
2025-06-30 4:49 ` [PATCH 14/17] ttm: hook up memcg placement flags Dave Airlie
2025-06-30 4:49 ` [PATCH 15/17] memcontrol: allow objcg api when memcg is config off Dave Airlie
2025-06-30 4:49 ` [PATCH 16/17] memcontrol: export current_obj_cgroup Dave Airlie
2025-06-30 4:49 ` [PATCH 17/17] amdgpu: add support for memory cgroups Dave Airlie
2025-07-02 16:02 ` Shakeel Butt
2025-07-03 2:53 ` David Airlie
2025-07-03 17:58 ` Shakeel Butt
2025-07-03 18:15 ` Christian König
2025-07-03 20:06 ` Shakeel Butt
2025-07-03 21:22 ` David Airlie
2025-07-04 9:39 ` Christian König
2025-07-01 23:26 ` drm/ttm/memcg/lru: enable memcg tracking for ttm and amdgpu driver Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMwc25o5H9YZiNdrE5N8coEvvM1KGtKCX4jW7oTWUXgi2PvTLA@mail.gmail.com \
--to=airlied@redhat.com \
--cc=airlied@gmail.com \
--cc=christian.koenig@amd.com \
--cc=david@fromorbit.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hannes@cmpxchg.org \
--cc=kasong@tencent.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).