From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58827C77B7C for ; Tue, 24 Jun 2025 01:13:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D67B36B00C7; Mon, 23 Jun 2025 21:13:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEFD56B00C8; Mon, 23 Jun 2025 21:13:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2D5F6B00C9; Mon, 23 Jun 2025 21:13:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B22B26B00C7 for ; Mon, 23 Jun 2025 21:13:14 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 60867122FCF for ; Tue, 24 Jun 2025 01:13:14 +0000 (UTC) X-FDA: 83588520708.06.5C0DE09 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 15F3B180003 for ; Tue, 24 Jun 2025 01:13:11 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J9duUTUt; spf=pass (imf24.hostedemail.com: domain of airlied@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=airlied@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750727592; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N2tGbCUo/DT98ekW0QzjXKAmpAyFNKjENuliAc3v0g4=; b=PWW4yZtjM7mULHojyZKTzku5nA4TT9xdyc1TwJibN9iaX+4gnALI/xvbsYeZKHiO3N1UTA PWPvoRo63iFy3wkpkmcK44ZcGeods+ohrCLN6tLleesklnTghwl7mNgVIscxRenricc1m5 vJyOMoNNGhQeWb3UFWNfJncesHQog+8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J9duUTUt; spf=pass (imf24.hostedemail.com: domain of airlied@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=airlied@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750727592; a=rsa-sha256; cv=none; b=FAwiGr0HO2nqRvZCB2xKY+0jVz6WQpAP4pj4Tc8jWkaDAppMF6TZsgqyLEOvPNyv+xmzdU 317/XgGl5uzWVP4kOIwVbR4dc8hooJp7kTqQqBAfAQRUN55Nu0g+SDh8QxTsQV6sCncRXN KaWeHxHTNMIYQAsSSmJ9FXmX3aaaYDo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750727591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N2tGbCUo/DT98ekW0QzjXKAmpAyFNKjENuliAc3v0g4=; b=J9duUTUtNVKyvFhU1TnrdtSb3C0TnsqAZyHyKw3EyfmjNrYD/pVA93Ix4vPjoVc+0nIH7V sIQx9oFzJPvnuxCmYgr5MhZW8oYWYR9037DIKVvMJq1mjIGOWICq4dLr9vmvsQ2Qa1zROU VCgf4axUB8LS/HuJQKCwEkJkvmfT3Ew= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-lRzJlkbrNd6qV2Jbl88qVQ-1; Mon, 23 Jun 2025 21:13:09 -0400 X-MC-Unique: lRzJlkbrNd6qV2Jbl88qVQ-1 X-Mimecast-MFC-AGG-ID: lRzJlkbrNd6qV2Jbl88qVQ_1750727589 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-311e98ee3fcso4154205a91.0 for ; Mon, 23 Jun 2025 18:13:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750727589; x=1751332389; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N2tGbCUo/DT98ekW0QzjXKAmpAyFNKjENuliAc3v0g4=; b=FBHhtDFp6cPUWGkkGf3XdqLiNzM/k9139U375Pwi6PbPLwhiZdcBUy72ALFL44tdHk OrEoAP+jRQw0diG5hSSENrdvAc1xp5uNytO7ZzKcUMWRHk8jrjQq46klny3atzFQAt+A YAyOsph8nZ6Wptnb8c4fV/Sg1qNwbiR5U2eCio7gghai2XphXWJfopAjdq7PX3j3gvbG sqfhXIVVmbAbAGQ8v4pyZlmjWRlNOcsexTEk7Nv+qywU56O2zfQleg/MFlER5Y7BwiCq vB+MavkPOk5gyYMSKRVtkiZQReE89iDngFBeOg6O1KBVMQbR6NowWopY/KD9rZy3J6A3 rE3A== X-Forwarded-Encrypted: i=1; AJvYcCVZPA7D7F4OD7RTQth0s2ZpDQbUoBxc+CVuZUpEzcsv+eQPPuTiPSE/JJP7TBd+dmPe2hgr8hj4Ag==@kvack.org X-Gm-Message-State: AOJu0YwgZaVKiozMJk4u9dwWFLKpt2uy+th9RontBFZrG09s2RGq51Cm ZS4YhBH0mcYNMswLJemuz6+rXvXUxb/FRA355mmMVtvJ3a8g3ZMf8nV9sqGc/4OFoZfHNzEFf2P CArSSUO/RIG8Lo8AMnSBCNlXPwEi15zP3D1TUD/3jpeqqLCNjArxCDAR3UWGavUjYblPCuUjCi5 /A38ulW2p7hDvqJkDjs0ytkRyHaMg= X-Gm-Gg: ASbGncsvTdnFhgOiWrUebPsGkKd9J3NzMfAy/xIUAb560oTKfQLkPL4ZDIwIYyVYDC9 R61qoFZH4dlDcdDZdltKE0VCmccd2gcTSTPADqZedpdmLk9C5lLZYHhk8oaACDUSRX0OcpQBTJ6 0SXQ== X-Received: by 2002:a17:90b:35c3:b0:313:d361:73d7 with SMTP id 98e67ed59e1d1-315cccecb18mr2164196a91.13.1750727588604; Mon, 23 Jun 2025 18:13:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEsQNmhJBSGFRuS8o5jd1MRwK+2/7DeMzdFr6CGPS/Bmy9Yrf4+E7T7zDcaY+RjQfxGcisrAhQnQhUcHJ3ztJc= X-Received: by 2002:a17:90b:35c3:b0:313:d361:73d7 with SMTP id 98e67ed59e1d1-315cccecb18mr2164175a91.13.1750727588183; Mon, 23 Jun 2025 18:13:08 -0700 (PDT) MIME-Version: 1.0 References: <20250619072026.635133-1-airlied@gmail.com> <724720cd-eb05-4fc0-85a1-f6b60649b1ad@amd.com> In-Reply-To: <724720cd-eb05-4fc0-85a1-f6b60649b1ad@amd.com> From: David Airlie Date: Tue, 24 Jun 2025 11:12:56 +1000 X-Gm-Features: AX0GCFsc9jtESfggHiHxBG7I-UMTYHnzmvg1EjimOYK8Axjo4b-BQw1Xp5GOM5s Message-ID: Subject: Re: [PATCH 1/2] mm: add gpu active/reclaim per-node stat counters (v2) To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Dave Airlie , dri-devel@lists.freedesktop.org, Matthew Brost , Johannes Weiner , linux-mm@kvack.org, Andrew Morton X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TCbswLKsh8WImWFOcZqw6KPN3t9YuwhPgdUvFcVHI0k_1750727589 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: 15F3B180003 X-Stat-Signature: wfyc54f58o61hnj5gogzh6rx6r53836f X-HE-Tag: 1750727591-951242 X-HE-Meta: U2FsdGVkX19c2xJKjjFmu5SZq4lmcTQwHW07aWgHGea62kcPlMBLz9c/QfbpxKqphTCYqiLlMoeDg4KRuTClce4G0wOaGnIX89AXrh0mVjp64LBZn9nDkWRi+1r6KqzWXMqmGdquNmtHfyvTRWPbAmsq4H3B3mm51HhpE3E58EjN54j4Bk6fdO1bwmmkc3Gf4YGYdV/GAOy1eU+MvkcnHuIK3V2bRRCVcJWGxbu6EbDY8SgAEwnadksLgHlbdPUvSk0Bx0Psgo+3YNHlNCxRcFfDfNEj9TcoeCtiOBJxfYc9c55FmrUKAQZ/6sU2U68UV3qUe5TwixcEJhaWdJ8XXFcBAuv05Ldf1VHtIQm5LOdEQWr7Hc9LtT5zkFCmdgrULf4tQNBuoh4hOEcJdN1SnJ0JbmHGK2n+u48SM1gknY4/cZv6/GoGDzVzn7oAtbEpPMRk/3rjOF9y2nM6GgItnfGn/J5eiM9Zh4LHpkGv4IgGYLnX0uwetR67DsWebJ6W1JujNrS2mc8A4WdbYipRgyBza7ZC4e/n+vXGYcOOjk3QtoIYaMvfABrlMwQSoJ/AD39jBdS2rSe2XSepGdr4I33TGmzzq3x6ELI14mNyYjdyg9ftIt4wi0BvsNmuQDbv8kU7TuXl6S9UK7itbyFrIz+ho7OSE0GaITJg1r1+KGkWPne+Yr8PrFp1XeImlKMfnEDMMD9MKcMcNMAPSy0+0wcNkBJPvHpCKh6jV4g4eRv+d2q2vsP0dkkByfsNnDJ7ZKIC0Pihi84AbkrN6Gik/HgNWcBSZqhm2XoORkpLLIamcqDxqme6DJDdKEF05SxWnz6bg/qRgnHjQ4KKs0JXrFHOtmXHFhaPoioNpeZT822Jhbg+e6PBMsnuOqPi8koPonY2I/Ka+P61HqhYbqk1lWDRnWVFZwAn4L7U+kmgTzYkFBP8ssNOq1OaAUI5t8euy2deeRk1tz4CIbBw6Er 7+oml6F2 Q0fAPE+1PFbq+mxuKlaHG7/8syKS7AX5QZJsekW7gW47N0FuUC9vXylFklEagyJgIsC6C5WG03sM2kncK/9r7xuPncAttO0V0Krm17LyJvJuAN/CSLMyf1p2JI+7mFGMB0oBt+qx0ubklXC3e9FChvy21LUYlooFDWetd9Yz1msH7Ryx+rcotOgMvZ8zJ7i2bHC3E8iLnyiYvuYe5frI3Bwy+TCwx1Os4N9I/vKcRPCtGTqm73DTnYCCmzi9CNImEZ4vonl453pu4bOmLO0H48/7/EcMCXh7z5lQhAiTDxaBTaCAERqpV3YHa54BT2nXLzFmOzFMShlrEg+UZUMzs84o9AHOMTXqdtefDMpzSK6iHbHTwF+rg8dK9r/jFriJZsxEQ7C72eWr3b2nAWIpxhYd719op++41EEU9hrWQJ+Eygsvl1Yheytq751J3zwEQ1DUdThu7qu0gZ+tL8NGbsb93sPHegE11xqsbIslFUf2HOvBdPQlXlRNpbCE/BNNGlGP0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 23, 2025 at 6:54=E2=80=AFPM Christian K=C3=B6nig wrote: > > On 6/19/25 09:20, Dave Airlie wrote: > > From: Dave Airlie > > > > While discussing memcg intergration with gpu memory allocations, > > it was pointed out that there was no numa/system counters for > > GPU memory allocations. > > > > With more integrated memory GPU server systems turning up, and > > more requirements for memory tracking it seems we should start > > closing the gap. > > > > Add two counters to track GPU per-node system memory allocations. > > > > The first is currently allocated to GPU objects, and the second > > is for memory that is stored in GPU page pools that can be reclaimed, > > by the shrinker. > > > > Cc: Christian Koenig > > Cc: Matthew Brost > > Cc: Johannes Weiner > > Cc: linux-mm@kvack.org > > Cc: Andrew Morton > > Signed-off-by: Dave Airlie > > > > --- > > > > v2: add more info to the documentation on this memory. > > > > I'd like to get acks to merge this via the drm tree, if possible, > > > > Dave. > > --- > > Documentation/filesystems/proc.rst | 8 ++++++++ > > drivers/base/node.c | 5 +++++ > > fs/proc/meminfo.c | 6 ++++++ > > include/linux/mmzone.h | 2 ++ > > mm/show_mem.c | 9 +++++++-- > > mm/vmstat.c | 2 ++ > > 6 files changed, 30 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesys= tems/proc.rst > > index 5236cb52e357..7cc5a9185190 100644 > > --- a/Documentation/filesystems/proc.rst > > +++ b/Documentation/filesystems/proc.rst > > @@ -1095,6 +1095,8 @@ Example output. You may not have all of these fie= lds. > > CmaFree: 0 kB > > Unaccepted: 0 kB > > Balloon: 0 kB > > + GPUActive: 0 kB > > + GPUReclaim: 0 kB > > Active certainly makes sense, but I think we should rather disable the po= ol on newer CPUs than adding reclaimable memory here. I'm not just concerned about newer platforms though, even on Fedora 42 on my test ryzen1+7900xt machine, with a desktop session running nr_gpu_active 7473 nr_gpu_reclaim 6656 It's not an insignificant amount of memory. I also think if we get to some sort of discardable GTT objects with a shrinker they should probably be accounted in reclaim. Dave.