From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 149AFC433E0 for ; Thu, 4 Jun 2020 08:38:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B54EB206DC for ; Thu, 4 Jun 2020 08:38:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="j/CCKyyi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B54EB206DC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3BA1080007; Thu, 4 Jun 2020 04:38:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3446C8E0006; Thu, 4 Jun 2020 04:38:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 259E680007; Thu, 4 Jun 2020 04:38:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0053.hostedemail.com [216.40.44.53]) by kanga.kvack.org (Postfix) with ESMTP id 0B4E28E0006 for ; Thu, 4 Jun 2020 04:38:34 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C0F074417 for ; Thu, 4 Jun 2020 08:38:33 +0000 (UTC) X-FDA: 76890878106.22.size36_84e341259b93e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 8C98B18038E67 for ; Thu, 4 Jun 2020 08:38:33 +0000 (UTC) X-HE-Tag: size36_84e341259b93e X-Filterd-Recvd-Size: 4136 Received: from mail-yb1-f195.google.com (mail-yb1-f195.google.com [209.85.219.195]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Jun 2020 08:38:33 +0000 (UTC) Received: by mail-yb1-f195.google.com with SMTP id h39so849030ybj.3 for ; Thu, 04 Jun 2020 01:38:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=552FTsyBPmP0dIys2XvU7DaT4X8pVqCWxWc8Zz4SjJ8=; b=j/CCKyyi12hJt4X4YJ5jPUjnYgUqmF75Nt4hRNt6YKnV/taKrFZImPQ5T8ws5DSVXR xCPRqMYM7HINlDNEpVvc28tTSzUW+2Y7YE1prSQ/hE56w0dtP3r9imiZXen55WykmhKd 8pCJBy/O90/8I5D6Ifw0fLvfwSZTfwSXdqOJEDr6p7BpXasbsv7g29Bg23XhD78DCXK2 CRKAdkluo80uS7NhDRhrRGZdF99zAYbaI1OflgYRIlshnUCI6qy4xMuIZn0zAQp9t1lw FpjMMYIHGMwKolJfnmgzASHcdjPBNrk60LyHTUrQJ+ROAdGJF53opWizVK8QKz1iDbmF JlzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=552FTsyBPmP0dIys2XvU7DaT4X8pVqCWxWc8Zz4SjJ8=; b=ANSPVeYusysLEXMiFm/JdgPkFCnrEBhlaWFxT8Tq11oBk1iCX+Vvq4K0kOAwq+LOcA O3kwJfTyR8pIwq8F/byCBd12SIbnphW9WFeF1AxdMI6ZgvE4YjrZ9UdupFyHN9MXu+BO hRHJTdx3nngoeB/jKcWYkhgawEbYnOjMrgf1BHqLVVnKv1++aEb59pTTQ+8+BtpV9+qx JTBcF2wvm6U+XSy0VKYN7ycU2T+JFTlKgSz9y9vqP8/2QwMLMDyzX+o2n6FSZry/UtGv GkO5YXQV7IVb0jtd/LXbJ7XoMBGOYyPAwXIDboYeIXFrdvxVr0ONT6telMX+V3zI/aBV btvg== X-Gm-Message-State: AOAM531sIaStxSxGFDgXSFXxi2F2YJeP0kKBH121HehmI8HQvwoJwbWY kc7xNpUdAjXFNAcbASy4YEaETD+MOFOSVlug4tcKaA== X-Google-Smtp-Source: ABdhPJzcrcXUi2Ku7FkWmVcLSZg8uMvygPWDYZKbc+j99+tLrqn4nTF+cuVE1ZzCTbDTRUp80rvyLFJMRMCOpZXDqZ4= X-Received: by 2002:a25:ef07:: with SMTP id g7mr6125577ybd.516.1591259912263; Thu, 04 Jun 2020 01:38:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Michel Lespinasse Date: Thu, 4 Jun 2020 01:38:18 -0700 Message-ID: Subject: Re: [PATCH v6 10/12] mmap locking API: rename mmap_sem to mmap_lock To: youling 257 Cc: "Liam R . Howlett" , Andrew Morton , Daniel Jordan , Davidlohr Bueso , Hugh Dickins , Jason Gunthorpe , Jerome Glisse , John Hubbard , Laurent Dufour , LKML , linux-mm , Peter Zijlstra , David Rientjes , Vlastimil Babka , Matthew Wilcox , Ying Han Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 8C98B18038E67 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 4, 2020 at 1:16 AM youling 257 wrote: > 2020-06-04 13:57 GMT+08:00, Michel Lespinasse : > > However I would like more information about your report. Did you apply > > the series yourself ? If so, what base tree did you apply it onto ? If > > not, what tree did you use that already included the series ? > > I build linux next-20200603 tree have the kernel/sys.c error. Thanks for the info. The proper fix is to replace down_write(&mm->mmap_sem) with mmap_write_lock(mm) and up_write(&mm->mmap_sem) with mmap_write_unlock(mm) If you just needed a quick fix to get the tree to build, what you did (replacing mmap_sem with mmap_lock) is also fine. Thanks again ! -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.