From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Danilo Krummrich <dakr@kernel.org>, David Gow <davidgow@google.com>
Cc: Alice Ryhl <aliceryhl@google.com>,
lorenzo.stoakes@oracle.com, vbabka@suse.cz,
Liam.Howlett@oracle.com, urezki@gmail.com, ojeda@kernel.org,
alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, tmgross@umich.edu,
rust-for-linux@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] rust: alloc: add missing trait item MIN_ALIGN to Cmalloc
Date: Sun, 24 Aug 2025 16:07:19 +0200 [thread overview]
Message-ID: <CANiq72=Xp-u16fboZJvdRZCveRtAJLSTsiJMMDXsd2saKCU26w@mail.gmail.com> (raw)
In-Reply-To: <DCAOZLKAFK8Y.43MJ1XPUJ1OG@kernel.org>
On Sun, Aug 24, 2025 at 3:29 PM Danilo Krummrich <dakr@kernel.org> wrote:
>
> Actually, I think it's better to just do it:
>
> Miguel, mind if I just apply [1] and [2]? (Just recognizing, probably this was
> your intention anyways?)
Yeah, since 1b1a946dc2b5 is in the same branch, and David already
reviewed the main patch too, I think it is easier for you than trying
to deal with all this otherwise.
(Whether applying or rebasing both are fine I would say, since
`rusttest` is not a big deal and the chances of people bisecting on
that are low.)
For the other fix I sent that you already applied through DRM, I think
we did the right thing, because it was not `alloc-next` and it was
fairly trivial, so it made sense.
Thanks!
Cheers,
Miguel
next prev parent reply other threads:[~2025-08-24 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-24 12:06 [PATCH] rust: alloc: add missing trait item MIN_ALIGN to Cmalloc Danilo Krummrich
2025-08-24 12:36 ` Alice Ryhl
2025-08-24 13:04 ` Danilo Krummrich
2025-08-24 13:18 ` Danilo Krummrich
2025-08-24 13:29 ` Danilo Krummrich
2025-08-24 14:07 ` Miguel Ojeda [this message]
2025-08-24 14:41 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72=Xp-u16fboZJvdRZCveRtAJLSTsiJMMDXsd2saKCU26w@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=davidgow@google.com \
--cc=gary@garyguo.net \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).