From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: "Matthew Wilcox" <willy@infradead.org>,
linux@armlinux.org.uk, "Robin van der Gracht" <robin@protonic.nl>,
stefanr@s5r6.in-berlin.de, hjc@rock-chips.com,
"Heiko Stübner" <heiko@sntech.de>,
"Dave Airlie" <airlied@linux.ie>,
robin.murphy@arm.com, iamjoonsoo.kim@lge.com,
"Andrew Morton" <akpm@linux-foundation.org>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Kees Cook" <keescook@chromium.org>,
treding@nvidia.com, mhocko@suse.com,
"Dan Williams" <dan.j.williams@intel.com>,
kirill.shutemov@linux.intel.com,
"Mark Rutland" <mark.rutland@arm.com>,
"Andrey Ryabinin" <aryabinin@virtuozzo.com>,
"Dmitry Vyukov" <dvyukov@google.com>,
"Kate Stewart" <kstewart@linuxfoundation.org>,
tchibo@google.com, riel@redhat.com, minchan@kernel.org,
"Peter Zijlstra" <peterz@infradead.org>,
ying.huang@intel.com, "Andi Kleen" <ak@linux.intel.com>,
rppt@linux.vnet.ibm.com,
"Dominik Brodowski" <linux@dominikbrodowski.net>,
"Arnd Bergmann" <arnd@arndb.de>,
cpandya@codeaurora.org, hannes@cmpxchg.org,
"Joe Perches" <joe@perches.com>,
mcgrof@kernel.org,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux1394-devel@lists.sourceforge.net,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH v2] mm: Introduce new function vm_insert_kmem_page
Date: Thu, 4 Oct 2018 21:46:34 +0200 [thread overview]
Message-ID: <CANiq72mkTP_m20vqei-cpN+ypQ_gU472qn5m68vb_4Nqj5afMQ@mail.gmail.com> (raw)
In-Reply-To: <CAFqt6zaN0PQHkjuwFf8VriROLy7qrPDu-iNE=VPiXJw8C7GpQg@mail.gmail.com>
Hi Souptick,
On Thu, Oct 4, 2018 at 8:49 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> On Thu, Oct 4, 2018 at 11:47 PM Matthew Wilcox <willy@infradead.org> wrote:
> >
> > I think this is a bad plan. What we should rather do is examine the current
> > users of vm_insert_page() and ask "What interface would better replace
> > vm_insert_page()?"
> >
> > As I've said to you before, I believe the right answer is to have a
> > vm_insert_range() which takes an array of struct page pointers. That
> > fits the majority of remaining users.
>
> Ok, but it will take some time.
> Is it a good idea to introduce the final vm_fault_t patch and then
> start working on vm_insert_range as it will be bit time consuming ?
>
Well, why is there a rush? Development should be done in a patch
series or a tree, and submitted as a whole, instead of sending partial
patches.
Also, not sure if you saw my comments/review: if the interface is not
going to change, why the name change? Why can't we simply keep using
vm_insert_page?
Cheers,
Miguel
next prev parent reply other threads:[~2018-10-04 19:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 18:58 [PATCH v2] mm: Introduce new function vm_insert_kmem_page Souptick Joarder
2018-10-03 19:58 ` Miguel Ojeda
2018-10-04 11:56 ` Souptick Joarder
2018-10-03 20:00 ` Matthew Wilcox
2018-10-03 22:14 ` Russell King - ARM Linux
2018-10-04 0:39 ` Matthew Wilcox
2018-10-04 12:15 ` Souptick Joarder
2018-10-04 12:34 ` Russell King - ARM Linux
2018-10-04 18:12 ` Souptick Joarder
2018-10-04 18:17 ` Matthew Wilcox
2018-10-04 18:53 ` Souptick Joarder
2018-10-04 19:46 ` Miguel Ojeda [this message]
2018-10-05 5:50 ` Souptick Joarder
2018-10-05 8:52 ` Miguel Ojeda
2018-10-05 10:01 ` Souptick Joarder
2018-10-05 10:49 ` Miguel Ojeda
2018-10-05 12:11 ` Souptick Joarder
2018-10-05 18:09 ` Miguel Ojeda
2018-10-06 5:14 ` Souptick Joarder
2018-10-06 10:49 ` Miguel Ojeda
2018-10-23 12:14 ` Souptick Joarder
2018-10-23 12:24 ` Matthew Wilcox
2018-10-23 12:33 ` Souptick Joarder
2018-10-23 12:59 ` Matthew Wilcox
2018-10-23 13:15 ` Souptick Joarder
2018-10-04 18:21 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72mkTP_m20vqei-cpN+ypQ_gU472qn5m68vb_4Nqj5afMQ@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=airlied@linux.ie \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=cpandya@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dvyukov@google.com \
--cc=hannes@cmpxchg.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=jrdr.linux@gmail.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=linux@armlinux.org.uk \
--cc=linux@dominikbrodowski.net \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=mcgrof@kernel.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=robin.murphy@arm.com \
--cc=robin@protonic.nl \
--cc=rppt@linux.vnet.ibm.com \
--cc=stefanr@s5r6.in-berlin.de \
--cc=tchibo@google.com \
--cc=treding@nvidia.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).