From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBD84EB64DA for ; Thu, 20 Jul 2023 08:57:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60A4E2800E3; Thu, 20 Jul 2023 04:57:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BAEC28004C; Thu, 20 Jul 2023 04:57:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45B5C2800E3; Thu, 20 Jul 2023 04:57:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 334D328004C for ; Thu, 20 Jul 2023 04:57:38 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 05D7E160133 for ; Thu, 20 Jul 2023 08:57:38 +0000 (UTC) X-FDA: 81031386996.08.A10669D Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf21.hostedemail.com (Postfix) with ESMTP id 379541C000B for ; Thu, 20 Jul 2023 08:57:36 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=sbu7cKX3; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of edumazet@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=edumazet@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689843456; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k0Q8HK8TX799KwlVsueVU2Vn6pAZBPxCHZbkBqMog0w=; b=UKsmM+LL0i0nA5KZ76DoIb7VU4HNdz7uvCkP9tiSgVqrCV5oDzC0uR+BIDNCh05VfLCo9T iPC7CxUf847Bx/vCSUEjQiLs4jJfTDhJFt5hNsNiFpH5QoR9ASzdaqZnOP9qXVajKcvry1 0O5O4baXK2aR2HhsMsEzRS0y8rSh43o= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=sbu7cKX3; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of edumazet@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=edumazet@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689843456; a=rsa-sha256; cv=none; b=duVzPA9ryZM/91PL0VLHBTqMO0x0x8fL6/tB52wCUW6unLVfyMSfUScwps1AFTRr4Ntq9n XJJAqkqm3jOfwoOvxfmuPTquLQgXrVZKlyWH1gC3T8hL0WDjUxP7iSb1HgbrRQVyKXNDKK D8IZy8SN839KWn7ld7ipuS0dMEq8oMg= Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-40371070eb7so182451cf.1 for ; Thu, 20 Jul 2023 01:57:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689843455; x=1690448255; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k0Q8HK8TX799KwlVsueVU2Vn6pAZBPxCHZbkBqMog0w=; b=sbu7cKX3RJ4STU+W+JnLifIFmUz7jowp9LlbTrMBKpyqTT6Kt21vKp2H8FzOIS5tep bbXgF86b7ixmUe1C64by8cuyAkXEDJAhk/gJ2VRtUGHb9caKNjgb9OxMQP+zrnCqpcj2 0GriA2TxJI0nFyWsYdarH2tV2F8oXchBWBF49T4hNwMZKqRvLpT7KUAaFpv/hWBlJtnr eR3Q7T3Ih01HzEFFJp1vIMbg3XuP9jk+gC3Voy9dtnPLpZFwxTUCMBTiLlhqEnVZspy9 c7k4pKrsJ+tQo++vjhDeFYDA9oaDf8lz3TJbJLHFGGmlrXivPKXfPtwH5nnoPelp0XVz 2R6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689843455; x=1690448255; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k0Q8HK8TX799KwlVsueVU2Vn6pAZBPxCHZbkBqMog0w=; b=Y98XIePq/F3Upxuhnu/chU4gwuQlHLbHGifYLzS8IjprN6Jcw+wQkFET40FsntUwRp HE3NdS5jA3bP/E6DAdhZmYkoSvNujibe3TK5vzPxfnlfRpz1SshMms6ifuRmrZIx8b+x ihK4jed02CB3G2+rBPDOQAXnFhSjXghyiYOQWIZNtweMVtXNpWv7y/MiFcTNp5rUOzXT 4uK2RMFQfpq55QkzJRllYLYmDRxN01VM6Ttx/HDi9ftfjgGIDiY7qQ9gESnuHAOlI82k fv8vLOE3ofGqS11ngOv24f0oofC8HSZf0hE9LfuMzi+3EkEh+jMkUbw0a95KlJNVpnaK PPgA== X-Gm-Message-State: ABy/qLbw/lUgqZraWPqwRgX1aExfzIIWSA8KV0SeIXty1mvDAyH0MgkW NMuSACLbp80WSdMGNVhz/anEVu1lrrtn5Nq8Qdjzaw== X-Google-Smtp-Source: APBJJlFqutZVzbsA3NqN/Ssn0odGnTV/YCAAziUPG0pJHG9pnasjigUhJvUq9CLPLsN4fxxZHp1mY/y9L0R6loLApxY= X-Received: by 2002:a05:622a:1a12:b0:404:8218:83da with SMTP id f18-20020a05622a1a1200b00404821883damr159489qtb.1.1689843455136; Thu, 20 Jul 2023 01:57:35 -0700 (PDT) MIME-Version: 1.0 References: <20230711124157.97169-1-wuyun.abel@bytedance.com> In-Reply-To: From: Eric Dumazet Date: Thu, 20 Jul 2023 10:57:23 +0200 Message-ID: Subject: Re: [PATCH RESEND net-next 1/2] net-memcg: Scopify the indicators of sockmem pressure To: Abel Wu Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , David Ahern , Yosry Ahmed , "Matthew Wilcox (Oracle)" , Yu Zhao , Kefeng Wang , Yafang Shao , Kuniyuki Iwashima , Martin KaFai Lau , Alexander Mikhalitsyn , Breno Leitao , David Howells , Jason Xing , Xin Long , Michal Hocko , Alexei Starovoitov , open list , "open list:NETWORKING [GENERAL]" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: yh6w4bcqww3yhi4n1uujkgqkhe4cepk1 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 379541C000B X-HE-Tag: 1689843456-595648 X-HE-Meta: U2FsdGVkX1+KfuzRBF1SyjQsK6d9DS03XXhS5np+oJi/Av7xF6T5lZkSq6h2AeA5asIRtPFCRVTtCQTniz8W1pd9uEPO+P3K/tIxS8QDFGYe8ucdAi/XJ+wr/bqiT1Ui6icWxRV2f6PkE0JnAnLNH5ySKHRMpAcXOG1sYzwjf3vXPii7QyLrgmbDzmHrM+mJLAR+viUvAaC2E51SjFl7sEyNIHfYUZaMLmoAifJ8YGN84LJ0r51z9pvp6Sv0EVOY+M2h060ovcfIylkisml0mvuDq4pthrx6vGSdOk4kj/mItVDtwJL1pFmkz16lHQiZLDvez1rlub4m/tjcDpolbLgfhnWOG5q/v90N1ZomP9A90ue5GxvaD4QVtuC/cHYX08qUDCTcljktdeXaZuzuUk2PdVicOzzQ+mSwuuwUuDGGSfdtVIemPjY8hqlDcYyw2gn6EYt37UbOZQMlDFa1owBtz7R3LA0UcuACTbgVlNImmGcOdnZXWQGlya+X1PnhXIejGuRpe3QN47V7kXk/3LgFXgxD613lQidSwiGLdbGJkT6RVmPifPQpHu1vCK+FZ6Iw38vvMNrsjSRDt1FZp642OavK/mVO/QY+Jl8FRiIi8kj7tm/hmQNRHW+RZUELSfhFuPNtEi1r4RvfsQYJ5yyVlZh3v8lCKNCsVv5XbAOSUXEyJkaFLTfvx93usUVUyA4mQJTFKxdYSQ6Sg9hCucIss4m/usiICqdcCG6Yn6oAotwWpNqLna27TVg3xXOP7EIeZxhxNWNYTgKPHXGOVmDEIOdxzj+b3xHiHNDF7zFpsFuCUxzRrL2wgXqHjx8HlS4UiHpdkuFYhOvZGOShYfi7yajkG9ZYaq8Tdi5tT5dDTsdk6NonYnchiB1xIYOeQpfSPY2FZ0dPg/+sFZRkoPxGdzjFPeT3CoskDYZw4eOKmd9RvbkrPeoW3OLqE52KgOI47RcUc98zhqfOgSv fDCcZkZt +5VjWCjGuustWA69dwkObkjfH25OApPgZ4Ob0ifem7f5N0emriDzED31w+4bhJe6SG3FSzotwf9kFxuhGHv0IW5uh2DS+r20G2c7SM+EDDs7DMihb6YrJH5FsjSr6/Zlhmf6IlScTjUlgsEzwyCfJG2h01+1h/L+mhBTxmsueb9nKBk5lzuwMAx85f7gjzoRKmHIuPwhrhkJgDqZvH7hLAGeB05Fw4uDuRx1sLDa4Zo6yziPcX4wvfnQcYMsGA5k8erhLW3j7OOcHfab6ajXYAI1QQBKu/Z1Tctwp5pbtdniLDJkBqy/7Kmcqh70Pa2J611U1QhrZbf5vAHFy3y7meXQbqSC8zYepANfDvb5cBVLPj1s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 20, 2023 at 9:59=E2=80=AFAM Abel Wu = wrote: > > Gentle ping :) I was hoping for some feedback from memcg experts. You claim to fix a bug, please provide a Fixes: tag so that we can involve original patch author. Thanks. > > On 7/11/23 8:41 PM, Abel Wu wrote: > > Now there are two indicators of socket memory pressure sit inside > > struct mem_cgroup, socket_pressure and tcpmem_pressure. > > > > When in legacy mode aka. cgroupv1, the socket memory is charged > > into a separate counter memcg->tcpmem rather than ->memory, so > > the reclaim pressure of the memcg has nothing to do with socket's > > pressure at all. While for default mode, the ->tcpmem is simply > > not used. > > > > So {socket,tcpmem}_pressure are only used in default/legacy mode > > respectively. This patch fixes the pieces of code that make mixed > > use of both. > > > > Signed-off-by: Abel Wu > > --- > > include/linux/memcontrol.h | 4 ++-- > > mm/vmpressure.c | 8 ++++++++ > > 2 files changed, 10 insertions(+), 2 deletions(-) > >