From: Eric Dumazet <edumazet@google.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: David Rientjes <rientjes@google.com>,
Vlastimil Babka <vbabka@suse.cz>, Shaohua Li <shli@fb.com>,
netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
kernel-team <Kernel-team@fb.com>,
clm@fb.com, linux-mm@kvack.org, dbavatar@gmail.com
Subject: Re: [RFC V3] net: don't wait for order-3 page allocation
Date: Thu, 18 Jun 2015 07:35:53 -0700 [thread overview]
Message-ID: <CANn89iLr2iNV3VjA4POPpfsmOpyB7jP2-wPiAkCOcA+Oh+2=5A@mail.gmail.com> (raw)
In-Reply-To: <20150618143019.GE5858@dhcp22.suse.cz>
On Thu, Jun 18, 2015 at 7:30 AM, Michal Hocko <mhocko@suse.cz> wrote:
> Abusing __GFP_NO_KSWAPD is a wrong way to go IMHO. It is true that the
> _current_ implementation of the allocator has this nasty and very subtle
> side effect but that doesn't mean it should be abused outside of the mm
> proper. Why shouldn't this path wake the kswapd and let it compact
> memory on the background to increase the success rate for the later
> high order allocations?
I kind of agree.
If kswapd is a problem (is it ???) we should fix it, instead of adding
yet another flag to some random locations attempting
memory allocations.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-06-18 14:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 23:50 [RFC V3] net: don't wait for order-3 page allocation Shaohua Li
2015-06-12 0:02 ` Eric Dumazet
2015-06-12 0:34 ` David Miller
2015-06-12 9:36 ` Vlastimil Babka
2015-06-17 23:02 ` David Rientjes
2015-06-18 14:30 ` Michal Hocko
2015-06-18 14:35 ` Eric Dumazet [this message]
2015-06-18 14:43 ` Michal Hocko
2015-06-18 15:22 ` Vlastimil Babka
2015-06-18 15:47 ` Michal Hocko
2015-06-30 23:49 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iLr2iNV3VjA4POPpfsmOpyB7jP2-wPiAkCOcA+Oh+2=5A@mail.gmail.com' \
--to=edumazet@google.com \
--cc=Kernel-team@fb.com \
--cc=clm@fb.com \
--cc=davem@davemloft.net \
--cc=dbavatar@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=rientjes@google.com \
--cc=shli@fb.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).