From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADD2ECCA47C for ; Tue, 12 Jul 2022 14:17:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49B7A940090; Tue, 12 Jul 2022 10:17:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 44BA0940063; Tue, 12 Jul 2022 10:17:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31448940090; Tue, 12 Jul 2022 10:17:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 19DEC940063 for ; Tue, 12 Jul 2022 10:17:47 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id E2EF3120D42 for ; Tue, 12 Jul 2022 14:17:46 +0000 (UTC) X-FDA: 79678651332.22.8013388 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf04.hostedemail.com (Postfix) with ESMTP id 79C874003A for ; Tue, 12 Jul 2022 14:17:46 +0000 (UTC) Received: by mail-yb1-f182.google.com with SMTP id h62so11528499ybb.11 for ; Tue, 12 Jul 2022 07:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0beGq21p9DMXHd5s7bgYgiKqbqbtLOLYpdLEVtFVxzo=; b=KBfwn0NWRdjlAlnm78kQy8tetaYreiz77Y8pUuEWWPugZUbjxhRgenJK2m1SIRjBig WMpwQ5rhXusyEyDymAjbbkawtqCvFm7xCLlF24E/B+FQliXAm1mJ77+1o4i237SN+NMN Hx5kOvVfRfNj30L4FQMs8HZogW1F2ihS9IueY+v3NX5G9p0aa44btudBP14q3xqsSzph IOrltwO6HwRBj4o/XG4KdQQ2/LOdOyG8sjW56dapWE/365fz6RBtrO1aaLpIiNRs7Gif BBkEQanbqIrKeVJSno+7AsR2RNBYnu+6Mhg+P7/4kVSIt9CQuQnT5CAXTAx/Y5e5kKGN abpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0beGq21p9DMXHd5s7bgYgiKqbqbtLOLYpdLEVtFVxzo=; b=S/vfqL7GykubEuUOnuvLUVPoE5gowvY2PDwMqBzFbwltZzavsJuJLzpRLEfk9sH/Mz n0N8q2MhuRWqatbH5KGLscR7MBVDT8hIPX5+mWIg/EL1Qq1FkS03WVklmUL32lo5zKmL D2ygWs/K3lijzEp1ymHMeEv+W/FhDzapCuDMumJCPaOpGdzEbrcPJR2NBhcu+bATLTDB ZMHWJt00Y+zwwIsXHhBdfJLsfeFfqyQLb2ptB2rvcU7EcOJJkFmyHYZQgGo9c0DD9BBU bbKOAhCKxiQs7MV0Ss5XeJ2nKKLoDyZCKT8C+/Rz+qHQ5qvDvLnAI2eAYK39Kf4Ra5+f JbyA== X-Gm-Message-State: AJIora/ay8tCHhuLNt+3px8JDkPI9QGZgDCeSKOPIWvdOKbKTZ6Gklt9 uk2gbAMS6yp9PmdcFewBWFdSO2kM+lsQyfkH6FhgTQ== X-Google-Smtp-Source: AGRyM1uNJbYAzJEiHCz+WeojPCu0/5uwt/JdhiaRhEpRyhDjN0kKwSV2YWGVhXee1UxvoNMcsabuiAL8+o0CcFARhhk= X-Received: by 2002:a25:2d59:0:b0:66e:32d3:7653 with SMTP id s25-20020a252d59000000b0066e32d37653mr22600223ybe.625.1657635465536; Tue, 12 Jul 2022 07:17:45 -0700 (PDT) MIME-Version: 1.0 References: <20220701142310.2188015-1-glider@google.com> <20220701142310.2188015-6-glider@google.com> In-Reply-To: <20220701142310.2188015-6-glider@google.com> From: Marco Elver Date: Tue, 12 Jul 2022 16:17:09 +0200 Message-ID: Subject: Re: [PATCH v4 05/45] asm-generic: instrument usercopy in cacheflush.h To: Alexander Potapenko Cc: Alexander Viro , Alexei Starovoitov , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657635466; a=rsa-sha256; cv=none; b=i3PcdaP+DfjuexIH6sSsk07pKgRMQ84pU58GqQF1qbpdhOtBbri6c7+OpdRcTOTYyuj8JU 5Nix5XWE1EQ5VCXSCvvrceh94t7Wo5QLR3agoCVNNRDdBCIx1wHp4SaIHrJVb7tc9ybRFi d23Kit96NUInlUS8amvCuDevy/TrRww= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=KBfwn0NW; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of elver@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657635466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0beGq21p9DMXHd5s7bgYgiKqbqbtLOLYpdLEVtFVxzo=; b=QVqezBmkyjLgTIYImJcX9Wn8QQb/whB/gezDoUVM1ROUdok8hi0jhVAEqUZdHssiHn8s2J 4RlWvSjgwBzkF6yEJam83pEtViJi+SQy9w/lVpN0Y9X7vW9bB8gokLLQQ/dV4gmeWaGZl9 mTEMO+hYfIjXg3WkFovK4Upr5Y7wRRE= X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 79C874003A Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=KBfwn0NW; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of elver@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=elver@google.com X-Stat-Signature: a61q8tixazteg4qz4i8wdrue8hugr5bp X-Rspam-User: X-HE-Tag: 1657635466-159888 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 1 Jul 2022 at 16:23, Alexander Potapenko wrote: > > Notify memory tools about usercopy events in copy_to_user_page() and > copy_from_user_page(). > > Signed-off-by: Alexander Potapenko Reviewed-by: Marco Elver > --- > Link: https://linux-review.googlesource.com/id/Ic1ee8da1886325f46ad67f52176f48c2c836c48f > --- > include/asm-generic/cacheflush.h | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/include/asm-generic/cacheflush.h b/include/asm-generic/cacheflush.h > index 4f07afacbc239..0f63eb325025f 100644 > --- a/include/asm-generic/cacheflush.h > +++ b/include/asm-generic/cacheflush.h > @@ -2,6 +2,8 @@ > #ifndef _ASM_GENERIC_CACHEFLUSH_H > #define _ASM_GENERIC_CACHEFLUSH_H > > +#include > + > struct mm_struct; > struct vm_area_struct; > struct page; > @@ -105,6 +107,7 @@ static inline void flush_cache_vunmap(unsigned long start, unsigned long end) > #ifndef copy_to_user_page > #define copy_to_user_page(vma, page, vaddr, dst, src, len) \ > do { \ > + instrument_copy_to_user(dst, src, len); \ > memcpy(dst, src, len); \ > flush_icache_user_page(vma, page, vaddr, len); \ > } while (0) > @@ -112,7 +115,11 @@ static inline void flush_cache_vunmap(unsigned long start, unsigned long end) > > #ifndef copy_from_user_page > #define copy_from_user_page(vma, page, vaddr, dst, src, len) \ > - memcpy(dst, src, len) > + do { \ > + instrument_copy_from_user_before(dst, src, len); \ > + memcpy(dst, src, len); \ > + instrument_copy_from_user_after(dst, src, len, 0); \ > + } while (0) > #endif > > #endif /* _ASM_GENERIC_CACHEFLUSH_H */ > -- > 2.37.0.rc0.161.g10f37bed90-goog >