linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Marco Elver <elver@google.com>
To: Alexander Potapenko <glider@google.com>
Cc: akpm@linux-foundation.org, dvyukov@google.com,
	 linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] kfence: skip DMA allocations
Date: Tue, 29 Jun 2021 15:05:00 +0200	[thread overview]
Message-ID: <CANpmjNN35j2Sf17TMqpOVZZv2N6ELzBZOsG5-jpFoPvgfuVzFA@mail.gmail.com> (raw)
In-Reply-To: <20210629130048.820142-1-glider@google.com>

On Tue, 29 Jun 2021 at 15:00, Alexander Potapenko <glider@google.com> wrote:
[...]
> +       /*
> +        * Skip DMA allocations. These must reside in the low memory, which we
> +        * cannot guarantee.
> +        */
> +       if (flags & (__GFP_DMA | __GFP_DMA32) ||

I think we want braces around "flags & (...)", so that this becomes:

    if ((flags & (...)) ||

> +           (s->flags & (SLAB_CACHE_DMA | SLAB_CACHE_DMA32)))
> +               return NULL;

Thanks,
-- Marco


      reply	other threads:[~2021-06-29 13:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29 13:00 [PATCH] kfence: skip DMA allocations Alexander Potapenko
2021-06-29 13:05 ` Marco Elver [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANpmjNN35j2Sf17TMqpOVZZv2N6ELzBZOsG5-jpFoPvgfuVzFA@mail.gmail.com \
    --to=elver@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).