From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A78BC11F66 for ; Tue, 29 Jun 2021 13:05:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 33C9B61DC2 for ; Tue, 29 Jun 2021 13:05:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33C9B61DC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 610856B009A; Tue, 29 Jun 2021 09:05:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C0706B009C; Tue, 29 Jun 2021 09:05:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43A758D00F0; Tue, 29 Jun 2021 09:05:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0245.hostedemail.com [216.40.44.245]) by kanga.kvack.org (Postfix) with ESMTP id 222CC6B009A for ; Tue, 29 Jun 2021 09:05:14 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EAD141EA35 for ; Tue, 29 Jun 2021 13:05:13 +0000 (UTC) X-FDA: 78306782106.40.03834EB Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) by imf15.hostedemail.com (Postfix) with ESMTP id 9DEDAD00008F for ; Tue, 29 Jun 2021 13:05:13 +0000 (UTC) Received: by mail-oi1-f177.google.com with SMTP id 11so18006132oid.3 for ; Tue, 29 Jun 2021 06:05:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AEV/WRF0Y0ujX/WfxQA0NcsIjvbaet/AXkvfL06Fxro=; b=Fu7/abfpV6kGILaO1P8/3DbMiuH5lUgY6AXOOuHwB9qMXmA6bB2cxMLthLx6wCwyd8 I8BTv7O1FzKvqYDTWbMO2hHn7ztrhhm5vjk6VSDIDR+zjwosu4eZ0+mx3sm4KLPgPj6C D8PlzwaEte7Tt3Y0zVmLOBdcF7jKLL9Kajy6L2MWft4T0zAbXP2gvdytbmigqkk38KE4 i7t9t26AsiaRZTsUkznZ9O+SwA2TTX6fyBdAQI+wgDg/hqD8g1mEFCTVVMYOgrNYvq/2 IMtZoPb0mSSe4OZGg5UjNVsMcs4uKEE5vQlmJdNKUhc/WcKEHt13MBAQXZSA6h8u/wiG oiAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AEV/WRF0Y0ujX/WfxQA0NcsIjvbaet/AXkvfL06Fxro=; b=R7m8qjL3XMP2qqgEaIdrHqtylxqb3+8bGT3nF+ao7CNSd240saW64k8Z8juIgQfwPa lO0csJ6UTMh8QgVbpZGQoRbNmS1HYSMieSwT2JvL7PjHY2VsHH2FU5zlRaM0eH9t+x9t 3YYbliAbUFebdeLpbtUwdRDAXkXhvRrxcz/lRswiWwAH5PVCo/YolDknImjM5pLfk1oG F4U8hG5TascAzCzIGtyVSzBCvZD6kFEGfNueNgtKNCOazUBEREYESuSdxU4AHy0oIev4 XFAhgXaCkYVGl7nrANnFAGXxvdBthE6OwwZtQDuvhsAXDqP9Orxln6dYR18qKEgnxsOd YOSA== X-Gm-Message-State: AOAM530Oa5eArqt/SEHhclN2lOElRFvG6Bj+xJl2MxMqVihwFiMFVdFj /w42RXRi/Ry98xj65wihhQkz63LF1nEabyx6w6GKiQ== X-Google-Smtp-Source: ABdhPJwn6TCJ6i41XF6zt8tugLcu+tQNibbvlhwV6CqK+CCWRGK+s7Fb13zbr/iDARVi/nPlFWoR/Mdn8UsLbL2H+M4= X-Received: by 2002:a05:6808:bd5:: with SMTP id o21mr21256488oik.172.1624971912663; Tue, 29 Jun 2021 06:05:12 -0700 (PDT) MIME-Version: 1.0 References: <20210629130048.820142-1-glider@google.com> In-Reply-To: <20210629130048.820142-1-glider@google.com> From: Marco Elver Date: Tue, 29 Jun 2021 15:05:00 +0200 Message-ID: Subject: Re: [PATCH] kfence: skip DMA allocations To: Alexander Potapenko Cc: akpm@linux-foundation.org, dvyukov@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9DEDAD00008F Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b="Fu7/abfp"; spf=pass (imf15.hostedemail.com: domain of elver@google.com designates 209.85.167.177 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: eu9g75qe76cwx5c3cixfytqns3i3tizo X-HE-Tag: 1624971913-970692 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002781, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 29 Jun 2021 at 15:00, Alexander Potapenko wrote: [...] > + /* > + * Skip DMA allocations. These must reside in the low memory, which we > + * cannot guarantee. > + */ > + if (flags & (__GFP_DMA | __GFP_DMA32) || I think we want braces around "flags & (...)", so that this becomes: if ((flags & (...)) || > + (s->flags & (SLAB_CACHE_DMA | SLAB_CACHE_DMA32))) > + return NULL; Thanks, -- Marco