From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E1B0C433DB for ; Tue, 2 Feb 2021 17:39:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3F35C64F4D for ; Tue, 2 Feb 2021 17:39:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F35C64F4D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B18B56B0005; Tue, 2 Feb 2021 12:39:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC81B6B0006; Tue, 2 Feb 2021 12:39:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B6966B0070; Tue, 2 Feb 2021 12:39:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id 825AC6B0005 for ; Tue, 2 Feb 2021 12:39:48 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4729B1EE6 for ; Tue, 2 Feb 2021 17:39:48 +0000 (UTC) X-FDA: 77774040456.20.box82_5a0846c275cc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 14736180C07AB for ; Tue, 2 Feb 2021 17:39:48 +0000 (UTC) X-HE-Tag: box82_5a0846c275cc X-Filterd-Recvd-Size: 5385 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Feb 2021 17:39:47 +0000 (UTC) Received: by mail-ot1-f50.google.com with SMTP id d7so20647382otf.3 for ; Tue, 02 Feb 2021 09:39:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BII6X9VkkCmC/J7Ey1mCa41oEbJr520MWQnzH5Xhv9Q=; b=PXjuYV0cOp+567jMKpyOOYrjzFrmMQhpSsf4yKEj5lgebN6BPUEB3mV0so6yLmEjZ/ pYQR5Gdmou19gzOoWJ02cuLckRr52qZxtZuUgRJb4FaJNr+sge515wPZqkQl0ntQoqDy 2I1jXVcIZ27bOU7BTbY6PRYYi1TfDbC0AuCrtCI9cQAk2pNS+CZhFBl5ydKPDMl1MctF DxR5LaBQwSAWdWblKfK9QJV/mQWpWk6jfKfqi+VILWUVP/kqmv33gByUpZDlWHRHmeyC CO9qGnyidze/4GQnX95hyvKsKOGzcWqlqmanJw08OXhM9+d+0EPazBulZoC2p6BQfprs rVcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BII6X9VkkCmC/J7Ey1mCa41oEbJr520MWQnzH5Xhv9Q=; b=JEY+B5uBw3Xq1wgg/vR1QCNqH9RlS5pAf6ocL8OaHQd2I/Shf2F45qGRnyfa2GFKNz 67wfFtATDQ2Cqy5+10bCQDWIhDbC47aqn2uNgx6drUbOZ3diD1/qalpxEWrVGjkeAl5g kaj6rhOukbtqYguFlzHRtosQcwPPE+a3fGZqUO3LRunzW+aY3h45E18OAeXrT1V0EbgJ xXXIkhiZDItH3srS+MOMaQx1c0BDudFL2sI0XggVH3ZkRLEPw3Qb6h7XahE9HwiQN8W4 4Dag1DREnsup6lMdB0ypjauBCTNhJl5og6xhj9M+FBCIgbyhhyKGrfK1Gl7Pcm9jBjWR c7GA== X-Gm-Message-State: AOAM532RWv5GeVi4nDc/aPo0xfWTUX/PJguAhmb5yCRZ2fIGQWLe00TP d/tMKjuLF+EvFa7O8rjvRr4LSM4zuZko1wIXCoOVHw== X-Google-Smtp-Source: ABdhPJyR3YEZ4MxJTnMrgfDlYCaQYg+zdfO3gVmBuM9e5QmzuE0U8HFwQZS9QkNvG8speGBODgcWI+2jh8ltkuDl1Fo= X-Received: by 2002:a9d:4687:: with SMTP id z7mr16664460ote.233.1612287586711; Tue, 02 Feb 2021 09:39:46 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Marco Elver Date: Tue, 2 Feb 2021 18:39:35 +0100 Message-ID: Subject: Re: [PATCH 02/12] kasan, mm: optimize kmalloc poisoning To: Andrey Konovalov Cc: Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Andrew Morton , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2 Feb 2021 at 18:16, Andrey Konovalov wrote: > > On Tue, Feb 2, 2021 at 5:25 PM Marco Elver wrote: > > > > > +#ifdef CONFIG_KASAN_GENERIC > > > + > > > +/** > > > + * kasan_poison_last_granule - mark the last granule of the memory range as > > > + * unaccessible > > > + * @addr - range start address, must be aligned to KASAN_GRANULE_SIZE > > > + * @size - range size > > > + * > > > + * This function is only available for the generic mode, as it's the only mode > > > + * that has partially poisoned memory granules. > > > + */ > > > +void kasan_poison_last_granule(const void *address, size_t size); > > > + > > > +#else /* CONFIG_KASAN_GENERIC */ > > > + > > > +static inline void kasan_poison_last_granule(const void *address, size_t size) { } > > ^ > > > > + > > > +#endif /* CONFIG_KASAN_GENERIC */ > > > + > > > /* > > > * Exported functions for interfaces called from assembly or from generated > > > * code. Declarations here to avoid warning about missing declarations. > > > > @@ -96,6 +92,16 @@ void kasan_poison(const void *address, size_t size, u8 value) > > > } > > > EXPORT_SYMBOL(kasan_poison); > > > > > > +#ifdef CONFIG_KASAN_GENERIC > > > +void kasan_poison_last_granule(const void *address, size_t size) > > > +{ > > > + if (size & KASAN_GRANULE_MASK) { > > > + u8 *shadow = (u8 *)kasan_mem_to_shadow(address + size); > > > + *shadow = size & KASAN_GRANULE_MASK; > > > + } > > > +} > > > +#endif > > > > The function declaration still needs to exist in the dead branch if > > !IS_ENABLED(CONFIG_KASAN_GENERIC). It appears in that case it's declared > > (in kasan.h), but not defined. We shouldn't get linker errors because > > the optimizer should remove the dead branch. Nevertheless, is this code > > generally acceptable? > > The function is defined as empty when !CONFIG_KASAN_GENERIC, see above. I missed that, thanks. Reviewed-by: Marco Elver