From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3817CC433F5 for ; Tue, 8 Feb 2022 13:39:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A13156B007B; Tue, 8 Feb 2022 08:39:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C1E26B007D; Tue, 8 Feb 2022 08:39:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B19E6B007E; Tue, 8 Feb 2022 08:39:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 7CD186B007B for ; Tue, 8 Feb 2022 08:39:18 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 24BF0606EE for ; Tue, 8 Feb 2022 13:39:18 +0000 (UTC) X-FDA: 79119719196.01.A82B765 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf16.hostedemail.com (Postfix) with ESMTP id C10FB180004 for ; Tue, 8 Feb 2022 13:39:17 +0000 (UTC) Received: by mail-yb1-f182.google.com with SMTP id g14so49811621ybs.8 for ; Tue, 08 Feb 2022 05:39:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jkWKVFY9Ane+4hLx7KO8wJLB4fAu322gdHrEZT3DJhA=; b=roCaBezV/DQ17i+sXf/6XpzD0kL3lOx0tmGDYIQeLnFfebE+ICp2HRuPG2IM2OTZ6U oxUfMDdFvyCgHJWd07HTyS796Uu/Xb40/dqYd0h2UgrG0FDL1UEWaTPpvJ+Bn0XaXkHW z79H5Oz0JfkFDiomzRoZug3tTey8JUBGRcKGzeViKw8Cn2IbxzfPPkbBrupntOFHryUy phoG8jGtTaisDjxtJW0duvFMpIYU1ydx+KE98ezaImPdL2JSEInpLxYQuhlKF1ncpz/y L/DKbzp03/UiCgOARSWW+guLsK9dx4vi8Jfi3cq1N+i6yudIQC4v9hq8A+N0imsmrdkg ZDTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jkWKVFY9Ane+4hLx7KO8wJLB4fAu322gdHrEZT3DJhA=; b=vRJRPMIhGPcKS0NNqk4pW0ql8uGNQeqAEtpMoQgWA7XfkdAOz8Umu5rEFg7sIrSE7c LVosUATogBmQcZ6xSzJpQPTa66T7MNVEkIpARo1kfJWqr9ET72KpNgA7NGnhKG1fQgJH c2GwxY2GgMnR60B6+KoY4YkJcrsqNpsdElVvSnAgFpenud+En15CkV/COR8CKG3T5jXS SuSp6f/Ify8o66LznZ6Vvtbcqxg4jthKpZDaFOdgX0htNHtfQDRFFPt1W+y6Tv5cfTIy ENz8fpx4wx2koAvj35H+vfglK7zIHDTn7XydMzq/ob4ckk0TJHDEU0CR4z4op8RzgprC YqFw== X-Gm-Message-State: AOAM533n/TBNTfRfF7Gwbvm++594XtFG/PCDOe8AT9CHqgm3fRh87Yln fAjW+JXk2eh8ffVfxPBTXOyYB1ymdxZaJRQT9rU5lg== X-Google-Smtp-Source: ABdhPJxVPX7eETUkWHJHX+qRDcXXalcx4ypoqmAMKW5Ugv2G+t/qfCIMALqgvBuTV9JQ7+kf/GBhkFyc36+EodIy1rk= X-Received: by 2002:a81:1153:: with SMTP id 80mr4667357ywr.327.1644327556844; Tue, 08 Feb 2022 05:39:16 -0800 (PST) MIME-Version: 1.0 References: <1644324666-15947-1-git-send-email-yangtiezhu@loongson.cn> <1644324666-15947-5-git-send-email-yangtiezhu@loongson.cn> In-Reply-To: <1644324666-15947-5-git-send-email-yangtiezhu@loongson.cn> From: Marco Elver Date: Tue, 8 Feb 2022 14:39:05 +0100 Message-ID: Subject: Re: [PATCH v2 4/5] ubsan: no need to unset panic_on_warn in ubsan_epilogue() To: Tiezhu Yang Cc: Baoquan He , Jonathan Corbet , Andrew Morton , Andrey Ryabinin , Xuefeng Li , kexec@lists.infradead.org, linux-doc@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=roCaBezV; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of elver@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=elver@google.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C10FB180004 X-Stat-Signature: 5qqiwnr63dusi6my63csury9eje3yqdg X-HE-Tag: 1644327557-764356 X-Bogosity: Ham, tests=bogofilter, spamicity=0.021418, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 8 Feb 2022 at 13:51, Tiezhu Yang wrote: > > panic_on_warn is unset inside panic(), so no need to unset it > before calling panic() in ubsan_epilogue(). > > Signed-off-by: Tiezhu Yang Reviewed-by: Marco Elver > --- > lib/ubsan.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/lib/ubsan.c b/lib/ubsan.c > index bdc380f..36bd75e 100644 > --- a/lib/ubsan.c > +++ b/lib/ubsan.c > @@ -154,16 +154,8 @@ static void ubsan_epilogue(void) > > current->in_ubsan--; > > - if (panic_on_warn) { > - /* > - * This thread may hit another WARN() in the panic path. > - * Resetting this prevents additional WARN() from panicking the > - * system on this thread. Other threads are blocked by the > - * panic_mutex in panic(). > - */ > - panic_on_warn = 0; > + if (panic_on_warn) > panic("panic_on_warn set ...\n"); > - } > } > > void __ubsan_handle_divrem_overflow(void *_data, void *lhs, void *rhs) > -- > 2.1.0 > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/1644324666-15947-5-git-send-email-yangtiezhu%40loongson.cn.