From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E7C5C433FE for ; Fri, 28 Jan 2022 09:49:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2A756B0071; Fri, 28 Jan 2022 04:49:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BDA686B0072; Fri, 28 Jan 2022 04:49:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA1E46B0073; Fri, 28 Jan 2022 04:49:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0051.hostedemail.com [216.40.44.51]) by kanga.kvack.org (Postfix) with ESMTP id 9A0B26B0071 for ; Fri, 28 Jan 2022 04:49:48 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 50D198D8EC for ; Fri, 28 Jan 2022 09:49:48 +0000 (UTC) X-FDA: 79079224056.17.FA2D97D Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by imf31.hostedemail.com (Postfix) with ESMTP id A262D20012 for ; Fri, 28 Jan 2022 09:49:47 +0000 (UTC) Received: by mail-oi1-f173.google.com with SMTP id q186so11303973oih.8 for ; Fri, 28 Jan 2022 01:49:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KD2MpvTo6d8AcZYWRzGbZANNSm7u8StOzxLlvpWuXTM=; b=FQzQLz7w2uSqyOzFrdxgHPBSvl26iWOThEOJaHmMYuIVXnVQEgZKxZ5U4FWsJLPY0S X4XEZ3XJtyt2Hk0VsyZfdJ30dA7SvjN3AZ6QJ5l2DCpTYfQZdDb00FoHJas4xqHE0lRE 0aOu4PtW8jL1ggLGdgMydU0uN8yXsBv5qOCviu2tDu4MBCNuiYhhW2oNdiW+QnjMy/jj n0QqnYbHvV7RJUVwZjDX/6vTmFpoGsgkRhHiXwqRvFc9HrnyEWmxuljZgaze8tC1AAWV PphyuKKG98JeSBtMcyM/5mPLxi2zPXe7nksv2nZa2qvYzpBK/MYoW2Y1GSzKRDWMxGWk itVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KD2MpvTo6d8AcZYWRzGbZANNSm7u8StOzxLlvpWuXTM=; b=Us22PifFHSoQSpK2ompCw02UpHcjttg3jcB0EyAhkFv/xgYnBZ5mF5VGGbK0NFHJbJ DbBk2K9wW67austNKhLd1gc2aDvYFCHa2KPh272ark7rn9ErlEhppYf12Pt+DARsYKA2 JguotKKd2tZuxksqZrTLxYhIaziTeIoBzHyHQ162Aa+zto+irbVQu73TYCB/vn0oedNm 30yBaX9qGhYHUAMgWvoghWUUUn9ACVp3iAc22OORmYOiFQKqu0GljuJCSZRn9+NpF+Vy uur/hB3rPHY2bgiBibj6+Tc4QmpdNSfU1BvjkNWDQIPcFP4fDQKMyvHgzMCaBzhHDy0V y3hw== X-Gm-Message-State: AOAM533WddvQX0jFuMtaHgTr90RvhCMwIRx7mJ2sfwmMgNOjREibGpNZ DsC+T93+PqSbFlyUqKaoO3YB7COHYvs1FnETIKOsaA== X-Google-Smtp-Source: ABdhPJxKbcqfZUb1crg7oqDeoxOAlqqsIMh8sFoswaBdoHmg/9J3J8aMcSu3WBha2OvAdhq+y7Y7sjYIrLFdQDgLj1w= X-Received: by 2002:a05:6808:1901:: with SMTP id bf1mr5020470oib.197.1643363386387; Fri, 28 Jan 2022 01:49:46 -0800 (PST) MIME-Version: 1.0 References: <20220128015752.931256-1-liupeng256@huawei.com> In-Reply-To: <20220128015752.931256-1-liupeng256@huawei.com> From: Marco Elver Date: Fri, 28 Jan 2022 10:49:34 +0100 Message-ID: Subject: Re: [PATCH v2] kfence: Make test case compatible with run time set sample interval To: Peng Liu Cc: glider@google.com, dvyukov@google.com, corbet@lwn.net, sumit.semwal@linaro.org, christian.koenig@amd.com, akpm@linux-foundation.org, kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A262D20012 X-Stat-Signature: m7ag9xumcqmktt563utth4bn4uapeasz X-Rspam-User: nil Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=FQzQLz7w; spf=pass (imf31.hostedemail.com: domain of elver@google.com designates 209.85.167.173 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1643363387-100168 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 28 Jan 2022 at 02:41, Peng Liu wrote: > The parameter kfence_sample_interval can be set via boot parameter > and late shell command, which is convenient for automatical tests s/automatical/automated/ > and KFENCE parameter optimation. However, KFENCE test case just use s/optimation/optimization/ > compile time CONFIG_KFENCE_SAMPLE_INTERVAL, this will make KFENCE > test case not run as user desired. This patch will make KFENCE test > case compatible with run-time-set sample interval. I'm not too particular about it, but "This patch" is usually bad style: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes > v1->v2: > - Use EXPORT_SYMBOL_GPL replace EXPORT_SYMBOL Changelog is usually placed after '---', because it's mostly redundant once committed. Often maintainers include a "Link" to the original patch which then has history and discussion. > Signed-off-by: Peng Liu Reviewed-by: Marco Elver > --- > include/linux/kfence.h | 2 ++ > mm/kfence/core.c | 3 ++- > mm/kfence/kfence_test.c | 8 ++++---- > 3 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/include/linux/kfence.h b/include/linux/kfence.h > index 4b5e3679a72c..f49e64222628 100644 > --- a/include/linux/kfence.h > +++ b/include/linux/kfence.h > @@ -17,6 +17,8 @@ > #include > #include > > +extern unsigned long kfence_sample_interval; > + > /* > * We allocate an even number of pages, as it simplifies calculations to map > * address to metadata indices; effectively, the very first page serves as an > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > index 5ad40e3add45..13128fa13062 100644 > --- a/mm/kfence/core.c > +++ b/mm/kfence/core.c > @@ -47,7 +47,8 @@ > > static bool kfence_enabled __read_mostly; > > -static unsigned long kfence_sample_interval __read_mostly = CONFIG_KFENCE_SAMPLE_INTERVAL; > +unsigned long kfence_sample_interval __read_mostly = CONFIG_KFENCE_SAMPLE_INTERVAL; > +EXPORT_SYMBOL_GPL(kfence_sample_interval); /* Export for test modules. */ > > #ifdef MODULE_PARAM_PREFIX > #undef MODULE_PARAM_PREFIX > diff --git a/mm/kfence/kfence_test.c b/mm/kfence/kfence_test.c > index a22b1af85577..50dbb815a2a8 100644 > --- a/mm/kfence/kfence_test.c > +++ b/mm/kfence/kfence_test.c > @@ -268,13 +268,13 @@ static void *test_alloc(struct kunit *test, size_t size, gfp_t gfp, enum allocat > * 100x the sample interval should be more than enough to ensure we get > * a KFENCE allocation eventually. > */ > - timeout = jiffies + msecs_to_jiffies(100 * CONFIG_KFENCE_SAMPLE_INTERVAL); > + timeout = jiffies + msecs_to_jiffies(100 * kfence_sample_interval); > /* > * Especially for non-preemption kernels, ensure the allocation-gate > * timer can catch up: after @resched_after, every failed allocation > * attempt yields, to ensure the allocation-gate timer is scheduled. > */ > - resched_after = jiffies + msecs_to_jiffies(CONFIG_KFENCE_SAMPLE_INTERVAL); > + resched_after = jiffies + msecs_to_jiffies(kfence_sample_interval); > do { > if (test_cache) > alloc = kmem_cache_alloc(test_cache, gfp); > @@ -608,7 +608,7 @@ static void test_gfpzero(struct kunit *test) > int i; > > /* Skip if we think it'd take too long. */ > - KFENCE_TEST_REQUIRES(test, CONFIG_KFENCE_SAMPLE_INTERVAL <= 100); > + KFENCE_TEST_REQUIRES(test, kfence_sample_interval <= 100); > > setup_test_cache(test, size, 0, NULL); > buf1 = test_alloc(test, size, GFP_KERNEL, ALLOCATE_ANY); > @@ -739,7 +739,7 @@ static void test_memcache_alloc_bulk(struct kunit *test) > * 100x the sample interval should be more than enough to ensure we get > * a KFENCE allocation eventually. > */ > - timeout = jiffies + msecs_to_jiffies(100 * CONFIG_KFENCE_SAMPLE_INTERVAL); > + timeout = jiffies + msecs_to_jiffies(100 * kfence_sample_interval); > do { > void *objects[100]; > int i, num = kmem_cache_alloc_bulk(test_cache, GFP_ATOMIC, ARRAY_SIZE(objects), > -- > 2.18.0.huawei.25 >