From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 735AAC48BE5 for ; Wed, 16 Jun 2021 08:56:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 130DD60FD9 for ; Wed, 16 Jun 2021 08:56:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 130DD60FD9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8BAC66B006C; Wed, 16 Jun 2021 04:56:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 869246B006E; Wed, 16 Jun 2021 04:56:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E2446B0070; Wed, 16 Jun 2021 04:56:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id 39A0D6B006C for ; Wed, 16 Jun 2021 04:56:26 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D5242180AD807 for ; Wed, 16 Jun 2021 08:56:25 +0000 (UTC) X-FDA: 78258980730.36.C43D7D2 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by imf26.hostedemail.com (Postfix) with ESMTP id 90B034202A1E for ; Wed, 16 Jun 2021 08:56:19 +0000 (UTC) Received: by mail-ot1-f50.google.com with SMTP id w23-20020a9d5a970000b02903d0ef989477so1765049oth.9 for ; Wed, 16 Jun 2021 01:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PJLq/uYB/Lpm2G2R7d6L11/gd8MJ7X0dg2M/HcvVqks=; b=NWG0M7wK1B+f5XItaIWlh+tYoYNQuV5jfpb9Ms8V4ncGz2BkEq2JBNVQ8kLjlr5Oyv QFOmHlp9qLyw1zVVyqKwhLRGEDxH8qrO69Yk+0UeC0unPpocjWwkmPrPeam4haiRhm6f 0qlqrklsg0l/nH8iao/i4Y7SK9K/y3FO6yn/tvYfOsDfi14Ug+RRgO/UFVGZwbMNsQzg /pwBMO3TQ3qHmOAqQu/QmZV/t944xyOFB2lekcGL5fhUiIZsrhOqwVoprpwvTIf3clpO hgO9tY5G/Y5brlxH4fAcVtgtsNaPJYz+Bhw6AseVyu26kykHPfOBftVo8QW5wEUv3bSY d+XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PJLq/uYB/Lpm2G2R7d6L11/gd8MJ7X0dg2M/HcvVqks=; b=PICDjQd5Nn5g2B0h5tnEQVdJ/dihUvYMOyWtEoR1fo6af3iRhss3Ox30HMGXfIjXrO HMg/NQnskt8RitqRa/eBvwKYa6M3T8wvVCmKclcyoZzLY71ghoOV/y6p7DDGPFFxEfRo g+3A5G/NApPkqPJgDWcw8aSSjqNdezK25zBbWFLuUpOU6WVROnvWtzr+82vIB5FF+VOa a4OCnhpnBObaQ6sN9b+8AdYga9Qz6fP9wxctKgugfF7m9LeX74dQ9ljJxBBliGVQ6YYz WiX9XN0vwthKrauPb014qXAehvEqP312akImvucoJSHU+F6otb1KcRt6n7yWusm4v7W2 xnIg== X-Gm-Message-State: AOAM533UcRMMkCKEtUwfZDboHRSoZWFDWQztI+SJ9hajOQMxKiCrCziM DzTe/LNXT5BDyDd1qCeKSOeh7AJoeqmx0px9QrAt6A== X-Google-Smtp-Source: ABdhPJxN9SBqZNQQS2v2qUitNIUv6Mg0ImuOSr/ulbWLNw7NzsCtqZqbIN/jrGqOtYAAlifzBqfI7DBNWhje+6Eek0o= X-Received: by 2002:a05:6830:1bcb:: with SMTP id v11mr3196923ota.251.1623833784490; Wed, 16 Jun 2021 01:56:24 -0700 (PDT) MIME-Version: 1.0 References: <20210616080244.51236-1-dja@axtens.net> <20210616080244.51236-3-dja@axtens.net> In-Reply-To: <20210616080244.51236-3-dja@axtens.net> From: Marco Elver Date: Wed, 16 Jun 2021 10:56:11 +0200 Message-ID: Subject: Re: [PATCH v13 2/3] kasan: allow architectures to provide an outline readiness check To: Daniel Axtens Cc: LKML , Linux Memory Management List , kasan-dev , Andrew Morton , Andrey Konovalov , linuxppc-dev@lists.ozlabs.org, Christophe Leroy , aneesh.kumar@linux.ibm.com, Balbir Singh , "Aneesh Kumar K . V" Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=NWG0M7wK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of elver@google.com designates 209.85.210.50 as permitted sender) smtp.mailfrom=elver@google.com X-Rspamd-Server: rspam02 X-Stat-Signature: pwc1n7afaxa5zumwr6binrbz4axpx19r X-Rspamd-Queue-Id: 90B034202A1E X-HE-Tag: 1623833779-915868 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 16 Jun 2021 at 10:02, Daniel Axtens wrote: > Allow architectures to define a kasan_arch_is_ready() hook that bails > out of any function that's about to touch the shadow unless the arch > says that it is ready for the memory to be accessed. This is fairly > uninvasive and should have a negligible performance penalty. > > This will only work in outline mode, so an arch must specify > ARCH_DISABLE_KASAN_INLINE if it requires this. > > Cc: Balbir Singh > Cc: Aneesh Kumar K.V > Suggested-by: Christophe Leroy > Signed-off-by: Daniel Axtens Reviewed-by: Marco Elver but also check if an assertion that this is only used with KASAN_GENERIC might make sense (below). Depends on how much we want to make sure kasan_arch_is_ready() could be useful for other modes (which I don't think it makes sense). > -- > > I discuss the justfication for this later in the series. Also, > both previous RFCs for ppc64 - by 2 different people - have > needed this trick! See: > - https://lore.kernel.org/patchwork/patch/592820/ # ppc64 hash series > - https://patchwork.ozlabs.org/patch/795211/ # ppc radix series > --- > mm/kasan/common.c | 4 ++++ > mm/kasan/generic.c | 3 +++ > mm/kasan/kasan.h | 4 ++++ > mm/kasan/shadow.c | 8 ++++++++ > 4 files changed, 19 insertions(+) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 10177cc26d06..0ad615f3801d 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -331,6 +331,10 @@ static inline bool ____kasan_slab_free(struct kmem_cache *cache, void *object, > u8 tag; > void *tagged_object; > > + /* Bail if the arch isn't ready */ > + if (!kasan_arch_is_ready()) > + return false; > + > tag = get_tag(object); > tagged_object = object; > object = kasan_reset_tag(object); > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > index 53cbf28859b5..c3f5ba7a294a 100644 > --- a/mm/kasan/generic.c > +++ b/mm/kasan/generic.c > @@ -163,6 +163,9 @@ static __always_inline bool check_region_inline(unsigned long addr, > size_t size, bool write, > unsigned long ret_ip) > { > + if (!kasan_arch_is_ready()) > + return true; > + > if (unlikely(size == 0)) > return true; > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index 8f450bc28045..19323a3d5975 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -449,6 +449,10 @@ static inline void kasan_poison_last_granule(const void *address, size_t size) { > > #endif /* CONFIG_KASAN_GENERIC */ > > +#ifndef kasan_arch_is_ready > +static inline bool kasan_arch_is_ready(void) { return true; } > +#endif > + I've been trying to think of a way to make it clear this is only for KASAN_GENERIC mode, and not the others. An arch can always define this function, but of course it might not be used. One way would be to add an '#ifndef CONFIG_KASAN_GENERIC' in the #else case and #error if it's not generic mode. I think trying to make this do anything useful for SW_TAGS or HW_TAGS modes does not make sense (at least right now). > /* > * Exported functions for interfaces called from assembly or from generated > * code. Declarations here to avoid warning about missing declarations. > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c > index 082ee5b6d9a1..3c7f7efe6f68 100644 > --- a/mm/kasan/shadow.c > +++ b/mm/kasan/shadow.c > @@ -73,6 +73,10 @@ void kasan_poison(const void *addr, size_t size, u8 value, bool init) > { > void *shadow_start, *shadow_end; > > + /* Don't touch the shadow memory if arch isn't ready */ > + if (!kasan_arch_is_ready()) > + return; > + > /* > * Perform shadow offset calculation based on untagged address, as > * some of the callers (e.g. kasan_poison_object_data) pass tagged > @@ -99,6 +103,10 @@ EXPORT_SYMBOL(kasan_poison); > #ifdef CONFIG_KASAN_GENERIC > void kasan_poison_last_granule(const void *addr, size_t size) > { > + /* Don't touch the shadow memory if arch isn't ready */ > + if (!kasan_arch_is_ready()) > + return; > + > if (size & KASAN_GRANULE_MASK) { > u8 *shadow = (u8 *)kasan_mem_to_shadow(addr + size); > *shadow = size & KASAN_GRANULE_MASK; > -- > 2.30.2 > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20210616080244.51236-3-dja%40axtens.net.