From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx108.postini.com [74.125.245.108]) by kanga.kvack.org (Postfix) with SMTP id 640656B0044 for ; Mon, 26 Mar 2012 06:40:42 -0400 (EDT) Received: by obbta14 with SMTP id ta14so6526219obb.14 for ; Mon, 26 Mar 2012 03:40:41 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20120326093201.GL1007@csn.ul.ie> References: <20120324130353.48f2e4c8@kryten> <20120324102621.353114da@annuminas.surriel.com> <20120326093201.GL1007@csn.ul.ie> Date: Mon, 26 Mar 2012 13:40:41 +0300 Message-ID: Subject: Re: [PATCH] Re: kswapd stuck using 100% CPU From: Pekka Enberg Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Rik van Riel , Anton Blanchard , aarcange@redhat.com, akpm@linux-foundation.org, hughd@google.com, lkml , linux-mm@kvack.org, Linus Torvalds On Mon, Mar 26, 2012 at 12:32 PM, Mel Gorman wrote: > On Sat, Mar 24, 2012 at 10:26:21AM -0400, Rik van Riel wrote: >> >> Only test compaction_suitable if the kernel is built with CONFIG_COMPACTION, >> otherwise the stub compaction_suitable function will always return >> COMPACT_SKIPPED and send kswapd into an infinite loop. >> >> Signed-off-by: Rik van Riel >> Reported-by: Anton Blanchard > > Acked-by: Mel Gorman The API looks fragile and this patch isn't exactly making it any better. Why don't we make compaction_suitable() return something other than COMPACT_SKIPPED for !CONFIG_COMPACTION case? Pekka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org