From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB000C4338F for ; Sun, 8 Aug 2021 18:00:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6576E60F9E for ; Sun, 8 Aug 2021 18:00:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6576E60F9E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A34C26B0071; Sun, 8 Aug 2021 14:00:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A2A18D0002; Sun, 8 Aug 2021 14:00:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 892A56B0073; Sun, 8 Aug 2021 14:00:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id 4F14F6B0071 for ; Sun, 8 Aug 2021 14:00:33 -0400 (EDT) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve03.hostedemail.com (Postfix) with ESMTP id 5C402180CE6AE for ; Sun, 8 Aug 2021 17:22:12 +0000 (UTC) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2616F8249980 for ; Sun, 8 Aug 2021 17:22:02 +0000 (UTC) X-FDA: 78452581284.08.0BABCC3 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf13.hostedemail.com (Postfix) with ESMTP id E4D3210202A8 for ; Sun, 8 Aug 2021 17:22:01 +0000 (UTC) Received: by mail-wr1-f54.google.com with SMTP id b11so2039549wrx.6 for ; Sun, 08 Aug 2021 10:22:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xr4kzAIVCjF5FWTWh8J9rcezZE9QmpHisTh5XpSTVq4=; b=mDxynq6Jq//Ri1glX3u9qsjJ6/u+r4M7lt2FY7TsRKMyANRxSlDVUuJ/LIYWwITwG/ VLOKicPlQtys7CtvUq+IPzuOKYqpYuhDFfWD8hXMvNuCuXW2qXfhgQqv+sYPddsu3Gn3 Zlp4ewD8HXuQipWBBhIcXhYfyzGBwD/iZLi2uH16SBGvfmmmpokOMIV9VUp+/xzj3YPZ 30qs1UPhU6JYsD72FfCVMgyELf+UfY9oEja3Y8fbCwm/HW3ZjqFYaOCTdMxF1jYlqkNi bMkAgXbiJdzXqMWd/N3b7dRtHUkTSK49XyKPqhTx8p5lWbL1DtLxId0We8gZ/DJLWGgp 0UaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xr4kzAIVCjF5FWTWh8J9rcezZE9QmpHisTh5XpSTVq4=; b=mA3JNt/KH25xkIxcN6zSCo2tUVTdop2SbFxemOh1r7jwCcVmj5yHIeB2jcqF/AIlXN rWdYYZ2vRkeVr9KZFW6B42WgpNZgsakfz2Lg+5uX+Ou04a7imhmAaJbxqJjDlK3NLcDh 5lQutXFMgxz0lw/s80S1JfgryZ2wkxldWjNTHipi2nqSE1wftn1VmtpjPqDFPf4g8rR/ CsVcANQ/ntUNkwgSfZIl38TDmsqEEk2nbdhx6VuHcn6lup+KsU2nJ2wArl/gz7MOFJ55 J8Fqnr5IXQruEslkysULYSKPVNUMtRqO3E2+cW6XKs5NP1d2BYCfoBCfTBSMNSVS2Hs2 Pcuw== X-Gm-Message-State: AOAM533Ttg6v0KFrm/04bFos391SOM3m86Uudw3+ESEMHPseOtmMYW4c NqFbwdVz3cxAjJfIZUshjOljavA6Tu6i2U8oVYW/6Q== X-Google-Smtp-Source: ABdhPJyFFefuLsnyCCaoulIxQ4VUhijEdFZCwn+kZxl577A90oqK14aJQG1mV/gJhdfOQAr7zs2QlK2gH0l5krIEYnk= X-Received: by 2002:adf:f68d:: with SMTP id v13mr2877761wrp.358.1628443319773; Sun, 08 Aug 2021 10:21:59 -0700 (PDT) MIME-Version: 1.0 References: <20210731063938.1391602-1-yuzhao@google.com> <20210731063938.1391602-4-yuzhao@google.com> In-Reply-To: From: Yu Zhao Date: Sun, 8 Aug 2021 11:21:48 -0600 Message-ID: Subject: Re: [PATCH 3/3] mm: don't remap clean subpages when splitting isolated thp To: Matthew Wilcox Cc: Linux-MM , Andrew Morton , Hugh Dickins , "Kirill A . Shutemov" , Vlastimil Babka , Yang Shi , Zi Yan , linux-kernel , Shuang Zhai Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=mDxynq6J; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=yuzhao@google.com X-Stat-Signature: 7oyz6xjo7eub7wd4ah4kqzdkfp6x4795 X-Rspamd-Queue-Id: E4D3210202A8 X-Rspamd-Server: rspam01 X-HE-Tag: 1628443321-364766 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 3, 2021 at 5:38 AM Matthew Wilcox wrote: > > On Sat, Jul 31, 2021 at 12:39:38AM -0600, Yu Zhao wrote: > > +++ b/include/linux/rmap.h > > @@ -243,7 +243,7 @@ int page_mkclean(struct page *); > > */ > > void page_mlock(struct page *page); > > > > -void remove_migration_ptes(struct page *old, struct page *new, bool locked); > > +void remove_migration_ptes(struct page *old, struct page *new, bool locked, bool unmap_clean); > > I'm not a big fan of 'bool, bool'. Could we use a flag word instead? > > #define MIGRATE_REMOVE_LOCKED 1 > #define MIGRATE_UNMAP_CLEAN 2 Will do. Thanks.