From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB07AEB64D7 for ; Fri, 23 Jun 2023 20:39:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 053258D0002; Fri, 23 Jun 2023 16:39:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 001978D0001; Fri, 23 Jun 2023 16:39:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E59C68D0002; Fri, 23 Jun 2023 16:39:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CFFFA8D0001 for ; Fri, 23 Jun 2023 16:39:47 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A7537161058 for ; Fri, 23 Jun 2023 20:39:47 +0000 (UTC) X-FDA: 80935178814.10.FD43CFD Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf08.hostedemail.com (Postfix) with ESMTP id E3145160011 for ; Fri, 23 Jun 2023 20:39:44 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=sWz5n6tK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687552784; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gPqWdPkJs/nUcSq4t/ysEiwjvip+vYkENRmC8Nd4fVc=; b=ip5JnggHyRARV2zgwt0bolKG51ogJ/dgKvmWunnGBv1D2dOIg8/VLQurPbrjaCg1BcG1iO FylE/Lf+hZabyzg1Mn4l83RPbxhD+UUdcImgF2oOvJeOLp3+9K/DWKCRScRNMfz/UqiEcW eXv2oBSVYlHipDsNhN2pBqCKS1/e6nw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=sWz5n6tK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687552784; a=rsa-sha256; cv=none; b=VxZVDhvgFnIvUy5ety07ZN3vw99AOdASmBkDseY57EZKW9BzsCOtBufoEYioi+yLtszO4m L+ZJ0Vb8ekRV8jFVyPQGUF19xU843SsNPi6jdT3oKcQ4o6dx65EkYSXUfgHStJGH3HywLt 3AMrqQzIU99iKeJlb3yKFurgDxkbG3M= Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-40079b6fc56so14851cf.1 for ; Fri, 23 Jun 2023 13:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687552784; x=1690144784; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gPqWdPkJs/nUcSq4t/ysEiwjvip+vYkENRmC8Nd4fVc=; b=sWz5n6tK4xOCUrsaVvxIIoe9iKDtPXbUnViKV9bI83Gr2Kk0GG2IJldbvSpFxZqKl3 45I3cnkI6UAi6qCvYXmqs1B4MMpK6fBaPe4b/VrbL1DHf6zpqWpZXl1Vjk9FQ8snqXOW yNTLbHaFLeD1z0agQFnZOz/lN5V0tHRG2CbCksqsPhOIZ4Z3AOYvn6Gmdnu9NOIWyq2Z 1XPZS51Q6+iYL7rLIo4hh3xBYdcPz/ZpUD5LfIrf53TW2IRa8PjeLiDziw7YRmhmooeN aV9JyrSy/ST+5l1ZR0g4YeQH4Rv9oNeQoWwnoa8Uv7UXOsxXbFwkYW0MzU8K5f5gTbmt 5PzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687552784; x=1690144784; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gPqWdPkJs/nUcSq4t/ysEiwjvip+vYkENRmC8Nd4fVc=; b=ayHtE1/FvhPwZbVzOwNNvzB/aOAMexwrdcED+QLF+Gul/W5V/KT+kpDDnY0SKJEvRi xclto5sl200yNE7ruqf1NseJaoI1TL73NoK3TFHwgfegZz5RVLoqsDrLuqmgYFvt0wca fC/RVFn5poSdQWYJd2ugbPsSGcGDMLXdzLfjs7hUfJO/bNaE3La/KUULT1Cit8MiMIOR k9W6En7OyABRsXJ+79as9Bcy1A3tuMi2Qla6BvRgZqYgy0QFWnTXEIzwjirxnwcJGe+s 7kZA9489s2gaawRAIB4+j0FTNitS9g5pjRulUo+uSMaCHOp7xPcz2g32THpfdp0FeupY O1lg== X-Gm-Message-State: AC+VfDxr3sZmTqPiEWw0IPGU8zTfnUnuFNf5fE7bjfv8YLDZPqc6ck8r 9mjuHCCpD+b2NXuYklHtRI2iAFS89/jg/BndmchJiw== X-Google-Smtp-Source: ACHHUZ7BhsRpP0ZxbJV1Ob1pQJTPtBPEPQKVupWLukrcpuPRCLoL0XQfgfvatNlkSb4WcYoXIOwE5K+Rj/hJdi8hsWA= X-Received: by 2002:ac8:5a4d:0:b0:3ed:86f6:6eab with SMTP id o13-20020ac85a4d000000b003ed86f66eabmr11972qta.14.1687552783963; Fri, 23 Jun 2023 13:39:43 -0700 (PDT) MIME-Version: 1.0 References: <20230621023053.432374-1-yosryahmed@google.com> In-Reply-To: <20230621023053.432374-1-yosryahmed@google.com> From: Yu Zhao Date: Fri, 23 Jun 2023 14:39:07 -0600 Message-ID: Subject: Re: [PATCH 1/2] mm: memcg: rename and document global_reclaim() To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E3145160011 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 18q7gb8od1kjhkikuihskab1apmapyjp X-HE-Tag: 1687552784-153173 X-HE-Meta: U2FsdGVkX19u6Pf6CxlTqmjwzdKTEcRmk7ZtS9ffRWsCh7w3tdtFh60KjwyEQoMQbUQCfWJ8xY76q3Est33YAqMgymZv9RxRas3i94aybuxtgkInZv3hPZWy/F0/IMlmNlgdQf9a+XKe3BuKxYL3tK04SLbpHqwBzvxF2gdvZ2KKsByYjnBAEYG4rCyRaHb8PMc2rSZSVCI8knO94iCqrgyDrmozr6XxEfRrK9ZQSKPhYMuX8TyK30zIRg7y2QDtim0UhkYnrESRy0/7BSU3YY2QNqRVdZJnvIUPGPClhO+ulmZvgqYT4eoSirTt7Na/+pCXRtQtu1Q2gY242FtHW2kME37zyE3gcSMA3zdXlGLJ3zEYHacd7FIMHX1uanq04T6jofJ8KqXXYOQ7ennE+M9yQ+IlGmU/bOV+1wj9V0kyn+k8uiBy/MZuL2yR9CWc4exnvQtXVqK8DtBterjjctu1JMj/Gf17YVRiOd5EYLICbFOzUAkBfmQzYj887IhOZXZ70+sIu9G6U2EdcJx4T2q5qYwk1ek+iErgXijxmFWE22dMyrhaT5zP1i3QM5OtfdcupHm67S0hOruaEyY4ysRX3oA+QEzZSapISs4Bm/KbLt7LrFgxYXJ7fnSzNiWp+V2QDNrijxJkOd+oXORaR7t2DYTePRGOh/+7PY5hxbI237B6eyjli/xOfyGz0D+fB2NeWIbc3UR7scgO3m0M5ho977uImo4gF8jva5jDaDSAxpG4KN07Jihpd/mh1KNIW01xRDzE0JxCaCKupoXQpBed+L4eS09XyBY7E1l1WImRm+IkmFHmk6b1v2vrAWHJ/T78RdBYGVRC0hYBGw76NBXKhcQItTanzOIaVBFT3drtV8PQluWtz9uTNK2iF5Sn+4afiECmePRz8RPr02pDlMG8OrqVL7snOhfZyBxdQwqribW6DKrQBR0frShyuML6Pcx1AeoSVsp+idf9WBd ZrE0Binr IEVBSzMJXyn2+qqi9bSLxeSSZuycRZ6FcYsT/3Bgrneo4Jl3uDOPTZDNmUvphQyFXw4cKTSAqOD2RvVq73YCYOttyHrd4/C/l+N3gvSh7Uzr6TNO9AJT7/j87idi6DN4m3GvwxTaFcNTcLhDMziHmf+EG046icJ8r4PeErlFzocST7NlDhNfo/CnDhi5VL03YKzr21QD4p+Hj2Wtvi5ncskR5gcIKiAe3ROg1RLPqC+0+8YdQ246baqYW8pm3NkW1H3EVN1AXCSKP0aYQCq9oaN2swZgEkGPp9olL2DEX7YWRZFFFKEi4z+CvdoLfDg4X32fWozGxSUg/cxYoQ20tcO3CBWO3UNidudhIqXfUUcUHdOOTT0+TInDYkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000938, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 20, 2023 at 8:30=E2=80=AFPM Yosry Ahmed = wrote: > > Evidently, global_reclaim() can be a confusing name. Especially that it > used to exist before with a subtly different definition (removed by > commit b5ead35e7e1d ("mm: vmscan: naming fixes: global_reclaim() and > sane_reclaim()"). It can be interpreted as non-cgroup reclaim, even > though it returns true for cgroup reclaim on the root memcg > (through memory.reclaim). > > Rename it to root_reclaim() in an attempt to make it less ambiguous, and > add documentation to it as well as cgroup_reclaim. > > Reported-by: Johannes Weiner > Closes: https://lore.kernel.org/lkml/20230405200150.GA35884@cmpxchg.org/ > Signed-off-by: Yosry Ahmed Acked-by: Yu Zhao