From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DAC2CFB43F for ; Sun, 6 Oct 2024 22:04:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A50CD6B015A; Sun, 6 Oct 2024 18:04:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A009B6B015B; Sun, 6 Oct 2024 18:04:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CB536B016C; Sun, 6 Oct 2024 18:04:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6B89A6B015A for ; Sun, 6 Oct 2024 18:04:13 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0FEC514045C for ; Sun, 6 Oct 2024 22:04:13 +0000 (UTC) X-FDA: 82644556386.08.9C3C39B Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by imf14.hostedemail.com (Postfix) with ESMTP id 50077100008 for ; Sun, 6 Oct 2024 22:04:11 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JTSaWanM; spf=pass (imf14.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728252119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AVMT2ksBxbHoyLr2X5OlhSzaVPcgiqa8Ios/l6Z3o9s=; b=FcqUQcgilk7I9Ul4nHBYWAW0E09YkBkS4GoTziB1w3Xj0yP3oSUVbo3UULZpmZ+0Tt+/zG GZBDCUQ4d0tC1NiJCcl76KUuSdHRwCqrlOkNWk0tctHU5WT/LsDcBabvHcNEJ06ileyex/ ITi8kgkZzp/uikF3t/XTkm0M9FThuGE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728252119; a=rsa-sha256; cv=none; b=63ju93EIu6SpN1+6xCL4nkhwsTIqSu5cA49+YwGlGVT1kl5Hhzjo4mTZZSldeb7zmKhh2S cXexa+AnMR2rbz3kqu6VVGEggecomO/c+8ACA5A7Z2iUP415SMsE4xrf5+i523qQqK3YXw DxTAB4N1E4efS/E+43SJVvCW8X7Ay+Y= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JTSaWanM; spf=pass (imf14.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-vs1-f53.google.com with SMTP id ada2fe7eead31-4a3a5cc3903so981760137.1 for ; Sun, 06 Oct 2024 15:04:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728252250; x=1728857050; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AVMT2ksBxbHoyLr2X5OlhSzaVPcgiqa8Ios/l6Z3o9s=; b=JTSaWanMlfdm/WPaERC6gPE9rYHOoL8nPtbYzEPnxKtRrnkyEkhdVALaxJ2LiyGgIi eMTIUZfwU7Opq7yG/9gyH0en/KKaqg3UPDCdjJC88T1QrKnUcUAF+VnRZDrbr323ywYv Nuid98xb12Y30dFXPOaOW+IUTH6YECn8I/uY2fgHjg2FeumnrejSLGwD1ECGb5qOPNj4 TPNt7rPScTQ9CzIZBRBmGY/J/Ao0lEN0Wp4o1jAC617v2QtjqXQ18qYYWxkStwgc+3XY 0qChrDJ1tMDqV427l0QJn1jdb39gqr8SfSKUKayBQ9Kt6QqfjRNwT5fuew+PXEFwsnIC xbiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728252250; x=1728857050; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AVMT2ksBxbHoyLr2X5OlhSzaVPcgiqa8Ios/l6Z3o9s=; b=CzQrTdIV58i3i5zZ8Hbn0DxvRA8zvUKggtTDBygYbGLg7cKmU6kyF8537TjFdGCSgI iigvFzAZz8h9vQMq0qNdH46rQ5y6JXxm4XtMl+d/yBtlEURcV9RLCrY2ethVYG83PRVQ KqFgORLaRZX7Q+rUSVebJAsEfVPJh+F6POFxthwT140ty8emGz1d8sO7qGdCEMC/KgMa j6WOV6H9ZRU9mURFeQAzhi/sx79HEsOP2DnDLn0GCp2CN7mNT4lYA2Toz1U/rOqlFB1l FPHlScPlYTLBbvmQnFL65h1GpABHzYGwIlKTtIdbvI3HOP/N4HEFYaTfn8ReMDwN+Lc6 c9lg== X-Forwarded-Encrypted: i=1; AJvYcCVssw391VX2S3wUURwxfskQfzDDaeSMdGwC05d7pffJ1Rug82aEjzbJSYyNrONW3nhzT4h2reZ5zA==@kvack.org X-Gm-Message-State: AOJu0Yz56g9jsYgLu3Jf88QdIoPQRnbMdR+yWprFStPl2PMUVqNH15AQ D3llAnyJN2aXj2X4zZXHFphLJKXF3+qxixJ2wphid6PyLRcvtVyK4QwgOlw2syQ+OOk6K4rbQgQ p/PqjC3QLhQ3H1ZUOycjowx8JYUL2W/YkB+iL X-Google-Smtp-Source: AGHT+IEhMp2OSt7XqbP4MYcacFLWXYXdwh/F2Py4xZcA4lLz/qCIm0hnmkgR5mRLKSopgCYsEWGoXbueD1YCbwt71o0= X-Received: by 2002:a05:6102:290e:b0:4a3:cb2b:9748 with SMTP id ada2fe7eead31-4a4058ee453mr5315729137.24.1728252250091; Sun, 06 Oct 2024 15:04:10 -0700 (PDT) MIME-Version: 1.0 References: <20241002225150.2334504-1-shakeel.butt@linux.dev> In-Reply-To: <20241002225150.2334504-1-shakeel.butt@linux.dev> From: Yu Zhao Date: Sun, 6 Oct 2024 16:03:31 -0600 Message-ID: Subject: Re: [PATCH] mm/truncate: reset xa_has_values flag on each iteration To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 50077100008 X-Stat-Signature: fy1iztxfhzssd8tmq63bcnpyjcqe1xg3 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728252251-383729 X-HE-Meta: U2FsdGVkX19PBR54CBODMqgfOtEaYkrWvsed+qNfO358o/5hncBuvcI5iRoE6yrrET6kQ6uXgHRQ8siw5sPV7s7qBjYKOxZCeNta35F533oYTpwYQhmYj/qeixRqgvbNDHfYX/VRnRZo/Cnhsd9lnP8kAdO3IIuuxBrbmDn/u7/Os0mpMo6w9+W+gnQBhSkxfafBjuJTJrj1KkYwq9mSU1Kuz+G5Sy6jQzN7lUXkqluCP9c5LJy7f3X8dMg/fbLNsuAMZErwySUobfSqeMjl8+ETKU+vAxDFGk1e+oBNx7XzKIr+dfGPL/B+d6V5VZDOZKLJ8pxM53d9CNGsXdgUwXlxfDuNV33sQKG29kJ3/d/Oep1ZGZJ8iYyDlMqHr/9PE2jM90cuZ5+1xag3dAvnI+0uk6zVx44cX8NicfJC7YGWriNAW+1Fd8ygKVVNUlMnz31mEN1ZyQ/cDVubR24mXnGBz7RDeXkf/BUupOmDd+VywTkkp8TyYGyOyBzr3//Bp3kVhUk0QAo9G7e1Ivb9DPOw5I0sVlTxraUM4SBavUa2YMByi8WPHoDcBy5/UA2mu0wBpL2gDqzMRJ+Fic2/h1WTLszp2tQ8uZYTTBcdTZ/8IlLMM8AeJjbxI0pOxnlXTQckaGV4h674dewQkJo/1xIHZUv05I2MduZHyD4t8fNsMCqwx6HDbPc4P6HdlQ+yZzgIA7Z2Dz8vsVq8/aS9ZnrjtHazLcI2yjPAL9d38OpW5aewIzR/waYn82S/cVsX7/MVNtOQ/Wm8Ef/F3id9Go8Mdur4nqE4RQ8kSe59BYpsoNclNxkplNKgS5VkLmtd8f6C/VtPQLiKFB8DU+UP3EqvVHjR+f4SVSQJ3XjVczKAJvtYViKJdLWd3azmlAef0itDKsyr0l0+BXskKTSMBxdKu2N5Ut3NgIKDh0IKZGC1MFcuOUNjqR2dqV1SuEbixJBLOc679yy81Fb37nV Z7F+yajx qIbdBi+2liy8W1ScaZwwp38Ux68hzXgzN+MGVSgda3GbumjcYA1u5fYMiMBfE7CNt1MWqrv9gPmN0UoEaiW7b6BmLp8rvAGIQGWXxYpPhtEsPSArK3R89l1bX4dp3JS6cg6ktjgexGC9baNwvO0kbf3kYePxk6jnHhW0HpMl6BLwMtx0p0n8RPzGhSMiiPMp9dAgkmPCgxaThwM/Fqx2Qc4osYErnEfa5JsjHNibXO6205eib+6tvXm9hfhXzl4g/cOLNoh9+MKBfpqY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.003975, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 2, 2024 at 4:52=E2=80=AFPM Shakeel Butt wrote: > > Currently mapping_try_invalidate() and invalidate_inode_pages2_range() > traverses the xarray in batches and then for each batch, maintains and > set the flag named xa_has_values if the batch has a shadow entry to > clear the entries at the end of the iteration. However they forgot to > reset the flag at the end of the iteration which cause them to always > try to clear the shadow entries in the subsequent iterations where > there might not be any shadow entries. Fixing it. > > Fixes: 61c663e020d2 ("mm/truncate: batch-clear shadow entries") > Signed-off-by: Shakeel Butt Acked-by: Yu Zhao