linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Yang Bai <hamo.by@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: cl@linux-foundation.org, penberg@kernel.org, mpm@selenic.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slab: warning if total alloc size overflow
Date: Tue, 14 Feb 2012 17:43:17 +0800	[thread overview]
Message-ID: <CAO_0yfOjstSnhqf_DBBr7-it48GyUObF2=4GeMd7TDo_TPaLPg@mail.gmail.com> (raw)
In-Reply-To: <20120214005301.a9d5be1a.akpm@linux-foundation.org>

On Tue, Feb 14, 2012 at 4:53 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Tue, 14 Feb 2012 15:28:19 +0800 Yang Bai <hamo.by@gmail.com> wrote:
>
>
> One of the applications of kcalloc() is to prevent userspace from
> causing a multiplicative overflow (and then perhaps causing an
> overwrite beyond the end of the allocated memory).
>
> With this patch, we've just handed the user a way of spamming the logs
> at 1MHz.  This is bad.
>
>
> Also, please let's not randomly add debug stuff in places where we've
> never demonstrated a need for it.

Ok. Please just drop this patch.

Thanks.

-- 
    """
    Keep It Simple,Stupid.
    """

Chinese Name: 白杨
Nick Name: Hamo
Homepage: http://hamobai.com/
GPG KEY ID: 0xA4691A33
Key fingerprint = 09D5 2D78 8E2B 0995 CF8E  4331 33C4 3D24 A469 1A33

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-02-14  9:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-14  7:28 [PATCH] slab: warning if total alloc size overflow Yang Bai
2012-02-14  7:31 ` Pekka Enberg
2012-02-14  7:51   ` Yang Bai
2012-02-14  8:10     ` Pekka Enberg
2012-02-14 15:04   ` Christoph Lameter
2012-02-14  8:53 ` Andrew Morton
2012-02-14  9:43   ` Yang Bai [this message]
2012-02-14 15:07   ` Christoph Lameter
2012-02-14 15:03 ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAO_0yfOjstSnhqf_DBBr7-it48GyUObF2=4GeMd7TDo_TPaLPg@mail.gmail.com' \
    --to=hamo.by@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mpm@selenic.com \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).