Re: [PATCH] mm/memblock.c: using judgment statement can reduce loop and enhance readability.

[黄亮亮 <huanglllzu@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

Hi,this patch can less loop once in this situation:
base more than rbase and end less than rend.

Mike Rapoport <rppt@kernel.org> 于2023年11月2日周四 16:54写道：

> Hi,
>
> > Subject: [PATCH] mm/memblock.c: using judgment statement can reduce loop
> and enhance readability.
>
> I disagree.
>
> On Thu, Nov 02, 2023 at 10:37:10AM +0800, huanglllzu@gmail.com wrote:
> > From: Liangliang Huang <huangll@lemote.com>
> >
> > Signed-off-by: Liangliang Huang <huangll@lemote.com>
> > ---
> >  mm/memblock.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/mm/memblock.c b/mm/memblock.c
> > index 913b2520a9a0..e48dea7144bb 100644
> > --- a/mm/memblock.c
> > +++ b/mm/memblock.c
> > @@ -655,7 +655,11 @@ static int __init_memblock
> memblock_add_range(struct memblock_type *type,
> >                       }
> >               }
> >               /* area below @rend is dealt with, forget about it */
> > -             base = min(rend, end);
> > +             if (end < rend) {
> > +                     base = end;
> > +                     break;
> > +             } else
> > +                     base = rend;
>
> min() is perfectly clear and there no change in number of iterations of the
> loop.
>
> >       }
> >
> >       /* insert the remaining portion */
> > --
> > 2.25.1
> >
>
> --
> Sincerely yours,
> Mike.
>

[-- Attachment #2: Type: text/html, Size: 2179 bytes --]