From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx131.postini.com [74.125.245.131]) by kanga.kvack.org (Postfix) with SMTP id 26D236B13F0 for ; Tue, 31 Jan 2012 01:33:04 -0500 (EST) Received: by vbbfd1 with SMTP id fd1so4510671vbb.14 for ; Mon, 30 Jan 2012 22:33:03 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20120130135201.7bb5f173.akpm@linux-foundation.org> References: <1327572121-13673-1-git-send-email-gilad@benyossef.com> <1327572121-13673-2-git-send-email-gilad@benyossef.com> <20120130135201.7bb5f173.akpm@linux-foundation.org> Date: Tue, 31 Jan 2012 08:33:03 +0200 Message-ID: Subject: Re: [v7 1/8] smp: introduce a generic on_each_cpu_mask function From: Gilad Ben-Yossef Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Chris Metcalf , Peter Zijlstra , Frederic Weisbecker , Russell King , linux-mm@kvack.org, Pekka Enberg , Matt Mackall , Rik van Riel , Andi Kleen , Sasha Levin , Mel Gorman , Alexander Viro , linux-fsdevel@vger.kernel.org, Avi Kivity , Michal Nazarewicz , Kosaki Motohiro , Milton Miller , linux-kernel@vger.kernel.org On Mon, Jan 30, 2012 at 11:52 PM, Andrew Morton wrote: > On Sun, 29 Jan 2012 14:24:16 +0200 > Gilad Ben-Yossef wrote: > >> On Thu, Jan 26, 2012 at 12:01 PM, Gilad Ben-Yossef = wrote: >> > on_each_cpu_mask calls a function on processors specified by >> > cpumask, which may or may not include the local processor. >> > >> > You must not call this function with disabled interrupts or >> > from a hardware interrupt handler or from a bottom half handler. >> > >> > Signed-off-by: Gilad Ben-Yossef >> > Reviewed-by: Christoph Lameter >> > CC: Chris Metcalf >> ... >> > --- >> > __include/linux/smp.h | __ 22 ++++++++++++++++++++++ >> > __kernel/smp.c __ __ __ __| __ 29 +++++++++++++++++++++++++++++ >> > __2 files changed, 51 insertions(+), 0 deletions(-) >> > >> >> >> Milton made the very sensible comment that while adding on_each_cpu() in= the >> arch generic code and removing the two arch specific instances from tile= and arm >> in separate patches is good for review, it will break bisect. >> >> He suggested I squash =A0them into a single commit when it goes in. >> >> Since you picked the patch set into linux-mm, will now be a good time fo= r that? > > I can fold the patches together - I do that all the time. > > Please identify exactly whcih patches you're referring to here. > > arm-move-arm-over-to-generic-on_each_cpu_mask and > tile-move-tile-to-use-generic-on_each_cpu_mask should be folded into > smp-introduce-a-generic-on_each_cpu_mask-function, yes? Yes. Thank you. Gilad --=20 Gilad Ben-Yossef Chief Coffee Drinker gilad@benyossef.com Israel Cell: +972-52-8260388 US Cell: +1-973-8260388 http://benyossef.com "Unfortunately, cache misses are an equal opportunity pain provider." -- Mike Galbraith, LKML -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org