From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C811DC352A1 for ; Wed, 7 Dec 2022 02:22:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C2D58E0003; Tue, 6 Dec 2022 21:22:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 373768E0001; Tue, 6 Dec 2022 21:22:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23AC88E0003; Tue, 6 Dec 2022 21:22:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 11AB38E0001 for ; Tue, 6 Dec 2022 21:22:55 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D2AF712017A for ; Wed, 7 Dec 2022 02:22:54 +0000 (UTC) X-FDA: 80213912268.21.8FFC7D3 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by imf20.hostedemail.com (Postfix) with ESMTP id 8C2DF1C0002 for ; Wed, 7 Dec 2022 02:22:54 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qltconEc; spf=pass (imf20.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670379774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=87hK10glcNhHV4zXDkx3UM3r+PG7Ihr6tBkX6WXhAAs=; b=dvDSoCQOE4Terlc93fkyEiQtcL5RhQZZOus/BlsEYZaK5Och2AAPmso1hTVopeHz5RIKxm ln2oJYNiuFW/OyX/IbkjfMjqNyB0vkiWac//TyVO6rgxC9RnovlUXCwNPZGzskR+TPld7V vMgk+SgwyA4xaMWXL+QnfxLOwwizMOE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qltconEc; spf=pass (imf20.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670379774; a=rsa-sha256; cv=none; b=F5NWOpzRb8Vl1E2SpZdoqE0Qad4j5iU+TqgsI6DR3NOlPoAOq5QUVScT6QtrKP5aJLgQZF VvEZGOt/N3JefnAg3ioLIFvg37UlRraPwvoyWzMXVRItbL0N4oKQu8AhjibINCDPBxyQ9N h2D+p2rJCkwlDR8QlhyVb6z7LBPAP8E= Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-3b56782b3f6so171838227b3.13 for ; Tue, 06 Dec 2022 18:22:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=87hK10glcNhHV4zXDkx3UM3r+PG7Ihr6tBkX6WXhAAs=; b=qltconEcysCUnspDzr69AWdD+WTITkmGJ/O9Gu6/NLZ2gSyt+up7KdtKj1FIg4ateY bX6cRHtwX39uHlNiNT+Lscfei3Oqvw3MhORzh14n57S9bK8ByM76VVHENrtYtO707pIT FrCYQ9A5vEUU61mxpgTfZ0kBqIUzMn2PtFWVxga7qHFXaemEpoOhp1jk/NiWjxXomb2k GXC9X+EZWGnOVFfPm9UPMnOWgJsqoNVVNZbhaD4unvDqyRHYbImrHbbHaEvEO9snEAQF /nTdRfGcrcpHdRSWHgXM1XhL+NWjcUsuE6NctOVt6SOLcyGGnDKi/Vu2SsQYkdrcjXfd reXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=87hK10glcNhHV4zXDkx3UM3r+PG7Ihr6tBkX6WXhAAs=; b=bvA43Txux+FzxVcssngxfelSaVJJyUQdwaF/tBdKR/eNlX0DRge0W4crDnyS5j5kdp Fw3xYCRj+cOWo2hd+RKFvxod2WZx2iea+ILJNh1TWYq3evTgIgoMcDtmzsUjZmSJqFy7 ueD4vuusqjZkaMLXlWUea5C5/cCXShMufIP1SdXA8ixaSPhk6a/b8mp+kCftt9JeIkh8 JN14dm4Wc5UwbJXz0yPIkCycutt9bWR4uOMZ2GgsNtsbre4QYqfFLUPpMaK590MERHsj CABhE2e4jvHBCZMN0BaRU6QVZLO0gGa6ySllShjImzlwV4nzIIBsMoepMRXGdhMNvUEj FMcw== X-Gm-Message-State: ANoB5pnmbmIUr2VL/WBLbsrmxvcdr9nCQsGifH6M5/5TLyR7wahMDqnb H+HutioGe/dql2JGYLZnkX1rGVcJk5h0+ppvKqE= X-Google-Smtp-Source: AA0mqf4I1wEjh5sgajMRo+CQcrClD/fT861+BuD2d2kayotVh0KVGoz2tHJ3VFd14XzvDDEF5d3Rxh71qvj3afQa16s= X-Received: by 2002:a81:5243:0:b0:3d2:2098:c5fb with SMTP id g64-20020a815243000000b003d22098c5fbmr34140855ywb.121.1670379773652; Tue, 06 Dec 2022 18:22:53 -0800 (PST) MIME-Version: 1.0 References: <20221206204115.35258-1-vishal.moola@gmail.com> In-Reply-To: From: Vishal Moola Date: Tue, 6 Dec 2022 18:22:42 -0800 Message-ID: Subject: Re: [PATCH mm-unstable] ext4: Convert mext_page_double_lock() to mext_folio_double_lock() To: Matthew Wilcox Cc: linux-mm@kvack.org, tytso@mit.edu, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8C2DF1C0002 X-Rspam-User: X-Stat-Signature: ider3dkksikx1h95btpsn6xtay6musta X-Spamd-Result: default: False [4.10 / 9.00]; SORBS_IRL_BL(3.00)[209.85.128.181:from]; SUBJECT_HAS_UNDERSCORES(1.00)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; RCVD_NO_TLS_LAST(0.10)[]; BAYES_HAM(-0.00)[28.30%]; MID_RHS_MATCH_FROMTLD(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; R_DKIM_ALLOW(0.00)[gmail.com:s=20210112]; TAGGED_FROM(0.00)[]; TO_DN_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17:c]; ARC_NA(0.00)[] X-HE-Tag: 1670379774-261687 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Three are inline, which makes sense for the 146 bytes, but we're also > removing out of line calls as well as the inline calls. > > Anyway, whether the description is updated or not, this looks good to me. I seem to have miscounted. We can correct that part in the description to "removes 6 calls to compound_head() and 2 calls to folio_file_page()." Thanks for the review! > Reviewed-by: Matthew Wilcox (Oracle)