From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEC87C433E8 for ; Mon, 13 Jul 2020 15:48:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 963072075B for ; Mon, 13 Jul 2020 15:48:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="NB7aPTPi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 963072075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3DC348D000A; Mon, 13 Jul 2020 11:48:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 388908D0002; Mon, 13 Jul 2020 11:48:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 250A88D000A; Mon, 13 Jul 2020 11:48:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id 0C8B58D0002 for ; Mon, 13 Jul 2020 11:48:41 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B696D45DA for ; Mon, 13 Jul 2020 15:48:40 +0000 (UTC) X-FDA: 77033485200.26.copy12_040d7be26ee9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 82A311804B66A for ; Mon, 13 Jul 2020 15:48:40 +0000 (UTC) X-HE-Tag: copy12_040d7be26ee9 X-Filterd-Recvd-Size: 4583 Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Jul 2020 15:48:39 +0000 (UTC) Received: by mail-ed1-f67.google.com with SMTP id n2so14085169edr.5 for ; Mon, 13 Jul 2020 08:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W36OcjXryM8jgoewQfeJp3IZBi2EgGKHyNoHZfcaUKg=; b=NB7aPTPiP9qMPZ0y5PyZjEZciyC3DGD/+k/bgqBjuSVN7xIiMDgNbsaF6/pgADNch+ Ppp6lmsRYZBZaFrRPXfH/OKEHROSUnQaiibSBid42105KDuiFDu1QwTgOqxAL6c2lRjW MB7BlEtHL+kZqmH7hAMfNq/xbtRyDjIYnMpKNKQ38wZaBZBH3mGvzkSQ9nxlcL+jduGt GFhsoxForK/GfjOiwcjP4X5Npt3KHapXh9bsKOxwM98za+n3VD8+3bVQ2bTLNFDGInhy BOsBa2M/13YjYvQeW8U+bOZfC3IeaBPpjGLKUN+S0b/5sR0Bwju5V17YorGeaFaOIYCu VGKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W36OcjXryM8jgoewQfeJp3IZBi2EgGKHyNoHZfcaUKg=; b=CO4qX26UuKr00DxxrQ+2SFPe+zuZ4gaQy3eoFefkyQTSflJM6a4aVyZsPXQtAfkgBy wDOgHlHBmIFDIEVZASOC4gilybAXO1uv73AlLk05Il0l4nzcw6JkLVsDDuBiTuq0mHRF eMMntTF4mtO2sVV1sLVndIvHnkAtFweDqFniK9KKxW9wSzDbXl5d878ws0k3TtLGefsd q/3+oXCAHECsahQ1/yE1BC2l8fUouUpD0rqRfEdhPr0Sxjn6QebdFa8niTQVtFJwf8Kz DTXOavpxpm1yRLNJEyevD8MQH9MZaF2rk792a5C5RjsWnZnw5p8C7rijwRS/DsxWEgkd VYFQ== X-Gm-Message-State: AOAM530eRBweviOrlGZfbMFJf/03CI3WbL8t9UROvbZ+FzvNNYSrCRLU IsuUnVmDA35wX5LKTR3revvPnEAPu5yKFtmj5sflkw== X-Google-Smtp-Source: ABdhPJy9eW9eIp+1KepqCPSTRPe76Dr5VVVESCrZMoaRV0JKP6GTk/JYXKXYNywspxI5vIOjjZtqBIKR4ru2y3M6GsE= X-Received: by 2002:aa7:d043:: with SMTP id n3mr73787edo.102.1594655318157; Mon, 13 Jul 2020 08:48:38 -0700 (PDT) MIME-Version: 1.0 References: <159457116473.754248.7879464730875147365.stgit@dwillia2-desk3.amr.corp.intel.com> <159457120893.754248.7783260004248722175.stgit@dwillia2-desk3.amr.corp.intel.com> <20200713070304.GC11000@linux.ibm.com> In-Reply-To: <20200713070304.GC11000@linux.ibm.com> From: Dan Williams Date: Mon, 13 Jul 2020 08:48:27 -0700 Message-ID: Subject: Re: [PATCH v2 08/22] memblock: Introduce a generic phys_addr_to_target_node() To: Mike Rapoport Cc: linux-nvdimm , Jia He , Will Deacon , David Hildenbrand , Andrew Morton , Peter Zijlstra , Vishal L Verma , Dave Hansen , Ard Biesheuvel , Linux MM , Linux Kernel Mailing List , Linux ACPI , Christoph Hellwig , Joao Martins Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 82A311804B66A X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 13, 2020 at 12:04 AM Mike Rapoport wrote: > > Hi Dan, > > On Sun, Jul 12, 2020 at 09:26:48AM -0700, Dan Williams wrote: > > Similar to how generic memory_add_physaddr_to_nid() interrogates > > memblock data for numa information, introduce > > get_reserved_pfn_range_from_nid() to enable the same operation for > > reserved memory ranges. Example memory ranges that are reserved, but > > still have associated numa-info are persistent memory or Soft Reserved > > (EFI_MEMORY_SP) memory. > > Here again, I would prefer to add a weak default for > phys_to_target_node() because the "generic" implementation is not really > generic. > > The fallback to reserved ranges is x86 specfic because on x86 most of the > reserved areas is not in memblock.memory. AFAIK, no other architecture > does this. True, I was pre-fetching ARM using the new EFI "Special Purpose" memory attribute. However, until that becomes something that platforms deploy in practice I'm ok with not solving that problem for now. > And x86 anyway has implementation of phys_to_target_node(). Sure, let's go with the default stub for non-x86. Justin, do you think it would make sense to fold your dax_kmem enabling for arm64 series into my enabling of dax_hmem for all memory-hotplug archs?