From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C50A9C433ED for ; Wed, 5 May 2021 23:14:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 45314613EC for ; Wed, 5 May 2021 23:14:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45314613EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C0D376B006C; Wed, 5 May 2021 19:14:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBC1F6B006E; Wed, 5 May 2021 19:14:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A35A56B0070; Wed, 5 May 2021 19:14:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id 874626B006C for ; Wed, 5 May 2021 19:14:29 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 31E3B941A for ; Wed, 5 May 2021 23:14:29 +0000 (UTC) X-FDA: 78108733458.39.18962D1 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf18.hostedemail.com (Postfix) with ESMTP id 2C2D32000268 for ; Wed, 5 May 2021 23:14:30 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id u21so5362954ejo.13 for ; Wed, 05 May 2021 16:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eV0w8etXkFhUUzYjnKSCsVae1IAlaUtWImvJC4NlGv8=; b=zwviguEb5zGUn1BT7p2v9caMPA2xjcLYZJjQnrAJ8xrN61l76tEdBzgUkEu6FDLpEq RBdNwziQISfYpW0zyJ2c7Iqi0hWkz8C2CohnGLWlm911dNkGvTWOc3eaoPXUQmWhmNfA n71wOZB+JRRELeKzTGetBt1+KRkzSUU7UdwUSpz873EIT7k5z9fmE0rQkuiajCD6WauE R7dJd0nbRCAi4RHBgSlK4WI3zadwnsxqTCOeLSMr2xUjLhDNi6APdFJyse8Ev09Gza2C t1HnArBpotEIcgWdcUvS2uMKeqCZsCJLA1udF83O58LRfjoWiFObJGA63SvQwYFDLM0M PRDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eV0w8etXkFhUUzYjnKSCsVae1IAlaUtWImvJC4NlGv8=; b=Y76qOhW0Tl1I38Wa7F3ECLamV2zR7KlnzjMBIugPJn012AJAgv3Gn1pgihbtBblZKN L0DaBTJ8DLFObQvF82KyDDQkOUoKK+1RqIcrsniAnteRBVS8CDvDTr/sLhfzp2/ypQMZ CfrMRQt5DPiA+AMYhNwy5hOI6yIXoPNqV+YkNSei/XIKn4TGqY7B4EBjNOnalFAM8kt5 Z6qeTdXdQOedrfF9h04lH2vZZIifCd+xI4ezsgDJlN4wroJcr26rmRatPV3f1rQSFk5C u4+u2IZH0LM2AZKa3vdTwz76KNVJzZlXdIvHPdx1VqGg8JCyrIFtwmVsbLRG/2Vl5/jc uKGg== X-Gm-Message-State: AOAM5305Vopc9hmaVTwDLQNJRjB6dcq8FCA20QeEhPdyOfBfjn/1N2Ie IJxqVNQP8IVnra9rZG2ugKca6/yKQ+P5Zr/vgu8WjA== X-Google-Smtp-Source: ABdhPJx29/y8lXlVkEIpt+TPUO3t7vpEMfxllyYSQmBbSvX+6rl/xmyA7CaXZBpFUuok8cTB+IATuK/HJi+4WzcOIgg= X-Received: by 2002:a17:906:a20b:: with SMTP id r11mr1132022ejy.323.1620256467414; Wed, 05 May 2021 16:14:27 -0700 (PDT) MIME-Version: 1.0 References: <20210325230938.30752-1-joao.m.martins@oracle.com> <20210325230938.30752-6-joao.m.martins@oracle.com> <52195943-3344-ec9b-3c7f-1e6d415c390e@oracle.com> In-Reply-To: <52195943-3344-ec9b-3c7f-1e6d415c390e@oracle.com> From: Dan Williams Date: Wed, 5 May 2021 16:14:31 -0700 Message-ID: Subject: Re: [PATCH v1 05/11] mm/sparse-vmemmap: add a pgmap argument to section activation To: Joao Martins Cc: Linux MM , Ira Weiny , linux-nvdimm , Matthew Wilcox , Jason Gunthorpe , Jane Chu , Muchun Song , Mike Kravetz , Andrew Morton , Oscar Salvador Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2C2D32000268 X-Stat-Signature: 5bpag7bd8fjs8wieh9gu3j9g1jrxca38 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel-com.20150623.gappssmtp.com header.s=20150623 header.b=zwviguEb; spf=none (imf18.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.218.51) smtp.mailfrom=dan.j.williams@intel.com; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none) Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=mail-ej1-f51.google.com; client-ip=209.85.218.51 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620256470-930591 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 5, 2021 at 3:38 PM Joao Martins wrote: > > > > On 5/5/21 11:34 PM, Dan Williams wrote: > > On Thu, Mar 25, 2021 at 4:10 PM Joao Martins wrote: > >> > >> @altmap is stored in a dev_pagemap, but it will be repurposed for > >> hotplug memory for storing the memmap in the hotplugged memory[*] and > >> reusing the altmap infrastructure to that end. This is to say that > >> altmap can't be replaced with a @pgmap as it is going to cover more than > >> dev_pagemap backend altmaps. > > > > I was going to say, just pass the pgmap and lookup the altmap from > > pgmap, but Oscar added a use case for altmap independent of pgmap. So > > you might refresh this commit message to clarify why passing pgmap by > > itself is not sufficient. > > > Isn't that what I am doing above with that exact paragraph? I even > reference his series at the end of commit description :) in [*] Oh, sorry, it didn't hit me explicitly that you were talking about Oscar's work I thought you were referring to your own changes in this set. I see it now... at a minimum the tense needs updating since Oscar's changes are in the past not the future anymore. If it helps, the following reads more direct to me: "In support of using compound pages for devmap mappings, plumb the pgmap down to the vmemmap_populate* implementation. Note that while altmap is retrievable from pgmap the memory hotplug codes passes altmap without pgmap, so both need to be independently plumbed."