From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f199.google.com (mail-ob0-f199.google.com [209.85.214.199]) by kanga.kvack.org (Postfix) with ESMTP id D2CE66B025E for ; Fri, 15 Apr 2016 14:56:21 -0400 (EDT) Received: by mail-ob0-f199.google.com with SMTP id fg3so41819030obb.3 for ; Fri, 15 Apr 2016 11:56:21 -0700 (PDT) Received: from mail-oi0-x22a.google.com (mail-oi0-x22a.google.com. [2607:f8b0:4003:c06::22a]) by mx.google.com with ESMTPS id l20si3925552otd.11.2016.04.15.11.56.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Apr 2016 11:56:21 -0700 (PDT) Received: by mail-oi0-x22a.google.com with SMTP id p188so132824834oih.2 for ; Fri, 15 Apr 2016 11:56:20 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1459303190-20072-1-git-send-email-vishal.l.verma@intel.com> <1459303190-20072-6-git-send-email-vishal.l.verma@intel.com> <1460739288.3012.3.camel@intel.com> <1460741821.3012.11.camel@intel.com> Date: Fri, 15 Apr 2016 11:56:20 -0700 Message-ID: Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io From: Dan Williams Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Jeff Moyer Cc: "Verma, Vishal L" , "hch@infradead.org" , "jack@suse.cz" , "axboe@fb.com" , "linux-nvdimm@ml01.01.org" , "david@fromorbit.com" , "linux-kernel@vger.kernel.org" , "xfs@oss.sgi.com" , "linux-block@vger.kernel.org" , "linux-mm@kvack.org" , "viro@zeniv.linux.org.uk" , "linux-fsdevel@vger.kernel.org" , "akpm@linux-foundation.org" , "linux-ext4@vger.kernel.org" , "Wilcox, Matthew R" On Fri, Apr 15, 2016 at 11:24 AM, Jeff Moyer wrote: >> Moreover, we're going to do the full badblocks lookup anyway when we >> call ->direct_access(). If we had that information earlier we can >> avoid this fallback dance. > > None of the proposed approaches looks clean to me. I'll go along with > whatever you guys think is best. I am in favor of wrapping up all that > duplicated code, though. Christoph originally pushed for open coding this fallback decision per-filesystem. I agree with you on the "none the above" options are clean. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org