From: Dan Williams <dan.j.williams@intel.com>
To: yang.shi@linux.alibaba.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: dax: add comment for PFN_SPECIAL
Date: Thu, 27 Sep 2018 14:08:51 -0700 [thread overview]
Message-ID: <CAPcyv4jvmTUUgVXd7gCVcmMbOM0OcY8rTQGkp+Ak1NHpi+zS_g@mail.gmail.com> (raw)
In-Reply-To: <1538077089-14550-1-git-send-email-yang.shi@linux.alibaba.com>
On Thu, Sep 27, 2018 at 12:39 PM <yang.shi@linux.alibaba.com> wrote:
>
> The comment for PFN_SPECIAL is missed in pfn_t.h. Add comment to get
> consistent with other pfn flags.
>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
> ---
> include/linux/pfn_t.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/pfn_t.h b/include/linux/pfn_t.h
> index 21713dc..d2e5dd4 100644
> --- a/include/linux/pfn_t.h
> +++ b/include/linux/pfn_t.h
> @@ -9,6 +9,7 @@
> * PFN_SG_LAST - pfn references a page and is the last scatterlist entry
> * PFN_DEV - pfn is not covered by system memmap by default
> * PFN_MAP - pfn has a dynamic page mapping established by a device driver
> + * PFN_SPECIAL - indicates that _PAGE_SPECIAL should be used for DAX ptes
That's not quite accurate, I would change this to:
PFN_SPECIAL - for CONFIG_FS_DAX_LIMITED builds to allow XIP, but not
get_user_pages.
prev parent reply other threads:[~2018-09-27 21:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 19:38 [PATCH] mm: dax: add comment for PFN_SPECIAL Yang Shi
2018-09-27 21:08 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4jvmTUUgVXd7gCVcmMbOM0OcY8rTQGkp+Ak1NHpi+zS_g@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).