From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A89AC77B6E for ; Fri, 31 Mar 2023 17:47:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 904636B0082; Fri, 31 Mar 2023 13:47:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B4CC6B0083; Fri, 31 Mar 2023 13:47:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A3876B0085; Fri, 31 Mar 2023 13:47:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6BE9A6B0082 for ; Fri, 31 Mar 2023 13:47:28 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3303CA0D0E for ; Fri, 31 Mar 2023 17:47:28 +0000 (UTC) X-FDA: 80629925376.26.C7CC24D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 508E3A0012 for ; Fri, 31 Mar 2023 17:47:25 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PYEVYWIV; spf=pass (imf25.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680284845; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=agncQKz6RRQ+z2AndB9egaUCjOR2XStw/8eDPUmcjT8=; b=GB83IAe1v2eY4EgPCtOf3EQUeik85S7IJ385bY2Kyzj9ut0xQtKsmaeWtm9jpQ2A/GSVNE OOv8anZaChEBl379FQDywytvanrU7G2SLknszE9i+24YwuNpEccq2QBnZYB4etYh/SFb9a S58926vZHJEhlCyztAZsxSAVjdCILdI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PYEVYWIV; spf=pass (imf25.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680284845; a=rsa-sha256; cv=none; b=06Jlnze65QPA+y8b8wLPrWDQ0FXRgiO+qZ11wLNTI9pV8M7tVyhixoWtEu9rBzhRL3gWIA kTlu0K4HqBO7p5sC6hjtNJtZw65uFsxAFoIf0lkELm1IO5Nf50DbNr0792RgG+JAR3wCZK AteN3VZ1qPQUB8GlnzO3CLZWOifCNSo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3337162AEF for ; Fri, 31 Mar 2023 17:47:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91094C433AF for ; Fri, 31 Mar 2023 17:47:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680284842; bh=agncQKz6RRQ+z2AndB9egaUCjOR2XStw/8eDPUmcjT8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=PYEVYWIVUH7dS32tobiqHPv8N06Ir6XV+fO/AkMI4o66gPCmRSQrPmB/62RJDCjRX iha1oZWcgsdLkZM/rC/W4UwfQyPsdCwFKNrqffhv/EmPvwZJeb3/ObjFsJC5MhDerl 6Cx7gxJLQOUG+zb6KxBg5qAHVQuMVVbqwicLztbutfgto8W9OzeTQAoEfC9vYWb3/6 WbIN0UoYXvJIMjz85vPFsRQBCcHBixj1M8VbsRnNKUNQKfu4VoW2MuoVPGJO1e3WM0 lskThRRIawrJ3Oyv3wDs0wMu+dVhpxnIUfenisVKNRTUmEG0HLG5WxSjGzb6R+Ni/e jLYxlUQypWhrw== Received: by mail-lj1-f170.google.com with SMTP id q14so23881014ljm.11 for ; Fri, 31 Mar 2023 10:47:22 -0700 (PDT) X-Gm-Message-State: AAQBX9dhZz0yuEo5OscyNDXUrjj0juaCN1KaBZl3r5ak/P2mzggrdD7k 2RR4LC5wkT56dS94Kj5BNtDd1AdtfNhnj/ohfak= X-Google-Smtp-Source: AKy350YsVC49X4YKPGPcvZZvpV/eK4Pm1deoqn4/arjrTKATbsjiI11VNkB5amsOZg1wLI0Ovo0EsryvUkWIU3e100g= X-Received: by 2002:a2e:9d16:0:b0:2a6:16b4:40a2 with SMTP id t22-20020a2e9d16000000b002a616b440a2mr2329769lji.5.1680284840437; Fri, 31 Mar 2023 10:47:20 -0700 (PDT) MIME-Version: 1.0 References: <359e6d4d77ee175e2ce7c315a3176ca360e10fbc.1680172791.git.johannes.thumshirn@wdc.com> In-Reply-To: <359e6d4d77ee175e2ce7c315a3176ca360e10fbc.1680172791.git.johannes.thumshirn@wdc.com> From: Song Liu Date: Fri, 31 Mar 2023 10:47:08 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 05/19] md: use __bio_add_page to add single page To: Johannes Thumshirn Cc: Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org, Damien Le Moal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 508E3A0012 X-Stat-Signature: g7n3snwtq478c53cgfwcqe6kzekhc1t6 X-Rspam-User: X-HE-Tag: 1680284845-449115 X-HE-Meta: U2FsdGVkX19BZZ+srl5pdhG74dG4MlpghP1j7p5DSpJVXXyWat6Rli6s57Jlv+Rg1rdaxhy+pB3jTcMLZdJONxIeYt6ab2I8PJdnjYMUpbaRTds3cF5jssddfgddY778UhoR7IrT054jiZgmPDN4RoLcgDiVUD+IQk4FZAK00HeikGHNUZk4oTMygZX09p+y7Govez2u2lcPVVdIZ/Bxfu2++AYP1ZW4BmTlbs5XlthChEXidhs3384i5whyt6h22YKoiix3mN5luj2bphgjqHjpANWW9sBMxEUMGRfafhfbgukjANIH+eRSDDGp/54oltOlqxsVP9maiFkKldKeT7Akhwky39U2mwmTSLhAjt/nBdqjP+679liha7KIMAPOLMU9P9Fxz2SSeBEhjb5rpL20+//oyPEf9rJGNmX1VcVoCHf1ll9pZiPYubLRQnxTozXXmsaN9SqvSjP5oj4BOlGsf/EG6JFx2AYezRRviPTbedeZWqw8mb9DRPnXbRKiEfS77f+ItZRuu2aSwuv9BrPl/ra/HKM+53d/VD9Xiks++Ogt2+p1CREHPsao9eTbKpk1TfVX59s5cDuGeJlQ+Evl8UA8iXL9f6TshcfyoZggUwvCPpFiPo0lGq88uLbMwFX9/Zjhn8iU9sqcDEtcEK3nZ43jxZLcFE6+W3bfJAnD2gcutQ7qSfkPh6mANEixvE3qNNoxajbtM2DZhwgcG5b4jctqoMvvHqsHy/eNZTFuXRLJO5ZG/EftI/eykVmKXzAhWe1bF4MDED90UtNjwNNwFIeBZfXCzTfij+6b4KqTz7GD1tQTQCilhHlhb4cTiMxj3SnUkR0l8HUOP4Oj2kaRP1Mqudzvmuk5e/0UcoEh5o/IKb6whayhNPxYjWXZDKZDZ62EODZfT6+Yz3gjSvdLghHbxdOYuS7JsRXYZRxOcJgN27CcjhY25PAh7Xjc5iIXptg1h2LIosFFHZL LXPKKvMr AVhV5r64VpPE26AFgPvfx/6dE2hVN9j8hsbUxOkuYqRnVgSg8I12tTJ1k/afPLU3plSgOFXndNOTGm/Cz1hWQHUgeiQ4ARGv0vqZ+es66xmHNS2yDA6O8a4XmNWf2E1b6JmtiqKT/g8t1hOQv2TbEjDefxzN+dAfA4qdr8xLw434TgpcXEHhWi3cDAT1mM2d6h6QxL7/htwCwHpjnkKcJjx9XJJdSCDQL9hL6MCCo3CtQQ0HB40thUO1RQ0RCvAq4o54YP1Jvu+mGcHUZZbn3bXoM08PjvttKnKV6pmyi8idq9IvVH/c+NBRqOpnOPpUu9l7DhcV5yPf3zbBeO/d270NWrpFUwftFWs+32Vbz02uBWh+svENOxjReD/2C6hMUtv+aOdn3HQcsQzS+ubBAtDc/lL2xBYOUoLq2bUGqHzBxeD3vH8oAhyjKmBcjM0YF2lFTB0UjMRWyH34= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 3:44=E2=80=AFAM Johannes Thumshirn wrote: > > The md-raid superblock writing code uses bio_add_page() to add a page to = a > newly created bio. bio_add_page() can fail, but the return value is never > checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-of_-by: Johannes Thumshirn > Reviewed-by: Damien Le Moal Acked-by: Song Liu