From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EAB2C36000 for ; Thu, 20 Mar 2025 22:24:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6F65280002; Thu, 20 Mar 2025 18:24:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF84F280001; Thu, 20 Mar 2025 18:24:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9973280002; Thu, 20 Mar 2025 18:24:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9918A280001 for ; Thu, 20 Mar 2025 18:24:36 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E445BB8AAA for ; Thu, 20 Mar 2025 22:24:36 +0000 (UTC) X-FDA: 83243359752.10.85D5106 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf21.hostedemail.com (Postfix) with ESMTP id 8D58F1C0007 for ; Thu, 20 Mar 2025 22:24:25 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=Z1Uuc7ym; spf=pass (imf21.hostedemail.com: domain of rkrcmar@ventanamicro.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=rkrcmar@ventanamicro.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742509465; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M3HA3HoJNZW8enSnrAqrQ3Y05aO56vxfDpg3v9Wkt6M=; b=Va4zDngbVTDKHVfz7VI7V9BpKd7I6Ho2usgy+/i8ur+3IN9FwKBeDyq7PxocXiBjDo2Lea RjWus2rL1mR3xTaWsX8UMpYC4eVcw50tUIvlSSPjDvC97yacIXWj3zs+BS170xN+DxCdtN vJcrNIwd4LlJMCtggkgn2V65XyQz4ls= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=Z1Uuc7ym; spf=pass (imf21.hostedemail.com: domain of rkrcmar@ventanamicro.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=rkrcmar@ventanamicro.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742509465; a=rsa-sha256; cv=none; b=7KJamHnlWbwhxmAPRnPTQ+fTNQSNLsvjtgteujET2IjSfeYaZhk/KxV9ph4Y2wVNiM3fOT grFTmPX0PoWFzm8wk3tEP3yqra27FdMHL1kq9AFcwpWTqbte6ISEWrhjpae4YC2ogZBSld 66SUrzPRVU0UqPOLAXMDIThdH58ECnY= Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43ce4e47a85so1539125e9.0 for ; Thu, 20 Mar 2025 15:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1742509464; x=1743114264; darn=kvack.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=M3HA3HoJNZW8enSnrAqrQ3Y05aO56vxfDpg3v9Wkt6M=; b=Z1Uuc7ymgAnADtWmR+Po5bhb9+UZ4oi5AT/rjx8c3eJjBfrHLXg5vDGCtGuMWAEHQm Zh1gpbRiHvNy0jCXFlO9Z+bsuKt5gFwfyproxI6MqIMlpYcoslYZ8KtdNl37/UXbYWJi bti941R00lG1DJds0PQHK52rc3Q4hl692uVTkEAH2X5/dCvZtmFBuF8wx1155033rZjx HdknF6pAWGYx0dUl5UFxS0nHRc0C9TWl0S5BT0DbeAwMXG9XU1JVinS7Zo8OH4gOaQQD IxXgVTot1kuD0wkOnBlVKLL+mqKD/ce5n+iLFBlQPfUrdnCupYFDhgg5WLb0HX66bxUj gS8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742509464; x=1743114264; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=M3HA3HoJNZW8enSnrAqrQ3Y05aO56vxfDpg3v9Wkt6M=; b=md9FCOk/DDbjal4gdF6fVm2B+n/iCfmH+0sHgLKzHFxI3vUt0fau1kp1p//0cCuYAi n2sCrQ4nxso5W2b+9UuwTAdq5E1ppOXRITq/v5o2ZY8+i4+gWzLSBLrnVxkVgEWAOPfN YmQylCUutbD1Lq3uRRRqzVknNp8VX/ApeDe18il6n1tttLFj075QNPGepOkl3IcwyYaB 3tixvwmh1SHy0nZ6fdJP0yun4JBObq9/bEvU7IlLQQTk7rDmgyA1ZCAZDVuMhjnKqCqG L+58whO8VZyNv11HCgZmYw2qGID0F5Th6pscyiTCHCGoS8oH9ACsZM1uykzONoRWQORK teig== X-Forwarded-Encrypted: i=1; AJvYcCUaJwfcVwEkRIrAW6u0MIq/13bD93Uj7FgjLN26yl5nyUqW0FSqdSA+A0d4oKhVnjznoafgqTMecQ==@kvack.org X-Gm-Message-State: AOJu0Yw3OHtcmRkwVCOrnYQ0otTkLCLosjf0lyKWltCiss54XhLx/+dH LX5TC8fSjWgjTPF5RHP3ewl8d7hdaFnV4YLe+hwlfIbrTrgru1ltWL8hr+Hjg1w= X-Gm-Gg: ASbGncsf14iysBbSqH+fSg1ar2YYegsbLgfNnAlYJyvG4NvwtABbzd2DgCxKVMwsxCX i+QSz/7AC37mop/AkO9l5eUCFLElts/ZE/v9IeCf9DUXM1HnlZ1KmEFDfYv5ljyZArDl9IuqXXF L56mfpe/2HRxGA8RJezSKe0qX1E5QoPrltyaaGqXwoPMbM7UVOrWWOBXvlwlIZ+QSEGG0tEZTUv LEWFPSVjvQBLuxYCtR2J8gsslJfw+drPc2cpAyaPyH9QQQD85xiSP//+B+qrG3HkdqIM1HMBYpn 0Vndyhs8zmgQ2JBji1nEAiPOg/QZur7JKNrzebwzyeo6t0SX489FUjvQvmM3HJjli/cPbnX/zh0 TYC4v X-Google-Smtp-Source: AGHT+IE69CkeFEj88CLeab7klKRoAawBZazbHPIMjQcfhs1Va11jKN4uP0xkM8FxO9at+ieqUDxG0A== X-Received: by 2002:a05:600c:3110:b0:439:9a5a:d3bb with SMTP id 5b1f17b1804b1-43d509e428dmr2353095e9.2.1742509463811; Thu, 20 Mar 2025 15:24:23 -0700 (PDT) Received: from localhost (ip-89-103-73-235.bb.vodafone.cz. [89.103.73.235]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d4fd9decbsm9222955e9.27.2025.03.20.15.24.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Mar 2025 15:24:23 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 20 Mar 2025 23:24:17 +0100 Message-Id: Subject: Re: [PATCH v12 19/28] riscv/ptrace: riscv cfi status and state via ptrace and in core files Cc: , , , , , , , , , , , , , , , , , , , , , "linux-riscv" To: "Deepak Gupta" , "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , , "H. Peter Anvin" , "Andrew Morton" , "Liam R. Howlett" , "Vlastimil Babka" , "Lorenzo Stoakes" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Conor Dooley" , "Rob Herring" , "Krzysztof Kozlowski" , "Arnd Bergmann" , "Christian Brauner" , "Peter Zijlstra" , "Oleg Nesterov" , "Eric Biederman" , "Kees Cook" , "Jonathan Corbet" , "Shuah Khan" , "Jann Horn" , "Conor Dooley" From: =?utf-8?q?Radim_Kr=C4=8Dm=C3=A1=C5=99?= References: <20250314-v5_user_cfi_series-v12-0-e51202b53138@rivosinc.com> <20250314-v5_user_cfi_series-v12-19-e51202b53138@rivosinc.com> In-Reply-To: <20250314-v5_user_cfi_series-v12-19-e51202b53138@rivosinc.com> X-Rspamd-Queue-Id: 8D58F1C0007 X-Stat-Signature: qcpwnmc11a16dcwk6czpimhmzifohkm1 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1742509465-777071 X-HE-Meta: U2FsdGVkX19Z7/cIRFRUsrX0pv7+u8GQxvOeKmI92scpHcdmxxRcEdng68HQiSyOE+hMXxfSHoNCxxvqsU6tAFpC0/1GV9gK6OWepa17uxF4FFNlZxgjDcglUGhoKUy6JeXC5d/ltgbkGpKaVd2Ku5xb9M4CaEcGb6jcsH/PHrYaXnggw0ULAyw8xvhwRWcg8Ghvt3RY27VN7TTQb8sOzwY/lcCvYQbwssRFU3GVu/k95TjPAdNxHyxv/PgHYLevWveZoSLj3msFcm+RhSGoD0SoGYVdNLJh1nFXCqO9wJ9kwAymMoZ3f1cr9bD/QFDAOvsU++yYoFvVnlNxpqQnfWnGfWcIj+Li70QWBSZuo264d2d5N4z5ARB3qy/ylkZUVTM7WTp7sKLJa3xyy3aJu+wOoTYvBitJrnupqcSWjeGySrWH+0BtNPbj+ch63CCWgCN03IuhcfaXjdpoTt74K4iPEDECzr9TgeLJnPn23KVlwXXMiGKYFXsSPDrz+TrPmh7tfyfhwM4IAyy7bgy/3V1an+Isd+Pvq9oxJRf3bjjBIuvMerR8jBNNqS6iBZq4J+FVakdCQuMeZBSlGFNoSH6rcFnMyXSSjQTNCZYDjKZeIUd+GvD7rqkSy42ymbwqqIJu6bdrXxC+9e+UaBTG/iIl2m3/17V2dbKJne4qVMZv9ee/uciUjwC5suiKr+/wmcRIy2CxuAc2simSeIIlMzAHesyrW+48NjbmJSlgA0UN62yefEkT4bRWtGgk7EGGDpyO2gkm4A3+B7lUkhSPUV0ZUDwthOe/fHRG04ab9VuDcnleqsOfTQGO/8jfltKzIZL2Z14j0os0od/DbXA0xTOCGMyRoofP5s111ay63lHRmmYivtn8h67zJwHihRUi2LiB9Uib2PqqGACbjVN+Q/mGiBRGQvrU2KRMHBFSL10G63q51XNC7X6WPUZa+4M5lrBsnJAuEG1c4BdxohK QxhNYuU7 80UVt9wqnBvFFYRPv70nCa8IHnhfSwz44Q9kil8LsjQya3OYKVP9ZQRhx5HCtaeZ6YQsIdbZkTU8swrYBxAQJqUe1WfOKUZdiUy6inddq7Ktrj4JWdEuyTzQrbC7MdAPrkdQmT5vICMq91AxdscmAKHoLVorFB90GZFHgf0x/WNTRvfvP9GIcUDx2/9aUs4GLxnJWSuxdebuTvgWe5OoVW2W8Oc6HxoLKHmNbIlRKEGJzKwxNc90YxTmIgxUrFgRCtNzI/wyMWBWTxmkg57XvRzMW0CCKF36UTq+BOXMYspwyPv8L2YHOTZaHf3c7XnPg1TWYCjSueqCBSkFwXZsatpobHHX1qh2DEBFOnPctE9znltuFgd3/7nUd6rkowVtHmy2WByFR/Mx7vCWJQLGQOJcdvmAFBTDOUOqkHC9QyRv5EOgxrdQ/JpAz/uW8HrSK+nC8EwAjBcVNaW3zjfWilRA5C0v6S5fdLsslbMRZsVlgRXWrgG1288EKNB+FrBijnoK6oR7BIftgrBWSQm6OlmxdD12itckyAPK/gvK7MqPjKeF2d/msfKTVtbYp5JA3C4pmSYg3ovscv2C2BapA+yuXqYoCkUWRuTXG9m3D7wiqTxE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 2025-03-14T14:39:38-07:00, Deepak Gupta : > Expose a new register type NT_RISCV_USER_CFI for risc-v cfi status and > state. Intentionally both landing pad and shadow stack status and state > are rolled into cfi state. Creating two different NT_RISCV_USER_XXX would > not be useful and wastage of a note type. Enabling or disabling of featur= e > is not allowed via ptrace set interface. However setting `elp` state or > setting shadow stack pointer are allowed via ptrace set interface. It is > expected `gdb` might have use to fixup `elp` state or `shadow stack` > pointer. > > Signed-off-by: Deepak Gupta > --- > arch/riscv/include/uapi/asm/ptrace.h | 18 ++++++++ > arch/riscv/kernel/ptrace.c | 83 ++++++++++++++++++++++++++++++= ++++++ > include/uapi/linux/elf.h | 1 + > 3 files changed, 102 insertions(+) > > diff --git a/arch/riscv/include/uapi/asm/ptrace.h b/arch/riscv/include/ua= pi/asm/ptrace.h > index 659ea3af5680..e6571fba8a8a 100644 > --- a/arch/riscv/include/uapi/asm/ptrace.h > +++ b/arch/riscv/include/uapi/asm/ptrace.h > @@ -131,6 +131,24 @@ struct __sc_riscv_cfi_state { > unsigned long ss_ptr; /* shadow stack pointer */ > }; > =20 > +struct __cfi_status { > + /* indirect branch tracking state */ > + __u64 lp_en : 1; > + __u64 lp_lock : 1; > + __u64 elp_state : 1; > + > + /* shadow stack status */ > + __u64 shstk_en : 1; > + __u64 shstk_lock : 1; I remember there was deep hatred towards bitfields in the Linux community, have things changes? > + __u64 rsvd : sizeof(__u64) - 5; I think you meant "64 - 5". > +}; > + > +struct user_cfi_state { > + struct __cfi_status cfi_status; > + __u64 shstk_ptr; > +}; > + > #endif /* __ASSEMBLY__ */ > =20 > #endif /* _UAPI_ASM_RISCV_PTRACE_H */ > diff --git a/arch/riscv/kernel/ptrace.c b/arch/riscv/kernel/ptrace.c > @@ -224,6 +297,16 @@ static const struct user_regset riscv_user_regset[] = =3D { > .set =3D tagged_addr_ctrl_set, > }, > #endif > +#ifdef CONFIG_RISCV_USER_CFI > + [REGSET_CFI] =3D { > + .core_note_type =3D NT_RISCV_USER_CFI, > + .align =3D sizeof(__u64), > + .n =3D sizeof(struct user_cfi_state) / sizeof(__u64), > + .size =3D sizeof(__u64), Why not `size =3D sizeof(struct user_cfi_state)` and `n =3D 1`? > + .regset_get =3D riscv_cfi_get, > + .set =3D riscv_cfi_set, > + }, > +#endif [I haven't yet reviewed if a new register is the right thing to do nor looked at the rest of the patch.]