From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD62CC3ABAA for ; Fri, 2 May 2025 12:18:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36B786B008A; Fri, 2 May 2025 08:18:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31D8E6B008C; Fri, 2 May 2025 08:18:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E36F6B0092; Fri, 2 May 2025 08:18:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0178B6B008A for ; Fri, 2 May 2025 08:18:17 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A0479CC736 for ; Fri, 2 May 2025 12:18:18 +0000 (UTC) X-FDA: 83397870276.03.5070A1F Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf21.hostedemail.com (Postfix) with ESMTP id C393B1C000B for ; Fri, 2 May 2025 12:18:16 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2mW6CPUi; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of 3B7gUaAgKCBI1su24s5ty66y3w.u64305CF-442Dsu2.69y@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3B7gUaAgKCBI1su24s5ty66y3w.u64305CF-442Dsu2.69y@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746188296; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J4EIqRH8s+HJXS4njQ/v+2ek79fyo/PhNx8U1JoTIak=; b=18tuai4EXufe0mSPbrp7wLuXZi9OwcWCUEdhz3s5YK2sd5A2XV4ORgDK4oYz6uaLbpgs2v pGHNTI8eQdC0a2A1AEuVnlWxmxmdkUVNm12W/YSEekIIGQlUIVaxzbl8IC8K7hieNAi1P7 LhV9+aaY+O4mP1UB62dYHgChRTbyyAg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2mW6CPUi; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of 3B7gUaAgKCBI1su24s5ty66y3w.u64305CF-442Dsu2.69y@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3B7gUaAgKCBI1su24s5ty66y3w.u64305CF-442Dsu2.69y@flex--jackmanb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746188296; a=rsa-sha256; cv=none; b=0UrbQ19vvAiaYiXzzVHfbIktblMgc8yTJfsUy1QO09+gKWtE+fcJVnuVWdjzB/VB4QW+5U vH9lw/DB1OheKNt+LTL3XLn+DcWENPcXTbufKGER207ktGBOBiskK+NL9Umu1rS/7goyOs 6NHtipu6SnUJ+smuAJwmlePUVhcTP0g= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-440a4e2bad7so12328045e9.0 for ; Fri, 02 May 2025 05:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746188295; x=1746793095; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=J4EIqRH8s+HJXS4njQ/v+2ek79fyo/PhNx8U1JoTIak=; b=2mW6CPUiBvhwkGWVO8mtuWMSsBAMhkEsyve5/AtqPWumLHvW1RjCdvKIRrj0qQJIyD W4+aN2lAUPgGtLc88Ifme4DWtvqRqFuKKTUIDzpcZkhuJsEc4fVnHUDO0yTCnwrdkiaN XJAeIzGBWbwk4/zI04ZjKSv2UFsmoT2RZGq0Uhmc9THv8pQr6wrKWf4g9DAbzaMDPWM/ gkoPJ2Yv7FgtJAxCYxaH+w2bd3sFFHiyj7AcpUnsqvGn81gsaZEzrWhkllUrRx+pfNoP IKr8TmwxIpK6xNbJbTMmxsgly+itSHzCiOac6EkYwJ4R3Ps3ZSIN8qwRc+rxs8cQA5XJ LhCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746188295; x=1746793095; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J4EIqRH8s+HJXS4njQ/v+2ek79fyo/PhNx8U1JoTIak=; b=EXz81yP5xtzrCe6JBu8r1DgzWq85HsR12xYgGZue+YUPNPApK9x7JkKalDMnm3mi7X 2lhNOwt61XeRa9dta2ZLxjTWM7ro9QcwcCpTDbo9jdP4l3Ji9Rf/NUkLn05siupVcs7H 9YIQIhkl9oOo3U4+x3YsNT/AQi7MCgL42xoJD7MATfoqbt4ZFhZd+XnjoPGRvg/NdxJb 1z8FaWbZWJcc/EsTSQWAYs6tLWxzgR2NdeTTTGjGoqBZbcmXG51FjIvuACgLwSehwKCp TugqQzTqhTP5ZvJxP/p7X1dseLLmgEXKkNq0eJr5jG3MFYPoJcls3nASyfVX/JMkpJaC V4eA== X-Gm-Message-State: AOJu0YzftSuNHVKniPUwuTc2sB2DHcFW3GHKte6BVe2GvnDRC1keWaBW jTVh0TbeJCIxgnDN2q2vy6WBWOrGE30090cgqyoJwwJ4w8Akm1wOQQ1piyLENUP9Gq1squu+OMI eO/0OoiGFlA== X-Google-Smtp-Source: AGHT+IFmoIah9vIU+ME6LTH3yaSoPOxR0iqcuVmJEVttYxbVNA2iy85jqW8QzQsVUdCyB+30OgU962ian6s4pg== X-Received: from wmbjb17.prod.google.com ([2002:a05:600c:54f1:b0:441:bf4e:899c]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:8711:b0:439:5f04:4f8d with SMTP id 5b1f17b1804b1-441bb88d42emr21008445e9.12.1746188295600; Fri, 02 May 2025 05:18:15 -0700 (PDT) Date: Fri, 02 May 2025 12:18:13 +0000 In-Reply-To: <20250501163827.2598-1-ujwal.kundur@gmail.com> Mime-Version: 1.0 References: <20250501163827.2598-1-ujwal.kundur@gmail.com> X-Mailer: aerc 0.20.0 Message-ID: Subject: Re: [PATCH 0/4] selftests/mm/uffd: refactor global variables From: Brendan Jackman To: Ujwal Kundur , , , Cc: , , Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: d87dq4spkg4euifbxpkfd78kxjty4gbg X-Rspamd-Queue-Id: C393B1C000B X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1746188296-873957 X-HE-Meta: U2FsdGVkX19vgLk/W2yQezvAnIUhcnPnJzBms728gl1TeOFJ1s/BIpC+V8Y96OwiQD+XfO27VdDUZrAOpFCAeiWMk5Gf3BVoa7oQAUg+yZURAfKW4InkarSLYFx6eWZpqilMIojJ4fJ2R3J5R9j+5D4oU9Gn0QriBf5BOFqF/A2+hLpMUXb0bJfacLc7s+T/OOs75XD8wCuG5WHhWR35UEDA100g179Wr/N31UIbkdWBjMLU49avA7IuK+h0MH971F9IsnfBRYdUjcja8bZPOBtSqnusC30aJT7UDCmX8GBTXZ1ht0A1F5SJoEI7hX7vrHo1x/m1bsr0z700yScPlOUgYBonazl71fB7RCcCZtKarAvky6SHhYl7TBKWMnvBZUHuFGeXCmWkPPwcSE50fMBPNmbvDulspqp1wynyCmqUvCQDmJSTIFfYyxH+R66Dkm9Snl4dB85HZR3M5kQEEgmi46bxbfSTUQAkRLGmxmj21vJNTTbGJvzGnebvGND368qPpwFM+uhdD9YPo37R2UE1K4YrQYkZU8QqfiT9Lg4WJessCulgkIZ5Cn+CkT59RIvMyqCZZdTJXwKd873eelqGKa4lXc+dbqjL1etA/nn2B8wYbC8noE4nSu72XumHGFzC4KI3HKSsrFgrDTnvCH+7d3T5wcRtyN0+j9s/VnteQX1Jx9LEyR726QUOqZgcIQ8Ir/ChSVoGrN+s+OUXyuZboaoEQ1wETCvHpH5HW+7OURJamKWEFjPEAJyhH2U7CKN49wcrrBzryUP105BMlv9/DDcdRo8KrZslVERD6IDbtAp7aogRvXHfL0rrgi+T5DS9B+7hxvrp44fwvMGrtg+f8nn2eAzLLqqdC0iQ0sBQTk3sYKo6aU68zU5ft4jYXKLfCt8A8+kt/nQSoOyN8DvcJIHU//R76BwdBqc6RBZ8WubaD6tf2cChzNRopY4r16UBjDI1dehSTX62Fkf w6CH+88r NQBMXE1BGsgSlkjm45ecbV/TnynS/inW4OqcxG7iRHQ1GL/1TCBioZkmQmywiM82mWlNgkAWyudBs7yTqB+vUVRaHA+MzJShLKwCHG6XbwKYwxbTz857ZyYScreQWLVHBiAcv9HI0T/ZR1uWclJqkJNVjNqqEBa5lMynvxHLT8u7J3T5GAgR4uuIs8mKM5+LRFAS6GcOESKbJYjYvUAajua2isxL9KuFDfHnMm2elh/UFvpJJdfnigemiXXXlxvTYWC4xOvY3asbk2enO+q8gr0psQqXjezAAzc+7rImi8jLoEb4iZWMxkhMO/m7CM0M57/orPEqBt3aVj9IHlMB63Pyh+OqS8QG74qjGcMVuEgExdjoTFFzerhVVaZOb0QXC2uriQ9ZUL3Jon7qUSC+oaRFJTJFSh5KHnZrJ6l604JwP7cYMgek70k3x6Q9S0VUE81jezrNgSEPpFVDRTbXntwdWb5A1hWo7wZtCi+6x0RvgoB9o8DezEiVITSv3Gez/NG9aEwyWYiroax2MAZop9SHOJcZ+1GFALGmjTQ4ICC0X0tT0aYoCTphBin/ifIPQiPzJaQpqcufngjVa5dSnqX/iomHuOP0vMeCsJRTRz0F4hn4TpWs4lIJwvBbFdG9nk+Ke2pHoIx0m0cN55jffsdYStqlEs3rJNqAZmpuK5RA8DOIKs5eqYcl2+GHXO6NLfoAqqmGHg4Ixg/tEbJVis6AFdpkGLFrbEXFMzoWjIeokjcRAP1l46gA3Xi9x+SEFw+qPtksk/m9XXCGK6i3M3Yb9VHJAZ1ySkKa0svhLSZRRPDK97IDmcsRiryfPqpGKcdG/2WHzcBjoG2U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu May 1, 2025 at 4:38 PM UTC, Ujwal Kundur wrote: > This patchset refactors non-composite global variables into a common > struct that can be initialized and passed around per-test instead of > relying on the presence of global variables. > > This allows: > - Better encapsulation > - Debugging becomes easier -- local variable state can be viewed per > stack frame, and we can more easily reason about the variable > mutations > > Patch 1 needs to be applied first and can be followed by any of the > other patches. > I've ensured that the tests are passing locally (or atleast have the > same output as the code on master). > > Ujwal Kundur (4): > selftests/mm/uffd: Refactor non-composite global vars into struct > selftests/mm/uffd: Swap global vars with global test options > selftests/mm/uffd: Swap global variables with global test opts > selftests/mm/uffd: Swap global variables with global test opts I tested this using this script: https://github.com/bjackman/linux/blob/523e40a88fac34b17f49614dfb24fd5e18e63685/.github/scripts/run_local.sh After manually enabling the userfaultfd tests (I disable them in my crappy CI thing as they are flaky): https://github.com/bjackman/linux/blob/523e40a88fac34b17f49614dfb24fd5e18e63685/.github/scripts/test.guest.sh#L15 So Tested-by: Brendan Jackman