From: "Danilo Krummrich" <dakr@kernel.org>
To: "Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>
Cc: "Vitaly Wool" <vitaly.wool@konsulko.se>, <linux-mm@kvack.org>,
<akpm@linux-foundation.org>, <linux-kernel@vger.kernel.org>,
"Uladzislau Rezki" <urezki@gmail.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
<rust-for-linux@vger.kernel.org>,
"Liam Howlett" <liam.howlett@oracle.com>
Subject: Re: [PATCH v11 0/4] support large align and nid in Rust allocators
Date: Tue, 08 Jul 2025 15:41:31 +0200 [thread overview]
Message-ID: <DB6PTHLBMET8.2TN916HUP10X9@kernel.org> (raw)
In-Reply-To: <8a08931c-ce54-4e96-9e99-e7c696389dc3@lucifer.local>
On Tue Jul 8, 2025 at 2:36 PM CEST, Lorenzo Stoakes wrote:
> TL;DR - the real issue here is not cc'ing the right people (Vlastimil was
> not cc'd until v11 for instance).
Since Andrew was Cc'd and also did reply, but didn't mention anything about
missing receipients on the -mm side of things, I did not see a reason to bring
anything up regarding this from my end.
Thanks for bringing this up.
> On Tue, Jul 08, 2025 at 01:55:18PM +0200, Danilo Krummrich wrote:
>> On Tue, Jul 08, 2025 at 11:58:06AM +0100, Lorenzo Stoakes wrote:
>> > +cc Liam
>> >
>> > Hi guys,
>> >
>> > We have a section in MAINTAINERS for mm rust (MEMORY MANAGEMENT - RUST), so
>> > it's slightly concerning to find a series (at v11!) like this that changes
>> > mm-related stuff and it involves files not listed there and nobody bothered
>> > to cc- the people listed there.
>>
>> What files are you referring to? Are you referring to:
>>
>> rust/kernel/alloc.rs
>> rust/kernel/alloc/*
>
> this ---> rust/helpers/slab.c | 10 +++---
> this ---> rust/helpers/vmalloc.c | 5 +--
So, your concern is about those?
> These are clearly specifically related to mm no?
Yes, and if the maintainers of slab and vmalloc agree we can add them there.
But again, they're just re-exporting inline functions and macros from header
files, which bindgen does not pick up automatically. They do not carry any logic
and purely are a workaround for bindgen.
For instance,
void * __must_check __realloc_size(2)
rust_helper_vrealloc(const void *p, size_t size, gfp_t flags)
{
return vrealloc(p, size, flags);
}
works around bindgen not picking up the vrealloc() macro.
next prev parent reply other threads:[~2025-07-08 13:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 16:47 [PATCH v11 0/4] support large align and nid in Rust allocators Vitaly Wool
2025-07-07 16:48 ` [PATCH v11 1/4] mm/vmalloc: allow to set node and align in vrealloc Vitaly Wool
2025-07-08 12:12 ` Vlastimil Babka
2025-07-07 16:49 ` [PATCH v11 2/4] mm/slub: allow to set node and align in k[v]realloc Vitaly Wool
2025-07-08 12:52 ` Vlastimil Babka
2025-07-08 14:03 ` Vitaly Wool
2025-07-09 13:40 ` Vitaly Wool
2025-07-09 14:13 ` Vlastimil Babka
2025-07-07 16:49 ` [PATCH v11 3/4] rust: add support for NUMA ids in allocations Vitaly Wool
2025-07-08 12:15 ` Danilo Krummrich
2025-07-07 16:49 ` [PATCH v11 4/4] rust: support large alignments " Vitaly Wool
2025-07-08 12:16 ` Danilo Krummrich
2025-07-08 10:58 ` [PATCH v11 0/4] support large align and nid in Rust allocators Lorenzo Stoakes
2025-07-08 11:12 ` Lorenzo Stoakes
2025-07-08 11:55 ` Danilo Krummrich
2025-07-08 12:36 ` Lorenzo Stoakes
2025-07-08 13:41 ` Danilo Krummrich [this message]
2025-07-08 14:06 ` Lorenzo Stoakes
2025-07-08 13:19 ` Lorenzo Stoakes
2025-07-08 14:16 ` Danilo Krummrich
2025-07-08 14:39 ` Lorenzo Stoakes
2025-07-08 15:11 ` Danilo Krummrich
2025-07-08 15:40 ` Lorenzo Stoakes
2025-07-09 11:31 ` Alice Ryhl
2025-07-09 12:24 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PTHLBMET8.2TN916HUP10X9@kernel.org \
--to=dakr@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
--cc=vitaly.wool@konsulko.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).