From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC30AC83F17 for ; Tue, 15 Jul 2025 14:33:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DD5C6B0099; Tue, 15 Jul 2025 10:33:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 463E66B009A; Tue, 15 Jul 2025 10:33:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 352696B009F; Tue, 15 Jul 2025 10:33:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 117326B0099 for ; Tue, 15 Jul 2025 10:33:31 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A8F6212E00D for ; Tue, 15 Jul 2025 14:33:30 +0000 (UTC) X-FDA: 83666742180.18.3E62FD5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id EDDCD140015 for ; Tue, 15 Jul 2025 14:33:28 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gIz5qjCs; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752590009; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wt7TlVHf1aKih23e2+DSj9BLDgJXV181urjOhvK5ZnA=; b=GwdOivf0IBi5/iwbeAm+t7Yi5TbshRX+nx4v5sQDP8xr2mlw2mQznZjL+Om6IfQlKK/Yww V5ukXQdYRvpHBDr2qUsoA+cbRzABSQbra/n2P1V4nIuOZmUytYxX/lTmNbjad8YvGbhUSB Wq9zGPuDjdkeQO61nEINUuuMpvn2AkQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752590009; a=rsa-sha256; cv=none; b=lJso2fRNVIl2wlLSShvf98cjqri7sCLE5SyegIubS7DQ/MdbtPhr/ZJ/4Z6K20DCOVQdvx KWFxhq/RIzoByUuwU7nUUHs0ZsGUAOj/hNCHbxO3Moq6BDSHjW72zfF5SN2r6gxryMTXfC 817lMrGGiawdtChpa4UmzczuWnlSnOk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gIz5qjCs; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C5CB25C58DA; Tue, 15 Jul 2025 14:33:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8386AC4CEF1; Tue, 15 Jul 2025 14:33:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752590007; bh=eQa8mNAlVqavYHMUiPZeXoF99a7nhAyYvF6Mw1NgSY8=; h=Date:From:Subject:Cc:To:References:In-Reply-To:From; b=gIz5qjCssM+llIhH6PvHDb8FA7i70zQlzt+e8lbo3FScMmpDPN4fCu4iD2UCoHHxa 6Ne9ufacuEEXwsqDFAo57hOVBL6hFpJ7m6VhSrGQBcxKI7MD0BuT1cPk4COrbYLWlE syOojojEapjjus5E5037StMekGujhTULPpN9gmlBdTaACw9XWofpJQHxmi1FVJQbwu 0vvPpn0oFH+0Ui/YeNJvKnQAda/3ujxcAmDu41bCww2eLacdIA0+i43fHDVIulAEi+ oo5bxLB1CvlS44nsCpg3MWT3KAwK2F2QIPtfYZjHOzp4mC8vmgWxFXkeIcMj/w5Bp9 Y8Arud/b8O5nw== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 15 Jul 2025 16:33:22 +0200 Message-Id: From: "Danilo Krummrich" Subject: Re: [PATCH v13 2/4] mm/slub: allow to set node and align in k[v]realloc Cc: , , , "Uladzislau Rezki" , "Alice Ryhl" , "Vlastimil Babka" , , "Lorenzo Stoakes" , "Liam R . Howlett" , , , "Herbert Xu" , "Jann Horn" , "Pedro Falcato" To: "Vitaly Wool" , "Kent Overstreet" References: <20250715135645.2230065-1-vitaly.wool@konsulko.se> <20250715135815.2230224-1-vitaly.wool@konsulko.se> In-Reply-To: <20250715135815.2230224-1-vitaly.wool@konsulko.se> X-Rspamd-Queue-Id: EDDCD140015 X-Stat-Signature: nzkxuqj1ruo33upxzi6mobgn3gm4edcn X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1752590008-229914 X-HE-Meta: U2FsdGVkX1+DWwBr5wxLM22MQhQwY8uZ2neezA9flAU55qjEkNjrd+mbG/nqSiw0gvNKHDrikS7Iefdhn6x8qCPd3rZDu3j15qhCPRACgzUvlXzryoPQQLwmkJ/NFLPAhFDVdmTLkE/7iFFaPesbDfcPuerJVKYDMaJiCYFal8l7ft6jn0EBb/KPVdw78O4lTBUggeeY/IVyL8j7upzJeAU0HZzJmfeBWdETHZw5PDux1qzVBAy1dqbI/C1YkYYUCJ1u8u5tw8HifzIub6bfI4i5lekqz2z1EhwLcv/mJk4pn6FHgRjVNiSs+fcDl3Roz3Zo+6mGbA5p+C1ZKkmDq1W30ELyEqqKWdkte9EC8LjkVCxIF40X+7JGNLSTwsLAPY3nzvq1JluunmCOU9IxbllNOmd2cn03J7L8ofzTOMyX+HdCERZBPcrXDDy80+E3IJ0yNw37LF/2/RMISQT9PQ+61pgSxQUbfL9dNcSJLxxO8pnKvNk2exHin7+bP3hGVEPfxRwHDZTKbJddGHdx1GrIjopJrNFLgDsPDWppkFvh4g20yhH8j1NRP0PChYK6NJ2mQxktvhDwi1YNzpAOknAgBOWWpwhmlByQVe152iWegIjCBoHynds++Po7I7ZVD48kUFQIeoGYXa/N760o3Yn2zPvdBqbwDO7ME0vTmdCTWmIeomGYnfZnRfAZhDc7krvRhEdgM3j343eYb+qacjaRGXraMUEctMOre+e7HOuDeKF2YsUuNMm1wWG2STLoDvjv0yTewO0ENQYPJxJjQjAU47YrQesyEB7e14UDxaH4UByBo0+rNqaZIE1I4+2uBlMgLz7S5BHlyYjzhA1pd8G4H0+Jcbl216fRrfNmXoIG1TnAAAqUCH3WxT1qmN4Wf5eWwn6KW2IWA5zeV3EEzaG35GbTVOkoI8BgLZ1wWjRg28VcobcK4IClB6/G0aP0NcVUzEaY5TegS2pEPFF GF7LCKSh LR9EuUB+1GWKKQBgBpdwQ6BmMDhnBTuG4Ng4x6MhUjPu7OVUUUB4iGXmRnhHI6rH55tK7XMkzHvIJJHxhMaFDFuWHD74f1lDHxlxLTFiF4d5eNWfWA1kg8jMvy2eZ7kAuTwXoMcRmk2m/RDY9mK7Ywtn0oXQO2u11BJP6j+y4A+80vr0DSF8TysxBxJg2bzKoYI8Je4BzKFZQDosW1VRpEKo04hvMunysIb7z9Kw4W/hovJiqA2MEb9crJE8n04PbOBbR285xObWDMab8Xz8/5scY931zK6MmEEE1hs+b7iIfSizB8/nCMImPEvMRaJS3eZJT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kent, On Tue Jul 15, 2025 at 3:58 PM CEST, Vitaly Wool wrote: > diff --git a/fs/bcachefs/darray.c b/fs/bcachefs/darray.c > index e86d36d23e9e..928e83a1ce42 100644 > --- a/fs/bcachefs/darray.c > +++ b/fs/bcachefs/darray.c > @@ -21,7 +21,7 @@ int __bch2_darray_resize_noprof(darray_char *d, size_t = element_size, size_t new_ > return -ENOMEM; > =20 > void *data =3D likely(bytes < INT_MAX) > - ? kvmalloc_noprof(bytes, gfp) > + ? kvmalloc_node_align_noprof(bytes, 1, gfp, NUMA_NO_NODE) > : vmalloc_noprof(bytes); > if (!data) > return -ENOMEM; > diff --git a/fs/bcachefs/util.h b/fs/bcachefs/util.h > index 0a4b1d433621..2d6d4b547db8 100644 > --- a/fs/bcachefs/util.h > +++ b/fs/bcachefs/util.h > @@ -61,7 +61,7 @@ static inline void *bch2_kvmalloc_noprof(size_t n, gfp_= t flags) > { > void *p =3D unlikely(n >=3D INT_MAX) > ? vmalloc_noprof(n) > - : kvmalloc_noprof(n, flags & ~__GFP_ZERO); > + : kvmalloc_node_align_noprof(n, 1, flags & ~__GFP_ZERO, NUMA_NO_NODE); > if (p && (flags & __GFP_ZERO)) > memset(p, 0, n); > return p; I assume this is because kvmalloc(), and hence kvrealloc(), does this: /* Don't even allow crazy sizes */ if (unlikely(size > INT_MAX)) { WARN_ON_ONCE(!(flags & __GFP_NOWARN)); return NULL; } Do we still consider this a "crazy size"? :)