linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Benno Lossin" <lossin@kernel.org>
To: "Alice Ryhl" <aliceryhl@google.com>,
	"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Matthew Wilcox" <willy@infradead.org>,
	"Tamir Duberstein" <tamird@gmail.com>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	linux-mm@kvack.org, rust-for-linux@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] rust: alloc: specify the minimum alignment of each allocator
Date: Tue, 15 Jul 2025 18:01:44 +0200	[thread overview]
Message-ID: <DBCR6O0P8QSZ.30WTN1G293YC4@kernel.org> (raw)
In-Reply-To: <20250715-align-min-allocator-v1-1-3e1b2a5516c0@google.com>

On Tue Jul 15, 2025 at 3:46 PM CEST, Alice Ryhl wrote:
> The kernel's allocators sometimes provide a higher alignment than the
> end-user requested, so add a new constant on the Allocator trait to let
> the allocator specify what its minimum guaranteed alignment is.
>
> This allows the ForeignOwnable trait to provide a more accurate value of
> FOREIGN_ALIGN when using a pointer type such as Box, which will be
> useful with certain collections such as XArray that store its own data
> in the low bits of pointers.
>
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>

With the wording changed according to Danilo's suggestion:

Reviewed-by: Benno Lossin <lossin@kernel.org>

---
Cheers,
Benno

> ---
>  rust/kernel/alloc.rs           | 8 ++++++++
>  rust/kernel/alloc/allocator.rs | 8 ++++++++
>  2 files changed, 16 insertions(+)


  parent reply	other threads:[~2025-07-15 16:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-15 13:46 [PATCH 0/2] Take ARCH_KMALLOC_MINALIGN into account for build-time XArray check Alice Ryhl
2025-07-15 13:46 ` [PATCH 1/2] rust: alloc: specify the minimum alignment of each allocator Alice Ryhl
2025-07-15 14:05   ` Danilo Krummrich
2025-07-15 14:35     ` Alice Ryhl
2025-07-15 14:39       ` Danilo Krummrich
2025-07-15 16:01   ` Benno Lossin [this message]
2025-07-15 13:46 ` [PATCH 2/2] rust: alloc: take the allocator into account for FOREIGN_ALIGN Alice Ryhl
2025-07-15 14:19   ` Danilo Krummrich
2025-07-16  9:46     ` Alice Ryhl
2025-07-15 16:00   ` Benno Lossin
2025-07-15 16:23     ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBCR6O0P8QSZ.30WTN1G293YC4@kernel.org \
    --to=lossin@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=a.hindborg@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@gmail.com \
    --cc=tmgross@umich.edu \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).