From: "Danilo Krummrich" <dakr@kernel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>
Cc: "David Gow" <davidgow@google.com>,
"Alice Ryhl" <aliceryhl@google.com>, <lorenzo.stoakes@oracle.com>,
<vbabka@suse.cz>, <Liam.Howlett@oracle.com>, <urezki@gmail.com>,
<ojeda@kernel.org>, <alex.gaynor@gmail.com>,
<boqun.feng@gmail.com>, <gary@garyguo.net>,
<bjorn3_gh@protonmail.com>, <lossin@kernel.org>,
<a.hindborg@kernel.org>, <tmgross@umich.edu>,
<rust-for-linux@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH] rust: alloc: add missing trait item MIN_ALIGN to Cmalloc
Date: Sun, 24 Aug 2025 16:41:00 +0200 [thread overview]
Message-ID: <DCAQIN9545EF.3JSBD6IQI1PXW@kernel.org> (raw)
In-Reply-To: <CANiq72=Xp-u16fboZJvdRZCveRtAJLSTsiJMMDXsd2saKCU26w@mail.gmail.com>
On Sun Aug 24, 2025 at 4:07 PM CEST, Miguel Ojeda wrote:
> Yeah, since 1b1a946dc2b5 is in the same branch, and David already
> reviewed the main patch too, I think it is easier for you than trying
> to deal with all this otherwise.
Yeah, I also think there's nothing to backport.
I.e. the fact that Cmalloc does not provide the same minimum alignment
guarantees as Kmalloc and Vmalloc is not an issue for existing upstream code.
And fixing it for potential additions to the rusttest target in downstream code
doesn't seem worth the effort.
> For the other fix I sent that you already applied through DRM, I think
> we did the right thing, because it was not `alloc-next` and it was
> fairly trivial, so it made sense.
Yes, that one is correct.
prev parent reply other threads:[~2025-08-24 14:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-24 12:06 [PATCH] rust: alloc: add missing trait item MIN_ALIGN to Cmalloc Danilo Krummrich
2025-08-24 12:36 ` Alice Ryhl
2025-08-24 13:04 ` Danilo Krummrich
2025-08-24 13:18 ` Danilo Krummrich
2025-08-24 13:29 ` Danilo Krummrich
2025-08-24 14:07 ` Miguel Ojeda
2025-08-24 14:41 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCAQIN9545EF.3JSBD6IQI1PXW@kernel.org \
--to=dakr@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=davidgow@google.com \
--cc=gary@garyguo.net \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).